From: Heiko Carstens <hca@linux.ibm.com>
To: Qing Wang <wangqing@vivo.com>
Cc: Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: replace snprintf in show functions with sysfs_emit
Date: Mon, 18 Oct 2021 12:48:23 +0200 [thread overview]
Message-ID: <YW1Q93cGfKxbS6Iy@osiris> (raw)
In-Reply-To: <1634280655-4908-1-git-send-email-wangqing@vivo.com>
On Thu, Oct 14, 2021 at 11:50:54PM -0700, Qing Wang wrote:
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the coccicheck warnings:
> WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
> drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------
> drivers/s390/char/raw3270.c | 6 ++--
> drivers/s390/cio/chp.c | 2 +-
> 3 files changed, 41 insertions(+), 41 deletions(-)
This requires either Reviewed-by or Acked-by from dasd and cio
maintainers, which you already cc'ed.
next prev parent reply other threads:[~2021-10-18 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:50 [PATCH] s390: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-18 10:48 ` Heiko Carstens [this message]
2021-10-18 11:50 ` Vineeth Vijayan
2021-10-18 14:20 ` Joe Perches
2021-10-20 14:44 ` Stefan Haberland
2021-11-10 15:19 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW1Q93cGfKxbS6Iy@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=sth@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.