From: Heiko Carstens <hca@linux.ibm.com>
To: Stefan Haberland <sth@linux.ibm.com>
Cc: Qing Wang <wangqing@vivo.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: replace snprintf in show functions with sysfs_emit
Date: Wed, 10 Nov 2021 16:19:33 +0100 [thread overview]
Message-ID: <YYvjBWx1vgdsktJ1@osiris> (raw)
In-Reply-To: <1955ef45-d30f-5354-e514-2bc8f7d9cfb6@linux.ibm.com>
On Wed, Oct 20, 2021 at 04:44:01PM +0200, Stefan Haberland wrote:
> Am 15.10.21 um 08:50 schrieb Qing Wang:
> > show() must not use snprintf() when formatting the value to be
> > returned to user space.
> >
> > Fix the coccicheck warnings:
> > WARNING: use scnprintf or sprintf.
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> >
> > Signed-off-by: Qing Wang <wangqing@vivo.com>
> > ---
> > drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------
> >
>
> Thanks for the DASD changes. While I am totally fine with the change itself
> I agree with Joe's remark.
> Would you like to improve your patch? Otherwise I can add a small follow on
> patch. Just let me know.
I translated this to Acked-by. Please provide an addon patch if you
want to have this changed.
Applied, thanks!
prev parent reply other threads:[~2021-11-10 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:50 [PATCH] s390: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-18 10:48 ` Heiko Carstens
2021-10-18 11:50 ` Vineeth Vijayan
2021-10-18 14:20 ` Joe Perches
2021-10-20 14:44 ` Stefan Haberland
2021-11-10 15:19 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYvjBWx1vgdsktJ1@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=sth@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.