All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	alsa-devel@alsa-project.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire: Fix C++ style comments in uapi header
Date: Mon, 18 Oct 2021 21:17:25 +0900	[thread overview]
Message-ID: <YW1l1U4/isAd2xzc@workstation> (raw)
In-Reply-To: <20211018063700.30834-1-tiwai@suse.de>

Hi,

On Mon, Oct 18, 2021 at 08:37:00AM +0200, Takashi Iwai wrote:
> UAPI headers are built with -std=c90 and C++ style comments are
> explicitly prohibited.  The recent commit overlooked the rule and
> caused the error at header installation.  This patch corrects those.
> 
> Fixes: bea36afa102e ("ALSA: firewire-motu: add message parser to gather meter information in register DSP model")
> Fixes: 90b28f3bb85c ("ALSA: firewire-motu: add message parser for meter information in command DSP model")
> Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/r/20211018113812.0a16efb0@canb.auug.org.au
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  include/uapi/sound/firewire.h | 70 ++++++++++++++++++-----------------
>  1 file changed, 37 insertions(+), 33 deletions(-)

I completely overlooked it. Thanks for your reporting.

Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Regards

Takashi Sakamoto

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire: Fix C++ style comments in uapi header
Date: Mon, 18 Oct 2021 21:17:25 +0900	[thread overview]
Message-ID: <YW1l1U4/isAd2xzc@workstation> (raw)
In-Reply-To: <20211018063700.30834-1-tiwai@suse.de>

Hi,

On Mon, Oct 18, 2021 at 08:37:00AM +0200, Takashi Iwai wrote:
> UAPI headers are built with -std=c90 and C++ style comments are
> explicitly prohibited.  The recent commit overlooked the rule and
> caused the error at header installation.  This patch corrects those.
> 
> Fixes: bea36afa102e ("ALSA: firewire-motu: add message parser to gather meter information in register DSP model")
> Fixes: 90b28f3bb85c ("ALSA: firewire-motu: add message parser for meter information in command DSP model")
> Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/r/20211018113812.0a16efb0@canb.auug.org.au
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  include/uapi/sound/firewire.h | 70 ++++++++++++++++++-----------------
>  1 file changed, 37 insertions(+), 33 deletions(-)

I completely overlooked it. Thanks for your reporting.

Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Regards

Takashi Sakamoto

  reply	other threads:[~2021-10-18 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18  6:37 [PATCH] ALSA: firewire: Fix C++ style comments in uapi header Takashi Iwai
2021-10-18  6:37 ` Takashi Iwai
2021-10-18 12:17 ` Takashi Sakamoto [this message]
2021-10-18 12:17   ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW1l1U4/isAd2xzc@workstation \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.