From: Vivek Goyal <vgoyal@redhat.com>
To: Hanna Reitz <hreitz@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH v4 00/12] virtiofsd: Allow using file handles instead of O_PATH FDs
Date: Mon, 18 Oct 2021 14:08:02 -0400 [thread overview]
Message-ID: <YW24Aoj6/boyYyj3@redhat.com> (raw)
In-Reply-To: <20210916084045.31684-1-hreitz@redhat.com>
On Thu, Sep 16, 2021 at 10:40:33AM +0200, Hanna Reitz wrote:
[..]
> Second, I’ve renamed the TempFd objects to reflect what kind of FDs they
> contain; i.e. they’re no longer called “inode_fd” or “dir_fd”, but
> “path_fd”, “rw_fd”, or “dir_path_fd” instead.
This change is really helpful. Makes it easier to read code and figure
out which fd we are referring to.
Vivek
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Hanna Reitz <hreitz@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v4 00/12] virtiofsd: Allow using file handles instead of O_PATH FDs
Date: Mon, 18 Oct 2021 14:08:02 -0400 [thread overview]
Message-ID: <YW24Aoj6/boyYyj3@redhat.com> (raw)
In-Reply-To: <20210916084045.31684-1-hreitz@redhat.com>
On Thu, Sep 16, 2021 at 10:40:33AM +0200, Hanna Reitz wrote:
[..]
> Second, I’ve renamed the TempFd objects to reflect what kind of FDs they
> contain; i.e. they’re no longer called “inode_fd” or “dir_fd”, but
> “path_fd”, “rw_fd”, or “dir_path_fd” instead.
This change is really helpful. Makes it easier to read code and figure
out which fd we are referring to.
Vivek
next prev parent reply other threads:[~2021-10-18 18:08 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:40 [Virtio-fs] [PATCH v4 00/12] virtiofsd: Allow using file handles instead of O_PATH FDs Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 01/12] virtiofsd: Keep /proc/self/mountinfo open Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-10-18 17:07 ` [Virtio-fs] " Vivek Goyal
2021-10-18 17:07 ` Vivek Goyal
2021-10-20 9:04 ` [Virtio-fs] " Hanna Reitz
2021-10-20 9:04 ` Hanna Reitz
2021-10-20 18:25 ` [Virtio-fs] " Vivek Goyal
2021-10-20 18:25 ` Vivek Goyal
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 02/12] virtiofsd: Limit setxattr()'s creds-dropped region Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-10-18 17:20 ` [Virtio-fs] " Vivek Goyal
2021-10-18 17:20 ` Vivek Goyal
2021-10-20 9:11 ` [Virtio-fs] " Hanna Reitz
2021-10-20 9:11 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 03/12] virtiofsd: Add TempFd structure Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 04/12] virtiofsd: Use lo_inode_open() instead of openat() Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 05/12] virtiofsd: Add lo_inode_fd() helper Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 06/12] virtiofsd: Let lo_fd() return a TempFd Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 07/12] virtiofsd: Let lo_inode_open() " Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-10-18 19:18 ` [Virtio-fs] " Vivek Goyal
2021-10-18 19:18 ` Vivek Goyal
2021-10-20 9:15 ` [Virtio-fs] " Hanna Reitz
2021-10-20 9:15 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 08/12] virtiofsd: Pass lo_data to lo_inode_{fd, open}() Hanna Reitz
2021-09-16 8:40 ` [PATCH v4 08/12] virtiofsd: Pass lo_data to lo_inode_{fd,open}() Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 09/12] virtiofsd: Add lo_inode.fhandle Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 10/12] virtiofsd: Add inodes_by_handle hash table Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-10-19 20:02 ` [Virtio-fs] " Vivek Goyal
2021-10-19 20:02 ` Vivek Goyal
2021-10-20 10:02 ` [Virtio-fs] " Hanna Reitz
2021-10-20 10:02 ` Hanna Reitz
2021-10-20 12:29 ` [Virtio-fs] " Vivek Goyal
2021-10-20 12:29 ` Vivek Goyal
2021-10-20 14:10 ` [Virtio-fs] " Hanna Reitz
2021-10-20 14:10 ` Hanna Reitz
2021-10-20 18:06 ` [Virtio-fs] " Vivek Goyal
2021-10-20 18:06 ` Vivek Goyal
2021-10-20 12:53 ` [Virtio-fs] " Vivek Goyal
2021-10-20 12:53 ` Vivek Goyal
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 11/12] virtiofsd: Optionally fill lo_inode.fhandle Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-10-19 18:57 ` [Virtio-fs] " Vivek Goyal
2021-10-19 18:57 ` Vivek Goyal
2021-10-20 10:00 ` [Virtio-fs] " Hanna Reitz
2021-10-20 10:00 ` Hanna Reitz
2021-10-20 18:53 ` [Virtio-fs] " Vivek Goyal
2021-10-20 18:53 ` Vivek Goyal
2021-09-16 8:40 ` [Virtio-fs] [PATCH v4 12/12] virtiofsd: Add lazy lo_do_find() Hanna Reitz
2021-09-16 8:40 ` Hanna Reitz
2021-10-18 18:08 ` Vivek Goyal [this message]
2021-10-18 18:08 ` [PATCH v4 00/12] virtiofsd: Allow using file handles instead of O_PATH FDs Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW24Aoj6/boyYyj3@redhat.com \
--to=vgoyal@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.