From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, Suman Anna <s-anna@ti.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH 3/3] dt-bindings: bus: ti-sysc: Update to use yaml binding
Date: Mon, 11 Oct 2021 08:50:57 +0300 [thread overview]
Message-ID: <YWPQwVd9+qvmoD6O@atomide.com> (raw)
In-Reply-To: <YWCsdFWzXEpPyYAI@robh.at.kernel.org>
Hi,
* Rob Herring <robh@kernel.org> [211008 20:39]:
> On Thu, Oct 07, 2021 at 03:48:58PM +0300, Tony Lindgren wrote:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - ti,sysc-omap2
> > + - ti,sysc-omap2
> > + - ti,sysc-omap4
> > + - ti,sysc-omap4-simple
> > + - ti,sysc-omap2-timer
> > + - ti,sysc-omap4-timer
> > + - ti,sysc-omap3430-sr
> > + - ti,sysc-omap3630-sr
> > + - ti,sysc-omap4-sr
> > + - ti,sysc-omap3-sham
> > + - ti,sysc-omap-aes
> > + - ti,sysc-mcasp
> > + - ti,sysc-dra7-mcasp
> > + - ti,sysc-usb-host-fs
> > + - ti,sysc-dra7-mcan
> > + - ti,sysc-pruss
> > + - const: ti,sysc
> > + - items:
> > + - const: ti,sysc
>
> This doesn't really match what the old doc said nor the old example.
> Fine to fix in the conversion if wrong, but just highlight that in the
> commit msg.
OK yes we currently always need "ti,sysc" as the clockdomain autoidle
handling still relies on auxdata.
> > +
> > + reg: true
>
> Any number of register areas is valid?
Yes the number of registers is known, I'll update to use max three reg.
> > +
> > + reg-names: true
>
> You've thrown out the names defined before.
Yup these are known too.
> > +
> > + clocks: true
>
> Any number of clocks is valid?
I think 8 clocks is the highest seen :)
> > + clock-names: true
>
> You've thrown out the names defined before.
Hmm fck and ick can be named, the rest are device specific though.
> > +
> > + power-domains: true
>
> How many?
Just one should be enough here.
> > +additionalProperties: true
>
> This can be restricted to child nodes only? If so:
>
> additionalProperties:
> type: object
OK great, this can be limited to child nodes only.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org,
Simon Horman <horms+renesas@verge.net.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] dt-bindings: bus: ti-sysc: Update to use yaml binding
Date: Mon, 11 Oct 2021 08:50:57 +0300 [thread overview]
Message-ID: <YWPQwVd9+qvmoD6O@atomide.com> (raw)
In-Reply-To: <YWCsdFWzXEpPyYAI@robh.at.kernel.org>
Hi,
* Rob Herring <robh@kernel.org> [211008 20:39]:
> On Thu, Oct 07, 2021 at 03:48:58PM +0300, Tony Lindgren wrote:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - ti,sysc-omap2
> > + - ti,sysc-omap2
> > + - ti,sysc-omap4
> > + - ti,sysc-omap4-simple
> > + - ti,sysc-omap2-timer
> > + - ti,sysc-omap4-timer
> > + - ti,sysc-omap3430-sr
> > + - ti,sysc-omap3630-sr
> > + - ti,sysc-omap4-sr
> > + - ti,sysc-omap3-sham
> > + - ti,sysc-omap-aes
> > + - ti,sysc-mcasp
> > + - ti,sysc-dra7-mcasp
> > + - ti,sysc-usb-host-fs
> > + - ti,sysc-dra7-mcan
> > + - ti,sysc-pruss
> > + - const: ti,sysc
> > + - items:
> > + - const: ti,sysc
>
> This doesn't really match what the old doc said nor the old example.
> Fine to fix in the conversion if wrong, but just highlight that in the
> commit msg.
OK yes we currently always need "ti,sysc" as the clockdomain autoidle
handling still relies on auxdata.
> > +
> > + reg: true
>
> Any number of register areas is valid?
Yes the number of registers is known, I'll update to use max three reg.
> > +
> > + reg-names: true
>
> You've thrown out the names defined before.
Yup these are known too.
> > +
> > + clocks: true
>
> Any number of clocks is valid?
I think 8 clocks is the highest seen :)
> > + clock-names: true
>
> You've thrown out the names defined before.
Hmm fck and ick can be named, the rest are device specific though.
> > +
> > + power-domains: true
>
> How many?
Just one should be enough here.
> > +additionalProperties: true
>
> This can be restricted to child nodes only? If so:
>
> additionalProperties:
> type: object
OK great, this can be limited to child nodes only.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-11 5:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:48 [PATCH 0/3] Updates for simple-pm-bus and ti-sysc bindings Tony Lindgren
2021-10-07 12:48 ` Tony Lindgren
2021-10-07 12:48 ` [PATCH 1/3] dt-bindings: bus: simple-pm-bus: Make clocks and power-domains optional Tony Lindgren
2021-10-07 12:48 ` Tony Lindgren
2021-10-07 13:26 ` Geert Uytterhoeven
2021-10-07 13:26 ` Geert Uytterhoeven
2021-10-07 17:24 ` Tony Lindgren
2021-10-07 17:24 ` Tony Lindgren
2021-10-07 17:57 ` Geert Uytterhoeven
2021-10-07 17:57 ` Geert Uytterhoeven
2021-10-07 18:17 ` Tony Lindgren
2021-10-07 18:17 ` Tony Lindgren
2021-10-07 12:48 ` [PATCH 2/3] dt-bindings: bus: simple-pm-bus: Add more matches for node name Tony Lindgren
2021-10-07 12:48 ` Tony Lindgren
2021-10-07 12:48 ` [PATCH 3/3] dt-bindings: bus: ti-sysc: Update to use yaml binding Tony Lindgren
2021-10-07 12:48 ` Tony Lindgren
2021-10-08 2:46 ` Rob Herring
2021-10-08 2:46 ` Rob Herring
2021-10-08 20:39 ` Rob Herring
2021-10-08 20:39 ` Rob Herring
2021-10-11 5:50 ` Tony Lindgren [this message]
2021-10-11 5:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWPQwVd9+qvmoD6O@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.