* [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32
@ 2021-10-12 11:52 Vegard Nossum
2021-10-12 12:04 ` Vegard Nossum
2021-10-12 19:45 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Vegard Nossum @ 2021-10-12 11:52 UTC (permalink / raw)
To: Stefan Mavrodiev
Cc: Sam Ravnborg, dri-devel, linux-kernel, Vegard Nossum,
Arnd Bergmann
Fix the following build/link error by adding a dependency on the CRC32
routines:
ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe':
panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le'
Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel")
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index beb581b96ecdc..418638e6e3b0a 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO
depends on OF
depends on I2C
depends on BACKLIGHT_CLASS_DEVICE
+ select CRC32
help
The panel is used with different sizes LCDs, from 480x272 to
1280x800, and 24 bit per pixel.
--
2.23.0.718.g5ad94255a8
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32
2021-10-12 11:52 [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32 Vegard Nossum
@ 2021-10-12 12:04 ` Vegard Nossum
2021-10-12 19:45 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Vegard Nossum @ 2021-10-12 12:04 UTC (permalink / raw)
To: Thierry Reding; +Cc: Sam Ravnborg, dri-devel, linux-kernel, Arnd Bergmann
Hi Thierry,
I tried sending the patch below to Stefan Mavrodiev <stefan@olimex.com>
(listed in MAINTAINERS for DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS)
but it bounced with "No such user at that domain".
Will you take the patch and/or update the MAINTAINERS entry?
Thanks,
Vegard
On 10/12/21 1:52 PM, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe':
> panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le'
>
> Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index beb581b96ecdc..418638e6e3b0a 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO
> depends on OF
> depends on I2C
> depends on BACKLIGHT_CLASS_DEVICE
> + select CRC32
> help
> The panel is used with different sizes LCDs, from 480x272 to
> 1280x800, and 24 bit per pixel.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32
2021-10-12 11:52 [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32 Vegard Nossum
2021-10-12 12:04 ` Vegard Nossum
@ 2021-10-12 19:45 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2021-10-12 19:45 UTC (permalink / raw)
To: Vegard Nossum; +Cc: Stefan Mavrodiev, dri-devel, linux-kernel, Arnd Bergmann
Hi Vegard,
On Tue, Oct 12, 2021 at 01:52:42PM +0200, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe':
> panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le'
>
> Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
thanks. Applied to drm-misc-fixes. It will turn up in master in a week
or two.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-12 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 11:52 [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32 Vegard Nossum
2021-10-12 12:04 ` Vegard Nossum
2021-10-12 19:45 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.