All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Intel-gfx] [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.
Date: Thu, 14 Oct 2021 15:21:22 +0200	[thread overview]
Message-ID: <YWgu0v5iPDFViHXS@phenom.ffwll.local> (raw)
In-Reply-To: <20211013173548.nldcwheo4t52dgvp@linutronix.de>

On Wed, Oct 13, 2021 at 07:35:48PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-10-13 14:57:34 [+0200], Daniel Vetter wrote:
> > Hm there's a pile of commits there, and nothing immediately jumps to
> > light. The thing is, 18 is likely way too much, since if e.g. we have a
> > single new property on a plane and that pushes over the limit on all of
> > them, you get iirc 3x4 already simply because we have that many planes.
> > 
> > So would be good to know the actual culprit.
> > 
> > Can you pls try to bisect the above range, applying the patch as a fixup
> > locally (without commit, that will confuse git bisect a bit I think), so
> > we know what/where went wrong?
> 
> c7fcbf2513973 -> does not boot
> c7fcbf2513973 + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY
> 6f11f37459d8f -> boots, 0 x DRM_OBJECT_MAX_PROPERTY
> 6f11f37459d8f + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY

Just to check, you've built 6f11f37459d8f, and then you cherry-picked
2f425cf5242a0 on top (not merged), and that already got you the warning
flood?

I'm probably blind, but I'm really not seeing where this pile of
properties is coming from. Can you pls also boot with drm.debug=0xe and
attach full dmesg? Plus your .config please.

Thanks, Daniel

> 
> > I'm still confused why this isn't showing up anywhere in our intel ci ...
> > 
> > Thanks, Daniel
> 
> Sebastian

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.
Date: Thu, 14 Oct 2021 15:21:22 +0200	[thread overview]
Message-ID: <YWgu0v5iPDFViHXS@phenom.ffwll.local> (raw)
In-Reply-To: <20211013173548.nldcwheo4t52dgvp@linutronix.de>

On Wed, Oct 13, 2021 at 07:35:48PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-10-13 14:57:34 [+0200], Daniel Vetter wrote:
> > Hm there's a pile of commits there, and nothing immediately jumps to
> > light. The thing is, 18 is likely way too much, since if e.g. we have a
> > single new property on a plane and that pushes over the limit on all of
> > them, you get iirc 3x4 already simply because we have that many planes.
> > 
> > So would be good to know the actual culprit.
> > 
> > Can you pls try to bisect the above range, applying the patch as a fixup
> > locally (without commit, that will confuse git bisect a bit I think), so
> > we know what/where went wrong?
> 
> c7fcbf2513973 -> does not boot
> c7fcbf2513973 + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY
> 6f11f37459d8f -> boots, 0 x DRM_OBJECT_MAX_PROPERTY
> 6f11f37459d8f + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY

Just to check, you've built 6f11f37459d8f, and then you cherry-picked
2f425cf5242a0 on top (not merged), and that already got you the warning
flood?

I'm probably blind, but I'm really not seeing where this pile of
properties is coming from. Can you pls also boot with drm.debug=0xe and
attach full dmesg? Plus your .config please.

Thanks, Daniel

> 
> > I'm still confused why this isn't showing up anywhere in our intel ci ...
> > 
> > Thanks, Daniel
> 
> Sebastian

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2021-10-14 13:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  6:51 [Intel-gfx] [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18 Sebastian Andrzej Siewior
2021-10-05  6:51 ` Sebastian Andrzej Siewior
2021-10-05  7:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-10-05  8:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-05 10:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-13 12:02 ` [Intel-gfx] [RFC PATCH] " Daniel Vetter
2021-10-13 12:02   ` Daniel Vetter
2021-10-13 12:35   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-10-13 12:35     ` Sebastian Andrzej Siewior
2021-10-13 12:57     ` [Intel-gfx] " Daniel Vetter
2021-10-13 12:57       ` Daniel Vetter
2021-10-13 17:35       ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-10-13 17:35         ` Sebastian Andrzej Siewior
2021-10-14 13:21         ` Daniel Vetter [this message]
2021-10-14 13:21           ` Daniel Vetter
2021-10-14 13:47           ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-10-14 13:47             ` Sebastian Andrzej Siewior
2021-10-19 12:24             ` [Intel-gfx] " Daniel Vetter
2021-10-19 12:24               ` Daniel Vetter
2021-10-19 13:14               ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-10-19 13:14                 ` Sebastian Andrzej Siewior
2021-10-19 17:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Increase DRM_OBJECT_MAX_PROPERTY by 18. (rev2) Patchwork
2021-10-19 17:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWgu0v5iPDFViHXS@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=bigeasy@linutronix.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.