* Re: [Buildroot] [PATCH] package/ltp-testsuite: Add Open POSIX and realtime test suite opts
[not found] <20211015110135.15960-1-rpalethorpe@suse.com>
@ 2021-10-15 20:10 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-10-15 20:10 UTC (permalink / raw)
To: Richard Palethorpe; +Cc: io, Thomas Petazzoni, buildroot
Hi Richie,
[ Cc Arnout, Peter and Thomas in case they push your patch through pending line ]
> During LTP and/or kernel development it's very rare that I want the
> Open POSIX and the realtime tests. Open POSIX in particular takes
> considerable time to build. So this adds the option of disabling them.
> They default to on so as not to break existing test automation.
Thanks a lot, I always wanted to do this.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
I don't see you patch in patchwork [1], nor in lore [2].
Have you registered to buildroot ML?
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/project/buildroot/list/?series=&submitter=&state=*&q=ltp&archive=&delegate=
[2] https://lore.kernel.org/buildroot/?q=rpalethorpe%40suse.com
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> Cc: io@richiejp.com
> ---
> package/ltp-testsuite/Config.in | 16 ++++++++++++++++
> package/ltp-testsuite/ltp-testsuite.mk | 10 +++++++---
> 2 files changed, 23 insertions(+), 3 deletions(-)
> diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
> index 32e1b6ad76..272c2ede37 100644
> --- a/package/ltp-testsuite/Config.in
> +++ b/package/ltp-testsuite/Config.in
> @@ -20,6 +20,22 @@ config BR2_PACKAGE_LTP_TESTSUITE
> http://linux-test-project.github.io
> +if BR2_PACKAGE_LTP_TESTSUITE
> +
> +config BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX
> + bool "Open POSIX testsuite"
> + default y
> + help
> + Test suite for POSIX compliance. Included with the LTP.
> +
> +config BR2_PACKAGE_LTP_TESTSUITE_REALTIME
> + bool "Realtime testsuite"
> + default y
> + help
> + Test suite for realtime kernels. Included with the LTP.
> +
> +endif
> +
> comment "ltp-testsuite needs a toolchain w/ NPTL"
> depends on BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
> depends on BR2_USE_MMU
> diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> index 3d8fe3b78c..93d951fe1a 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -11,9 +11,13 @@ LTP_TESTSUITE_SITE = https://github.com/linux-test-project/ltp/releases/download
> LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
> LTP_TESTSUITE_LICENSE_FILES = COPYING
> -LTP_TESTSUITE_CONF_OPTS += \
> - --with-realtime-testsuite --with-open-posix-testsuite \
> - --disable-metadata
nit: Maybe add blank line here for readability.
> +LTP_TESTSUITE_CONF_OPTS += --disable-metadata
> +ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX),y)
> +LTP_TESTSUITE_CONF_OPTS += --with-open-posix-testsuite
> +endif
And also here.
> +ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_REALTIME),y)
> +LTP_TESTSUITE_CONF_OPTS += --with-realtime-testsuite
> +endif
> ifeq ($(BR2_LINUX_KERNEL),y)
> LTP_TESTSUITE_DEPENDENCIES += linux
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/ltp-testsuite: Add Open POSIX and realtime test suite opts
@ 2021-10-21 11:23 Richard Palethorpe via buildroot
2021-10-21 16:29 ` Petr Vorel
2021-10-26 19:59 ` Arnout Vandecappelle
0 siblings, 2 replies; 4+ messages in thread
From: Richard Palethorpe via buildroot @ 2021-10-21 11:23 UTC (permalink / raw)
To: buildroot; +Cc: io, Richard Palethorpe
During LTP and/or kernel development it's very rare that I want the
Open POSIX and the realtime tests. Open POSIX in particular takes
considerable time to build. So this adds the option of disabling them.
They default to on so as not to break existing test automation.
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Cc: io@richiejp.com
---
package/ltp-testsuite/Config.in | 16 ++++++++++++++++
package/ltp-testsuite/ltp-testsuite.mk | 12 +++++++++---
2 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
index 32e1b6ad76..272c2ede37 100644
--- a/package/ltp-testsuite/Config.in
+++ b/package/ltp-testsuite/Config.in
@@ -20,6 +20,22 @@ config BR2_PACKAGE_LTP_TESTSUITE
http://linux-test-project.github.io
+if BR2_PACKAGE_LTP_TESTSUITE
+
+config BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX
+ bool "Open POSIX testsuite"
+ default y
+ help
+ Test suite for POSIX compliance. Included with the LTP.
+
+config BR2_PACKAGE_LTP_TESTSUITE_REALTIME
+ bool "Realtime testsuite"
+ default y
+ help
+ Test suite for realtime kernels. Included with the LTP.
+
+endif
+
comment "ltp-testsuite needs a toolchain w/ NPTL"
depends on BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
depends on BR2_USE_MMU
diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
index 3d8fe3b78c..cc6d3c63b6 100644
--- a/package/ltp-testsuite/ltp-testsuite.mk
+++ b/package/ltp-testsuite/ltp-testsuite.mk
@@ -11,9 +11,15 @@ LTP_TESTSUITE_SITE = https://github.com/linux-test-project/ltp/releases/download
LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
LTP_TESTSUITE_LICENSE_FILES = COPYING
-LTP_TESTSUITE_CONF_OPTS += \
- --with-realtime-testsuite --with-open-posix-testsuite \
- --disable-metadata
+LTP_TESTSUITE_CONF_OPTS += --disable-metadata
+
+ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX),y)
+LTP_TESTSUITE_CONF_OPTS += --with-open-posix-testsuite
+endif
+
+ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_REALTIME),y)
+LTP_TESTSUITE_CONF_OPTS += --with-realtime-testsuite
+endif
ifeq ($(BR2_LINUX_KERNEL),y)
LTP_TESTSUITE_DEPENDENCIES += linux
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/ltp-testsuite: Add Open POSIX and realtime test suite opts
2021-10-21 11:23 Richard Palethorpe via buildroot
@ 2021-10-21 16:29 ` Petr Vorel
2021-10-26 19:59 ` Arnout Vandecappelle
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-10-21 16:29 UTC (permalink / raw)
To: Richard Palethorpe; +Cc: io, buildroot
Hi Richie, all,
as I wrote to the first post (which didn't landed to ML):
Thanks a lot, I always wanted to do this.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/ltp-testsuite: Add Open POSIX and realtime test suite opts
2021-10-21 11:23 Richard Palethorpe via buildroot
2021-10-21 16:29 ` Petr Vorel
@ 2021-10-26 19:59 ` Arnout Vandecappelle
1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-10-26 19:59 UTC (permalink / raw)
To: Richard Palethorpe, buildroot; +Cc: io
On 21/10/2021 13:23, Richard Palethorpe via buildroot wrote:
> During LTP and/or kernel development it's very rare that I want the
> Open POSIX and the realtime tests. Open POSIX in particular takes
> considerable time to build. So this adds the option of disabling them.
>
> They default to on so as not to break existing test automation.
>
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> Cc: io@richiejp.com
Applied to master, thanks.
Regards,
Arnout
> ---
> package/ltp-testsuite/Config.in | 16 ++++++++++++++++
> package/ltp-testsuite/ltp-testsuite.mk | 12 +++++++++---
> 2 files changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
> index 32e1b6ad76..272c2ede37 100644
> --- a/package/ltp-testsuite/Config.in
> +++ b/package/ltp-testsuite/Config.in
> @@ -20,6 +20,22 @@ config BR2_PACKAGE_LTP_TESTSUITE
>
> http://linux-test-project.github.io
>
> +if BR2_PACKAGE_LTP_TESTSUITE
> +
> +config BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX
> + bool "Open POSIX testsuite"
> + default y
> + help
> + Test suite for POSIX compliance. Included with the LTP.
> +
> +config BR2_PACKAGE_LTP_TESTSUITE_REALTIME
> + bool "Realtime testsuite"
> + default y
> + help
> + Test suite for realtime kernels. Included with the LTP.
> +
> +endif
> +
> comment "ltp-testsuite needs a toolchain w/ NPTL"
> depends on BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
> depends on BR2_USE_MMU
> diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> index 3d8fe3b78c..cc6d3c63b6 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -11,9 +11,15 @@ LTP_TESTSUITE_SITE = https://github.com/linux-test-project/ltp/releases/download
> LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
> LTP_TESTSUITE_LICENSE_FILES = COPYING
>
> -LTP_TESTSUITE_CONF_OPTS += \
> - --with-realtime-testsuite --with-open-posix-testsuite \
> - --disable-metadata
> +LTP_TESTSUITE_CONF_OPTS += --disable-metadata
> +
> +ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX),y)
> +LTP_TESTSUITE_CONF_OPTS += --with-open-posix-testsuite
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_REALTIME),y)
> +LTP_TESTSUITE_CONF_OPTS += --with-realtime-testsuite
> +endif
>
> ifeq ($(BR2_LINUX_KERNEL),y)
> LTP_TESTSUITE_DEPENDENCIES += linux
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-26 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211015110135.15960-1-rpalethorpe@suse.com>
2021-10-15 20:10 ` [Buildroot] [PATCH] package/ltp-testsuite: Add Open POSIX and realtime test suite opts Petr Vorel
2021-10-21 11:23 Richard Palethorpe via buildroot
2021-10-21 16:29 ` Petr Vorel
2021-10-26 19:59 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.