From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kees Cook <keescook@chromium.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Florian Westphal <fw@strlen.de>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [Bridge] [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from, to}_user()
Date: Thu, 21 Oct 2021 20:16:03 +0200 [thread overview]
Message-ID: <YXGuY2LjiBb5M+jn@salvia> (raw)
In-Reply-To: <202110210958.6626A30@keescook>
On Thu, Oct 21, 2021 at 10:00:34AM -0700, Kees Cook wrote:
> On Tue, Sep 28, 2021 at 03:06:47PM -0500, Gustavo A. R. Silva wrote:
> > Use array_size() helper instead of the open-coded version in
> > copy_{from,to}_user(). These sorts of multiplication factors
> > need to be wrapped in array_size().
> >
> > Link: https://github.com/KSPP/linux/issues/160
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Thanks!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> I see that this is marked "Awaiting Upstream" (for an ebtables
> maintainer ack?)
> https://patchwork.kernel.org/project/netdevbpf/patch/20210928200647.GA266402@embeddedor/
I'll route this through the netfilter tree, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from,to}_user()
Date: Thu, 21 Oct 2021 20:16:03 +0200 [thread overview]
Message-ID: <YXGuY2LjiBb5M+jn@salvia> (raw)
In-Reply-To: <202110210958.6626A30@keescook>
On Thu, Oct 21, 2021 at 10:00:34AM -0700, Kees Cook wrote:
> On Tue, Sep 28, 2021 at 03:06:47PM -0500, Gustavo A. R. Silva wrote:
> > Use array_size() helper instead of the open-coded version in
> > copy_{from,to}_user(). These sorts of multiplication factors
> > need to be wrapped in array_size().
> >
> > Link: https://github.com/KSPP/linux/issues/160
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Thanks!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> I see that this is marked "Awaiting Upstream" (for an ebtables
> maintainer ack?)
> https://patchwork.kernel.org/project/netdevbpf/patch/20210928200647.GA266402@embeddedor/
I'll route this through the netfilter tree, thanks.
next prev parent reply other threads:[~2021-10-21 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 20:06 [Bridge] [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from, to}_user() Gustavo A. R. Silva
2021-09-28 20:06 ` [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from,to}_user() Gustavo A. R. Silva
2021-10-21 17:00 ` [Bridge] [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from, to}_user() Kees Cook
2021-10-21 17:00 ` [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from,to}_user() Kees Cook
2021-10-21 18:16 ` Pablo Neira Ayuso [this message]
2021-10-21 18:16 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXGuY2LjiBb5M+jn@salvia \
--to=pablo@netfilter.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=gustavoars@kernel.org \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.