From: Wolfram Sang <wsa@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1 3/3] mfd: tps80031: Remove driver
Date: Fri, 22 Oct 2021 10:46:45 +0200 [thread overview]
Message-ID: <YXJ6deXN7vWrSc++@ninjato> (raw)
In-Reply-To: <b8f6dffb-ec7b-c105-51f1-7b761e331a89@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
> It's I2C driver. I'm not sure about auto-probing because something
> should provide information about device to Linux. It's possible to
> detect/scan whether there is device sitting on I2C address, but there is
> no auto-discovery mechanism, AFAIK.
Well, in general, it could be manually instantiated from userspace...
>
> TPS80031 device will fail to bind to this driver because it explicitly
> requires platform data which should be NULL if device is probed solely
> by I2C ID.
..but I agree in this case. The driver has this code:
if (!pdata) {
dev_err(&client->dev, "tps80031 requires platform data\n");
return -EINVAL;
}
and git grep shows no user having platform data.
Shouldn't 'drivers/regulator/tps80031-regulator.c' and
'./rtc/rtc-tps80031.c' be removed as well?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-22 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 19:22 [PATCH v1 0/3] Remove TPS80031 driver Dmitry Osipenko
2021-10-21 19:22 ` [PATCH v1 1/3] rtc: tps80031: Remove driver Dmitry Osipenko
2021-10-23 21:55 ` (subset) " Alexandre Belloni
2021-10-21 19:22 ` [PATCH v1 2/3] regulator: " Dmitry Osipenko
2021-10-21 19:22 ` [PATCH v1 3/3] mfd: " Dmitry Osipenko
2021-10-22 8:05 ` Lee Jones
2021-10-22 8:20 ` Dmitry Osipenko
2021-10-22 8:46 ` Wolfram Sang [this message]
2021-10-22 8:50 ` Dmitry Osipenko
2021-10-22 9:54 ` Lee Jones
2021-10-22 10:02 ` Lee Jones
2021-10-23 19:58 ` (subset) [PATCH v1 0/3] Remove TPS80031 driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXJ6deXN7vWrSc++@ninjato \
--to=wsa@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.