From: Vinod Koul <vkoul@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
kael_w@yeah.net
Subject: Re: [PATCH] phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2
Date: Sun, 24 Oct 2021 22:44:59 +0530 [thread overview]
Message-ID: <YXWUk38hq/Np7EMc@matsya> (raw)
In-Reply-To: <20211015080154.16016-1-wanjiabing@vivo.com>
On 15-10-21, 04:01, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before break
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
kael_w@yeah.net
Subject: Re: [PATCH] phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2
Date: Sun, 24 Oct 2021 22:44:59 +0530 [thread overview]
Message-ID: <YXWUk38hq/Np7EMc@matsya> (raw)
In-Reply-To: <20211015080154.16016-1-wanjiabing@vivo.com>
On 15-10-21, 04:01, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before break
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2021-10-24 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 8:01 [PATCH] phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2 Wan Jiabing
2021-10-15 8:01 ` Wan Jiabing
2021-10-24 17:14 ` Vinod Koul [this message]
2021-10-24 17:14 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXWUk38hq/Np7EMc@matsya \
--to=vkoul@kernel.org \
--cc=kael_w@yeah.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.