All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "jason-jh.lin" <jason-jh.lin@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, hsinyi@chromium.org,
	fshao@chromium.org, nancy.lin@mediatek.com,
	singo.chang@mediatek.com
Subject: Re: [PATCH] mailbox: remove the error message when gce clk is defer
Date: Sun, 24 Oct 2021 21:25:57 +0100	[thread overview]
Message-ID: <YXXBVTEbjPiBm1un@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211023164831.25690-1-jason-jh.lin@mediatek.com>

On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> Remove the error message when gce clk is defer.
> 
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index fd5576a9f8b4..684b8aa1e445 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
>  				snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
>  				cmdq->clocks[alias_id].id = clk_id;
>  				cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
> -				if (IS_ERR(cmdq->clocks[alias_id].clk)) {
> +				if (IS_ERR(cmdq->clocks[alias_id].clk) &&
> +				    PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
>  					dev_err(dev, "failed to get gce clk: %d\n", alias_id);
>  					return PTR_ERR(cmdq->clocks[alias_id].clk);
>  				}

So when you get -EPROBE_DEFER, you omit the error message _and_ ignore
the -EPROBE_DEFER. Is that really what you want to do?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "jason-jh.lin" <jason-jh.lin@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, hsinyi@chromium.org,
	fshao@chromium.org, nancy.lin@mediatek.com,
	singo.chang@mediatek.com
Subject: Re: [PATCH] mailbox: remove the error message when gce clk is defer
Date: Sun, 24 Oct 2021 21:25:57 +0100	[thread overview]
Message-ID: <YXXBVTEbjPiBm1un@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211023164831.25690-1-jason-jh.lin@mediatek.com>

On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> Remove the error message when gce clk is defer.
> 
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index fd5576a9f8b4..684b8aa1e445 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
>  				snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
>  				cmdq->clocks[alias_id].id = clk_id;
>  				cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
> -				if (IS_ERR(cmdq->clocks[alias_id].clk)) {
> +				if (IS_ERR(cmdq->clocks[alias_id].clk) &&
> +				    PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
>  					dev_err(dev, "failed to get gce clk: %d\n", alias_id);
>  					return PTR_ERR(cmdq->clocks[alias_id].clk);
>  				}

So when you get -EPROBE_DEFER, you omit the error message _and_ ignore
the -EPROBE_DEFER. Is that really what you want to do?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "jason-jh.lin" <jason-jh.lin@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, hsinyi@chromium.org,
	fshao@chromium.org, nancy.lin@mediatek.com,
	singo.chang@mediatek.com
Subject: Re: [PATCH] mailbox: remove the error message when gce clk is defer
Date: Sun, 24 Oct 2021 21:25:57 +0100	[thread overview]
Message-ID: <YXXBVTEbjPiBm1un@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211023164831.25690-1-jason-jh.lin@mediatek.com>

On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> Remove the error message when gce clk is defer.
> 
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index fd5576a9f8b4..684b8aa1e445 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
>  				snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
>  				cmdq->clocks[alias_id].id = clk_id;
>  				cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
> -				if (IS_ERR(cmdq->clocks[alias_id].clk)) {
> +				if (IS_ERR(cmdq->clocks[alias_id].clk) &&
> +				    PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
>  					dev_err(dev, "failed to get gce clk: %d\n", alias_id);
>  					return PTR_ERR(cmdq->clocks[alias_id].clk);
>  				}

So when you get -EPROBE_DEFER, you omit the error message _and_ ignore
the -EPROBE_DEFER. Is that really what you want to do?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2021-10-24 20:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 16:48 [PATCH] mailbox: remove the error message when gce clk is defer jason-jh.lin
2021-10-23 16:48 ` jason-jh.lin
2021-10-23 16:48 ` jason-jh.lin
2021-10-24 20:25 ` Russell King (Oracle) [this message]
2021-10-24 20:25   ` Russell King (Oracle)
2021-10-24 20:25   ` Russell King (Oracle)
2021-10-25  3:08   ` Jason-JH Lin
2021-10-25  3:08     ` Jason-JH Lin
2021-10-25  3:08     ` Jason-JH Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXXBVTEbjPiBm1un@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fshao@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nancy.lin@mediatek.com \
    --cc=p.zabel@pengutronix.de \
    --cc=singo.chang@mediatek.com \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.