From: Greg KH <gregkh@linuxfoundation.org>
To: Abhyuday Godhasara <agodhasa@xilinx.com>
Cc: Michal Simek <michals@xilinx.com>, Rajan Vaja <RAJANV@xilinx.com>,
Manish Narani <MNARANI@xilinx.com>,
"zou_wei@huawei.com" <zou_wei@huawei.com>,
Sai Krishna Potthuri <lakshmis@xilinx.com>,
Jiaying Liang <jliang@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Tejas Patel <TEJASP@xilinx.com>
Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp firmware
Date: Mon, 25 Oct 2021 14:03:26 +0200 [thread overview]
Message-ID: <YXadDpOHWs2kUA6J@kroah.com> (raw)
In-Reply-To: <SA1PR02MB8592145E6C1A9A1FA561FA33A1839@SA1PR02MB8592.namprd02.prod.outlook.com>
On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote:
> Hi Greg,
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Monday, October 25, 2021 2:05 PM
> > To: Abhyuday Godhasara <agodhasa@xilinx.com>
> > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>;
> > Manish Narani <MNARANI@xilinx.com>; zou_wei@huawei.com; Sai Krishna
> > Potthuri <lakshmis@xilinx.com>; Jiaying Liang <jliang@xilinx.com>; Jiaying Liang
> > <jliang@xilinx.com>; linux-kernel@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; Tejas Patel <TEJASP@xilinx.com>
> > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp
> > firmware
> >
> > On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote:
> > > In zynqmp-firmware, register notifier is not supported, add support of
> > > register notifier in zynqmp-firmware.
> > >
> > > Signed-off-by: Tejas Patel <tejas.patel@xilinx.com>
> > > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
> > > Acked-by: Michal Simek <michal.simek@xilinx.com>
> > > ---
> > > Changes in v6:
> > > - Minor fix
> >
> >
> > That is vague, what got "fixed" here?
> [Abhyuday] During rebase of patches on your tree couple of lines code was get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git am -3".
> I corrected the below code which was wrong in previous patch v5.
> +static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> + const u32 wake, const u32 enable) {
> + return -ENODEV;
> +}
>
> In v5 it was like below, which is wrong
> static inline int zynqmp_pm_load_pdi(const u32 src, const u64 address)
> static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> const u32 wake, const u32 enable) {
> return -ENODEV;
> }
> So, the body was missing here for zynqmp_pm_load_pdi in v5.
And why did you not describe this in the changelog text? That is what I
was asking about here. Please be specific, as reviewers need to know
this type of thing.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Abhyuday Godhasara <agodhasa@xilinx.com>
Cc: Michal Simek <michals@xilinx.com>, Rajan Vaja <RAJANV@xilinx.com>,
Manish Narani <MNARANI@xilinx.com>,
"zou_wei@huawei.com" <zou_wei@huawei.com>,
Sai Krishna Potthuri <lakshmis@xilinx.com>,
Jiaying Liang <jliang@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Tejas Patel <TEJASP@xilinx.com>
Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp firmware
Date: Mon, 25 Oct 2021 14:03:26 +0200 [thread overview]
Message-ID: <YXadDpOHWs2kUA6J@kroah.com> (raw)
In-Reply-To: <SA1PR02MB8592145E6C1A9A1FA561FA33A1839@SA1PR02MB8592.namprd02.prod.outlook.com>
On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote:
> Hi Greg,
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Monday, October 25, 2021 2:05 PM
> > To: Abhyuday Godhasara <agodhasa@xilinx.com>
> > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>;
> > Manish Narani <MNARANI@xilinx.com>; zou_wei@huawei.com; Sai Krishna
> > Potthuri <lakshmis@xilinx.com>; Jiaying Liang <jliang@xilinx.com>; Jiaying Liang
> > <jliang@xilinx.com>; linux-kernel@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; Tejas Patel <TEJASP@xilinx.com>
> > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp
> > firmware
> >
> > On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote:
> > > In zynqmp-firmware, register notifier is not supported, add support of
> > > register notifier in zynqmp-firmware.
> > >
> > > Signed-off-by: Tejas Patel <tejas.patel@xilinx.com>
> > > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
> > > Acked-by: Michal Simek <michal.simek@xilinx.com>
> > > ---
> > > Changes in v6:
> > > - Minor fix
> >
> >
> > That is vague, what got "fixed" here?
> [Abhyuday] During rebase of patches on your tree couple of lines code was get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git am -3".
> I corrected the below code which was wrong in previous patch v5.
> +static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> + const u32 wake, const u32 enable) {
> + return -ENODEV;
> +}
>
> In v5 it was like below, which is wrong
> static inline int zynqmp_pm_load_pdi(const u32 src, const u64 address)
> static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> const u32 wake, const u32 enable) {
> return -ENODEV;
> }
> So, the body was missing here for zynqmp_pm_load_pdi in v5.
And why did you not describe this in the changelog text? That is what I
was asking about here. Please be specific, as reviewers need to know
this type of thing.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-25 12:04 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210702105144.28457-1-abhyuday.godhasara@xilinx.com>
2021-08-25 7:23 ` [PATCH v3 0/6] Add Xilinx Event Management Driver Michal Simek
2021-08-25 7:23 ` Michal Simek
[not found] ` <20210915131615.16506-1-abhyuday.godhasara@xilinx.com>
2021-10-13 12:27 ` [PATCH v4 " Abhyuday Godhasara
2021-10-13 12:27 ` Abhyuday Godhasara
2021-10-13 12:59 ` gregkh
2021-10-13 12:59 ` gregkh
2021-10-13 13:05 ` gregkh
2021-10-13 13:05 ` gregkh
2021-10-13 13:57 ` Abhyuday Godhasara
2021-10-13 13:57 ` Abhyuday Godhasara
2021-10-13 14:10 ` gregkh
2021-10-13 14:10 ` gregkh
2021-10-13 14:21 ` Abhyuday Godhasara
2021-10-13 14:21 ` Abhyuday Godhasara
2021-10-13 14:26 ` Abhyuday Godhasara
2021-10-13 14:26 ` Abhyuday Godhasara
2021-10-13 14:29 ` gregkh
2021-10-13 14:29 ` gregkh
2021-10-13 15:30 ` Michal Simek
2021-10-13 15:30 ` Michal Simek
2021-10-21 13:55 ` Abhyuday Godhasara
2021-10-21 13:55 ` Abhyuday Godhasara
2021-10-21 14:12 ` gregkh
2021-10-21 14:12 ` gregkh
2021-10-21 14:18 ` Abhyuday Godhasara
2021-10-21 14:18 ` Abhyuday Godhasara
2021-10-21 14:26 ` gregkh
2021-10-21 14:26 ` gregkh
2021-10-21 13:46 ` [PATCH v5 " Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
2021-10-21 13:59 ` Greg KH
2021-10-21 13:59 ` Greg KH
2021-10-25 8:23 ` [PATCH v6 " Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 " Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-11-16 4:43 ` Abhyuday Godhasara
2021-11-16 4:43 ` Abhyuday Godhasara
2021-11-17 15:13 ` gregkh
2021-11-17 15:13 ` gregkh
2021-11-29 7:02 ` [PATCH v8 0/3] " Abhyuday Godhasara
2021-11-29 7:02 ` Abhyuday Godhasara
2021-11-29 7:02 ` [PATCH v8 1/3] drivers: soc: xilinx: add xilinx event management driver Abhyuday Godhasara
2021-11-29 7:02 ` Abhyuday Godhasara
2021-11-29 7:02 ` [PATCH v8 2/3] firmware: xilinx: instantiate xilinx event manager driver Abhyuday Godhasara
2021-11-29 7:02 ` Abhyuday Godhasara
2021-11-29 7:02 ` [PATCH v8 3/3] driver: soc: xilinx: register for power events in zynqmp power driver Abhyuday Godhasara
2021-11-29 7:02 ` Abhyuday Godhasara
2021-11-30 9:50 ` [PATCH v7 0/6] Add Xilinx Event Management Driver Abhyuday Godhasara
2021-11-30 9:50 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 1/6] firmware: xilinx: add register notifier in zynqmp firmware Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 2/6] firmware: xilinx: add macros of node ids for error event Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 3/6] firmware: xilinx: export the feature check of zynqmp firmware Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 4/6] drivers: soc: xilinx: add xilinx event management driver Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 5/6] firmware: xilinx: instantiate xilinx event manager driver Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-10-26 4:25 ` [PATCH v7 6/6] driver: soc: xilinx: register for power events in zynqmp power driver Abhyuday Godhasara
2021-10-26 4:25 ` Abhyuday Godhasara
2021-10-25 8:23 ` [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp firmware Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-25 8:34 ` Greg KH
2021-10-25 8:34 ` Greg KH
2021-10-25 11:53 ` Abhyuday Godhasara
2021-10-25 11:53 ` Abhyuday Godhasara
2021-10-25 12:03 ` Greg KH [this message]
2021-10-25 12:03 ` Greg KH
2021-10-25 12:11 ` Abhyuday Godhasara
2021-10-25 12:11 ` Abhyuday Godhasara
2021-10-26 7:19 ` Abhyuday Godhasara
2021-10-26 7:19 ` Abhyuday Godhasara
2021-10-25 8:23 ` [PATCH v6 2/6] firmware: xilinx: add macros of node ids for error event Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-25 8:23 ` [PATCH v6 3/6] firmware: xilinx: export the feature check of zynqmp firmware Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-25 8:23 ` [PATCH v6 4/6] drivers: soc: xilinx: add xilinx event management driver Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-25 8:23 ` [PATCH v6 5/6] firmware: xilinx: instantiate xilinx event manager driver Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-25 8:23 ` [PATCH v6 6/6] driver: soc: xilinx: register for power events in zynqmp power driver Abhyuday Godhasara
2021-10-25 8:23 ` Abhyuday Godhasara
2021-10-21 13:46 ` [PATCH v5 1/6] firmware: xilinx: add register notifier in zynqmp firmware Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
2021-10-21 13:46 ` [PATCH v5 2/6] firmware: xilinx: add macros of node ids for error event Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
2021-10-21 13:46 ` [PATCH v5 3/6] firmware: xilinx: export the feature check of zynqmp firmware Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
2021-10-21 13:46 ` [PATCH v5 4/6] drivers: soc: xilinx: add xilinx event management driver Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
2021-10-21 13:46 ` [PATCH v5 5/6] firmware: xilinx: instantiate xilinx event manager driver Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
2021-10-21 13:46 ` [PATCH v5 6/6] driver: soc: xilinx: register for power events in zynqmp power driver Abhyuday Godhasara
2021-10-21 13:46 ` Abhyuday Godhasara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXadDpOHWs2kUA6J@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=MNARANI@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=TEJASP@xilinx.com \
--cc=agodhasa@xilinx.com \
--cc=jliang@xilinx.com \
--cc=lakshmis@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.