From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Johan Hovold <johan@kernel.org>,
cocci@inria.fr,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [cocci] [PATCH 1/2] staging: rtl8192u: fix control-message timeouts
Date: Mon, 25 Oct 2021 17:51:25 +0200 [thread overview]
Message-ID: <YXbSfYIuyj3PI6pm@kroah.com> (raw)
In-Reply-To: <094a8f50ccef81e0317c89d0a605c327c825d5cb.camel@perches.com>
On Mon, Oct 25, 2021 at 08:41:36AM -0700, Joe Perches wrote:
> On Mon, 2021-10-25 at 10:06 -0500, Larry Finger wrote:
> > On 10/25/21 07:09, Johan Hovold wrote:
> > > USB control-message timeouts are specified in milliseconds and should
> > > specifically not vary with CONFIG_HZ.
>
> There appears to be more than a few of these in the kernel.
>
> $ cat usb_hz.cocci
> @@
> expression e;
> @@
> * usb_control_msg(..., HZ * e)
>
> @@
> expression e;
> @@
> * usb_control_msg(..., HZ / e)
>
> @@
> @@
> * usb_control_msg(..., HZ)
>
> $ spatch --very-quiet -U 0 -sp-file usb_hz.cocci .
> warning: line 4: should HZ be a metavariable?
> warning: line 9: should HZ be a metavariable?
> warning: line 13: should HZ be a metavariable?
> 50 files match
Look at the lists, he's sent a bunch of fixes for this today to all the
subsystems...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Johan Hovold <johan@kernel.org>,
cocci@inria.fr,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8192u: fix control-message timeouts
Date: Mon, 25 Oct 2021 17:51:25 +0200 [thread overview]
Message-ID: <YXbSfYIuyj3PI6pm@kroah.com> (raw)
In-Reply-To: <094a8f50ccef81e0317c89d0a605c327c825d5cb.camel@perches.com>
On Mon, Oct 25, 2021 at 08:41:36AM -0700, Joe Perches wrote:
> On Mon, 2021-10-25 at 10:06 -0500, Larry Finger wrote:
> > On 10/25/21 07:09, Johan Hovold wrote:
> > > USB control-message timeouts are specified in milliseconds and should
> > > specifically not vary with CONFIG_HZ.
>
> There appears to be more than a few of these in the kernel.
>
> $ cat usb_hz.cocci
> @@
> expression e;
> @@
> * usb_control_msg(..., HZ * e)
>
> @@
> expression e;
> @@
> * usb_control_msg(..., HZ / e)
>
> @@
> @@
> * usb_control_msg(..., HZ)
>
> $ spatch --very-quiet -U 0 -sp-file usb_hz.cocci .
> warning: line 4: should HZ be a metavariable?
> warning: line 9: should HZ be a metavariable?
> warning: line 13: should HZ be a metavariable?
> 50 files match
Look at the lists, he's sent a bunch of fixes for this today to all the
subsystems...
greg k-h
next prev parent reply other threads:[~2021-10-25 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:09 [PATCH 0/2] staging: fix control-message timeouts Johan Hovold
2021-10-25 12:09 ` [PATCH 1/2] staging: rtl8192u: " Johan Hovold
2021-10-25 15:06 ` Larry Finger
2021-10-25 15:41 ` [cocci] " Joe Perches
2021-10-25 15:41 ` Joe Perches
2021-10-25 15:51 ` Greg Kroah-Hartman [this message]
2021-10-25 15:51 ` Greg Kroah-Hartman
2021-10-25 16:20 ` [cocci] " Joe Perches
2021-10-25 16:20 ` Joe Perches
2021-10-25 12:09 ` [PATCH 2/2] staging: r8712u: fix control-message timeout Johan Hovold
2021-10-25 15:08 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXbSfYIuyj3PI6pm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=cocci@inria.fr \
--cc=florian.c.schilhabel@googlemail.com \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.