All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: quanyang.wang@windriver.com, Thomas Gleixner <tglx@linutronix.de>,
	Ard Biesheuvel <ardb@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds
Date: Tue, 26 Oct 2021 09:59:34 +0100	[thread overview]
Message-ID: <YXfDdmrCynZk/QW8@shell.armlinux.org.uk> (raw)
In-Reply-To: <CACRpkdYxMDp4FRGP=EOt8oTMxs_YuskbvMx5wXBDjUWz6hD=gQ@mail.gmail.com>

On Sun, Oct 24, 2021 at 11:44:31PM +0200, Linus Walleij wrote:
> On Wed, Oct 20, 2021 at 7:50 AM <quanyang.wang@windriver.com> wrote:
> 
> > From: Quanyang Wang <quanyang.wang@windriver.com>
> >
> > Not only the early fixmap range, but also the fixmap range should be
> > checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM,
> > some systems which contain up to 16 CPUs will crash.
> >
> > Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> 
> Looks reasonable to me.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Please submit this patch into Russell's patch tracker.

... and has totally broken what looks like _all_ ARM kernel builds. It
can not have been tested. Maybe it's uncovered a previously unknown
problem, but causing such a wide-range regression is disappointing.
I'm going to revert this commit.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: quanyang.wang@windriver.com, Thomas Gleixner <tglx@linutronix.de>,
	Ard Biesheuvel <ardb@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds
Date: Tue, 26 Oct 2021 09:59:34 +0100	[thread overview]
Message-ID: <YXfDdmrCynZk/QW8@shell.armlinux.org.uk> (raw)
In-Reply-To: <CACRpkdYxMDp4FRGP=EOt8oTMxs_YuskbvMx5wXBDjUWz6hD=gQ@mail.gmail.com>

On Sun, Oct 24, 2021 at 11:44:31PM +0200, Linus Walleij wrote:
> On Wed, Oct 20, 2021 at 7:50 AM <quanyang.wang@windriver.com> wrote:
> 
> > From: Quanyang Wang <quanyang.wang@windriver.com>
> >
> > Not only the early fixmap range, but also the fixmap range should be
> > checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM,
> > some systems which contain up to 16 CPUs will crash.
> >
> > Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> 
> Looks reasonable to me.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Please submit this patch into Russell's patch tracker.

... and has totally broken what looks like _all_ ARM kernel builds. It
can not have been tested. Maybe it's uncovered a previously unknown
problem, but causing such a wide-range regression is disappointing.
I'm going to revert this commit.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  parent reply	other threads:[~2021-10-26  9:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  5:49 [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds quanyang.wang
2021-10-20  5:49 ` quanyang.wang
2021-10-24 21:44 ` Linus Walleij
2021-10-24 21:44   ` Linus Walleij
2021-10-25  6:38   ` Quanyang Wang
2021-10-25  6:38     ` Quanyang Wang
2021-10-26  8:59   ` Russell King (Oracle) [this message]
2021-10-26  8:59     ` Russell King (Oracle)
2021-10-26  9:53     ` Quanyang Wang
2021-10-26  9:53       ` Quanyang Wang
2021-10-26 10:12       ` Ard Biesheuvel
2021-10-26 10:12         ` Ard Biesheuvel
2021-10-26 10:38         ` Quanyang Wang
2021-10-26 10:38           ` Quanyang Wang
2021-10-26 10:54           ` Russell King (Oracle)
2021-10-26 10:54             ` Russell King (Oracle)
2021-10-26 10:56             ` Ard Biesheuvel
2021-10-26 10:56               ` Ard Biesheuvel
2021-10-26 11:15               ` Russell King (Oracle)
2021-10-26 11:15                 ` Russell King (Oracle)
2021-10-26 11:26                 ` Ard Biesheuvel
2021-10-26 11:26                   ` Ard Biesheuvel
2021-10-26 11:29                   ` Russell King (Oracle)
2021-10-26 11:29                     ` Russell King (Oracle)
2021-10-31 18:12 ` kernel test robot
2021-10-31 18:12   ` kernel test robot
2021-10-31 18:12   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXfDdmrCynZk/QW8@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=ardb@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quanyang.wang@windriver.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.