Re: [PATCH dwarves v2 0/2] btf: support typedef DW_TAG_LLVM_annotation

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Nov 09, 2021 at 09:23:30PM -0800, Yonghong Song escreveu:
> 
> 
> On 11/2/21 5:11 PM, Andrii Nakryiko wrote:
> > On Tue, Nov 2, 2021 at 4:35 PM Yonghong Song <yhs@fb.com> wrote:
> > > 
> > > Latest llvm is able to generate DW_TAG_LLVM_annotation for typedef
> > > declarations. Latest bpf-next supports BTF_KIND_DECL_TAG for
> > > typedef declarations. This patch implemented dwarf DW_TAG_LLVM_annotation
> > > to btf BTF_KIND_DECL_TAG conversion. Patch 1 is for dwarf_loader
> > > to process DW_TAG_LLVM_annotation tags. Patch 2 is for the
> > > dwarf->btf conversion.
> > > 
> > > Changelog:
> > >    v1 -> v2:
> > >     - change some "if" statements to "switch" statement.
> > > 
> > 
> > LGTM.
> > 
> > Acked-by: Andrii Nakryiko <andrii@kernel.org>
> 
> Arnaldo, did you get chance to look at this patch set?

Yeah, I've merged and put it in the tmp.master branch so that libbpf's
CI can have a go on it.

I'm also updating my clang/llvm build to test it.

Thanks,

- Arnaldo
 
> > 
> > > Yonghong Song (2):
> > >    dwarf_loader: support typedef DW_TAG_LLVM_annotation
> > >    btf_encoder: generate BTF_KIND_DECL_TAGs for typedef btf_decl_tag
> > >      attributes
> > > 
> > >   btf_encoder.c  | 17 ++++++++++++++---
> > >   dwarf_loader.c |  7 ++-----
> > >   2 files changed, 16 insertions(+), 8 deletions(-)
> > > 
> > > --
> > > 2.30.2
> > > 

-- 

- Arnaldo