From: Tzung-Bi Shih <tzungbi@google.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
mchehab@kernel.org, matthias.bgg@gmail.com,
acourbot@chromium.org, yunfei.dong@mediatek.com,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: mtk-vcodec: Fix an error handling path in 'asid_allocator_init()'
Date: Fri, 12 Nov 2021 09:34:13 +0800 [thread overview]
Message-ID: <YY3ElQfeZr4DpObV@google.com> (raw)
In-Reply-To: <86d3e2db237bc35eb55bd46ef07fa13a39bcdff8.1636636541.git.christophe.jaillet@wanadoo.fr>
On Thu, Nov 11, 2021 at 02:17:51PM +0100, Christophe JAILLET wrote:
> In case of error the 'media_device_init()' call is not balanced by a
> corresponding 'media_device_cleanup()' call.
>
> Add it, when needed, as already done in the remove function.
>
> Fixes: 118add98f80e ("media: mtk-vcodec: vdec: add media device if using stateless api")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
The commit title looks incorrect: "asid_allocator_init".
Except that,
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
mchehab@kernel.org, matthias.bgg@gmail.com,
acourbot@chromium.org, yunfei.dong@mediatek.com,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: mtk-vcodec: Fix an error handling path in 'asid_allocator_init()'
Date: Fri, 12 Nov 2021 09:34:13 +0800 [thread overview]
Message-ID: <YY3ElQfeZr4DpObV@google.com> (raw)
In-Reply-To: <86d3e2db237bc35eb55bd46ef07fa13a39bcdff8.1636636541.git.christophe.jaillet@wanadoo.fr>
On Thu, Nov 11, 2021 at 02:17:51PM +0100, Christophe JAILLET wrote:
> In case of error the 'media_device_init()' call is not balanced by a
> corresponding 'media_device_cleanup()' call.
>
> Add it, when needed, as already done in the remove function.
>
> Fixes: 118add98f80e ("media: mtk-vcodec: vdec: add media device if using stateless api")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
The commit title looks incorrect: "asid_allocator_init".
Except that,
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
mchehab@kernel.org, matthias.bgg@gmail.com,
acourbot@chromium.org, yunfei.dong@mediatek.com,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: mtk-vcodec: Fix an error handling path in 'asid_allocator_init()'
Date: Fri, 12 Nov 2021 09:34:13 +0800 [thread overview]
Message-ID: <YY3ElQfeZr4DpObV@google.com> (raw)
In-Reply-To: <86d3e2db237bc35eb55bd46ef07fa13a39bcdff8.1636636541.git.christophe.jaillet@wanadoo.fr>
On Thu, Nov 11, 2021 at 02:17:51PM +0100, Christophe JAILLET wrote:
> In case of error the 'media_device_init()' call is not balanced by a
> corresponding 'media_device_cleanup()' call.
>
> Add it, when needed, as already done in the remove function.
>
> Fixes: 118add98f80e ("media: mtk-vcodec: vdec: add media device if using stateless api")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
The commit title looks incorrect: "asid_allocator_init".
Except that,
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-12 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 13:17 [PATCH] media: mtk-vcodec: Fix an error handling path in 'asid_allocator_init()' Christophe JAILLET
2021-11-11 13:17 ` Christophe JAILLET
2021-11-11 13:17 ` Christophe JAILLET
2021-11-12 1:34 ` Tzung-Bi Shih [this message]
2021-11-12 1:34 ` Tzung-Bi Shih
2021-11-12 1:34 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY3ElQfeZr4DpObV@google.com \
--to=tzungbi@google.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.