From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@resnulli.us,
mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com
Subject: Re: [PATCH net-next v2 3/4] devlink: expose get/put functions
Date: Mon, 1 Nov 2021 20:11:25 +0200 [thread overview]
Message-ID: <YYAtzVqgbkfjsx5E@unreal> (raw)
In-Reply-To: <20211101064440.57a587bf@kicinski-fedora-PC1C0HJN>
On Mon, Nov 01, 2021 at 06:44:40AM -0700, Jakub Kicinski wrote:
> On Sun, 31 Oct 2021 08:29:20 +0200 Leon Romanovsky wrote:
> > I really like this series, but your latest netdevsim RFC made me worry.
> >
> > It is important to make sure that these devlink_put() and devlink_get()
> > calls will be out-of-reach from the drivers. Only core code should use
> > them.
>
> get/put symbols are not exported so I think we should be safe
> from driver misuse at this point. If we ever export them we
> should add a
>
> WARN_ON(!(devlink->lock_flags & DEVLINK_LOCK_USE_REF));
Right, for now we are safe.
>
> > Can you please add it as a comment above these functions?
>
> Will do if the RFC sinks.
I have a solution at hand that doesn't require exporting get/put interfaces.
>
> > At least for now, till we discuss your RFC.
next prev parent reply other threads:[~2021-11-01 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 17:18 [PATCH net-next v2 0/4] improve ethtool/rtnl vs devlink locking Jakub Kicinski
2021-10-30 17:18 ` [PATCH net-next v2 1/4] ethtool: push the rtnl_lock into dev_ethtool() Jakub Kicinski
2021-10-31 6:19 ` Leon Romanovsky
2021-10-30 17:18 ` [PATCH net-next v2 2/4] ethtool: handle info/flash data copying outside rtnl_lock Jakub Kicinski
2021-10-31 6:24 ` Leon Romanovsky
2021-10-30 17:18 ` [PATCH net-next v2 3/4] devlink: expose get/put functions Jakub Kicinski
2021-10-31 6:29 ` Leon Romanovsky
2021-11-01 13:44 ` Jakub Kicinski
2021-11-01 18:11 ` Leon Romanovsky [this message]
2021-10-30 17:18 ` [PATCH net-next v2 4/4] ethtool: don't drop the rtnl_lock half way thru the ioctl Jakub Kicinski
2021-10-31 6:31 ` Leon Romanovsky
2021-11-01 13:30 ` [PATCH net-next v2 0/4] improve ethtool/rtnl vs devlink locking patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYAtzVqgbkfjsx5E@unreal \
--to=leon@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.