From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Emma Anholt" <emma@anholt.net>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"David Airlie" <airlied@linux.ie>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
amd-gfx@lists.freedesktop.org,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
intel-gfx@lists.freedesktop.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Dom Cobley" <dom@raspberrypi.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate
Date: Wed, 3 Nov 2021 13:02:11 +0200 [thread overview]
Message-ID: <YYJsM6/hZ43b1tm9@intel.com> (raw)
In-Reply-To: <20211102145944.259181-2-maxime@cerno.tech>
On Tue, Nov 02, 2021 at 03:59:32PM +0100, Maxime Ripard wrote:
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4966,7 +4966,7 @@ static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
> u32 max_tmds_clock = hf_vsdb[5] * 5000;
> struct drm_scdc *scdc = &hdmi->scdc;
>
> - if (max_tmds_clock > 340000) {
> + if (max_tmds_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> display->max_tmds_clock = max_tmds_clock;
> DRM_DEBUG_KMS("HF-VSDB: max TMDS clock %d kHz\n",
> display->max_tmds_clock);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index d2e61f6c6e08..0666203d52b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2226,7 +2226,7 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (scdc->scrambling.low_rates)
> pipe_config->hdmi_scrambling = true;
>
> - if (pipe_config->port_clock > 340000) {
> + if (pipe_config->port_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> pipe_config->hdmi_scrambling = true;
> pipe_config->hdmi_high_tmds_clock_ratio = true;
> }
All of that is HDMI 2.0 stuff. So this just makes it all super
confusing IMO. Nak.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Emma Anholt" <emma@anholt.net>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
amd-gfx@lists.freedesktop.org,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Dom Cobley" <dom@raspberrypi.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>
Subject: Re: [Intel-gfx] [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate
Date: Wed, 3 Nov 2021 13:02:11 +0200 [thread overview]
Message-ID: <YYJsM6/hZ43b1tm9@intel.com> (raw)
In-Reply-To: <20211102145944.259181-2-maxime@cerno.tech>
On Tue, Nov 02, 2021 at 03:59:32PM +0100, Maxime Ripard wrote:
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4966,7 +4966,7 @@ static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
> u32 max_tmds_clock = hf_vsdb[5] * 5000;
> struct drm_scdc *scdc = &hdmi->scdc;
>
> - if (max_tmds_clock > 340000) {
> + if (max_tmds_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> display->max_tmds_clock = max_tmds_clock;
> DRM_DEBUG_KMS("HF-VSDB: max TMDS clock %d kHz\n",
> display->max_tmds_clock);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index d2e61f6c6e08..0666203d52b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2226,7 +2226,7 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (scdc->scrambling.low_rates)
> pipe_config->hdmi_scrambling = true;
>
> - if (pipe_config->port_clock > 340000) {
> + if (pipe_config->port_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> pipe_config->hdmi_scrambling = true;
> pipe_config->hdmi_high_tmds_clock_ratio = true;
> }
All of that is HDMI 2.0 stuff. So this just makes it all super
confusing IMO. Nak.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dom Cobley" <dom@raspberrypi.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Emma Anholt" <emma@anholt.net>,
intel-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Thierry Reding" <thierry.reding@gmail.com>
Subject: Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate
Date: Wed, 3 Nov 2021 13:02:11 +0200 [thread overview]
Message-ID: <YYJsM6/hZ43b1tm9@intel.com> (raw)
In-Reply-To: <20211102145944.259181-2-maxime@cerno.tech>
On Tue, Nov 02, 2021 at 03:59:32PM +0100, Maxime Ripard wrote:
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4966,7 +4966,7 @@ static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
> u32 max_tmds_clock = hf_vsdb[5] * 5000;
> struct drm_scdc *scdc = &hdmi->scdc;
>
> - if (max_tmds_clock > 340000) {
> + if (max_tmds_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> display->max_tmds_clock = max_tmds_clock;
> DRM_DEBUG_KMS("HF-VSDB: max TMDS clock %d kHz\n",
> display->max_tmds_clock);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index d2e61f6c6e08..0666203d52b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2226,7 +2226,7 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (scdc->scrambling.low_rates)
> pipe_config->hdmi_scrambling = true;
>
> - if (pipe_config->port_clock > 340000) {
> + if (pipe_config->port_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> pipe_config->hdmi_scrambling = true;
> pipe_config->hdmi_high_tmds_clock_ratio = true;
> }
All of that is HDMI 2.0 stuff. So this just makes it all super
confusing IMO. Nak.
--
Ville Syrjälä
Intel
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dom Cobley" <dom@raspberrypi.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Emma Anholt" <emma@anholt.net>,
intel-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Thierry Reding" <thierry.reding@gmail.com>
Subject: Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate
Date: Wed, 3 Nov 2021 13:02:11 +0200 [thread overview]
Message-ID: <YYJsM6/hZ43b1tm9@intel.com> (raw)
In-Reply-To: <20211102145944.259181-2-maxime@cerno.tech>
On Tue, Nov 02, 2021 at 03:59:32PM +0100, Maxime Ripard wrote:
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4966,7 +4966,7 @@ static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
> u32 max_tmds_clock = hf_vsdb[5] * 5000;
> struct drm_scdc *scdc = &hdmi->scdc;
>
> - if (max_tmds_clock > 340000) {
> + if (max_tmds_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> display->max_tmds_clock = max_tmds_clock;
> DRM_DEBUG_KMS("HF-VSDB: max TMDS clock %d kHz\n",
> display->max_tmds_clock);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index d2e61f6c6e08..0666203d52b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2226,7 +2226,7 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (scdc->scrambling.low_rates)
> pipe_config->hdmi_scrambling = true;
>
> - if (pipe_config->port_clock > 340000) {
> + if (pipe_config->port_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> pipe_config->hdmi_scrambling = true;
> pipe_config->hdmi_high_tmds_clock_ratio = true;
> }
All of that is HDMI 2.0 stuff. So this just makes it all super
confusing IMO. Nak.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dom Cobley" <dom@raspberrypi.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Emma Anholt" <emma@anholt.net>,
intel-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Thierry Reding" <thierry.reding@gmail.com>
Subject: Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate
Date: Wed, 3 Nov 2021 13:02:11 +0200 [thread overview]
Message-ID: <YYJsM6/hZ43b1tm9@intel.com> (raw)
In-Reply-To: <20211102145944.259181-2-maxime@cerno.tech>
On Tue, Nov 02, 2021 at 03:59:32PM +0100, Maxime Ripard wrote:
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4966,7 +4966,7 @@ static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
> u32 max_tmds_clock = hf_vsdb[5] * 5000;
> struct drm_scdc *scdc = &hdmi->scdc;
>
> - if (max_tmds_clock > 340000) {
> + if (max_tmds_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> display->max_tmds_clock = max_tmds_clock;
> DRM_DEBUG_KMS("HF-VSDB: max TMDS clock %d kHz\n",
> display->max_tmds_clock);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index d2e61f6c6e08..0666203d52b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2226,7 +2226,7 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (scdc->scrambling.low_rates)
> pipe_config->hdmi_scrambling = true;
>
> - if (pipe_config->port_clock > 340000) {
> + if (pipe_config->port_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> pipe_config->hdmi_scrambling = true;
> pipe_config->hdmi_high_tmds_clock_ratio = true;
> }
All of that is HDMI 2.0 stuff. So this just makes it all super
confusing IMO. Nak.
--
Ville Syrjälä
Intel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Emma Anholt" <emma@anholt.net>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
amd-gfx@lists.freedesktop.org,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
intel-gfx@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Dom Cobley" <dom@raspberrypi.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate
Date: Wed, 3 Nov 2021 13:02:11 +0200 [thread overview]
Message-ID: <YYJsM6/hZ43b1tm9@intel.com> (raw)
In-Reply-To: <20211102145944.259181-2-maxime@cerno.tech>
On Tue, Nov 02, 2021 at 03:59:32PM +0100, Maxime Ripard wrote:
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4966,7 +4966,7 @@ static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
> u32 max_tmds_clock = hf_vsdb[5] * 5000;
> struct drm_scdc *scdc = &hdmi->scdc;
>
> - if (max_tmds_clock > 340000) {
> + if (max_tmds_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> display->max_tmds_clock = max_tmds_clock;
> DRM_DEBUG_KMS("HF-VSDB: max TMDS clock %d kHz\n",
> display->max_tmds_clock);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index d2e61f6c6e08..0666203d52b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2226,7 +2226,7 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (scdc->scrambling.low_rates)
> pipe_config->hdmi_scrambling = true;
>
> - if (pipe_config->port_clock > 340000) {
> + if (pipe_config->port_clock > DRM_HDMI_14_MAX_TMDS_CLK_KHZ) {
> pipe_config->hdmi_scrambling = true;
> pipe_config->hdmi_high_tmds_clock_ratio = true;
> }
All of that is HDMI 2.0 stuff. So this just makes it all super
confusing IMO. Nak.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-11-03 11:02 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 14:59 [PATCH 00/13] drm: Add generic helpers for HDMI scrambling Maxime Ripard
2021-11-02 14:59 ` [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate Maxime Ripard
2021-11-02 14:59 ` Maxime Ripard
2021-11-02 14:59 ` Maxime Ripard
2021-11-02 14:59 ` Maxime Ripard
2021-11-02 14:59 ` Maxime Ripard
2021-11-02 14:59 ` [Intel-gfx] " Maxime Ripard
2021-11-02 17:50 ` Alex Deucher
2021-11-02 17:50 ` Alex Deucher
2021-11-02 17:50 ` Alex Deucher
2021-11-02 17:50 ` Alex Deucher
2021-11-02 17:50 ` Alex Deucher
2021-11-02 17:50 ` [Intel-gfx] " Alex Deucher
2021-11-03 9:08 ` Neil Armstrong
2021-11-03 9:08 ` Neil Armstrong
2021-11-03 9:08 ` Neil Armstrong
2021-11-03 9:08 ` Neil Armstrong
2021-11-03 9:08 ` Neil Armstrong
2021-11-03 9:08 ` [Intel-gfx] " Neil Armstrong
2021-11-03 11:02 ` Ville Syrjälä [this message]
2021-11-03 11:02 ` Ville Syrjälä
2021-11-03 11:02 ` Ville Syrjälä
2021-11-03 11:02 ` Ville Syrjälä
2021-11-03 11:02 ` Ville Syrjälä
2021-11-03 11:02 ` [Intel-gfx] " Ville Syrjälä
2021-11-03 18:05 ` Ville Syrjälä
2021-11-03 18:05 ` Ville Syrjälä
2021-11-03 18:05 ` Ville Syrjälä
2021-11-03 18:05 ` Ville Syrjälä
2021-11-03 18:05 ` [Intel-gfx] " Ville Syrjälä
2021-11-04 8:48 ` Maxime Ripard
2021-11-04 8:48 ` Maxime Ripard
2021-11-04 8:48 ` Maxime Ripard
2021-11-04 8:48 ` Maxime Ripard
2021-11-04 8:48 ` [Intel-gfx] " Maxime Ripard
2021-11-04 15:41 ` Ville Syrjälä
2021-11-04 15:41 ` Ville Syrjälä
2021-11-04 15:41 ` Ville Syrjälä
2021-11-04 15:41 ` Ville Syrjälä
2021-11-04 15:41 ` [Intel-gfx] " Ville Syrjälä
2021-11-08 14:59 ` Maxime Ripard
2021-11-08 14:59 ` Maxime Ripard
2021-11-08 14:59 ` Maxime Ripard
2021-11-08 14:59 ` Maxime Ripard
2021-11-08 14:59 ` [Intel-gfx] " Maxime Ripard
2021-11-02 14:59 ` [PATCH 02/13] drm/connector: Add helper to check if a mode requires scrambling Maxime Ripard
2021-11-02 14:59 ` Maxime Ripard
2021-11-04 15:37 ` Ville Syrjälä
2021-11-04 15:37 ` Ville Syrjälä
2021-11-05 18:02 ` Daniel Vetter
2021-11-05 18:02 ` Daniel Vetter
2021-11-05 18:14 ` Ville Syrjälä
2021-11-05 18:14 ` Ville Syrjälä
2021-11-08 15:58 ` Maxime Ripard
2021-11-08 15:58 ` Maxime Ripard
2021-11-08 16:03 ` Daniel Vetter
2021-11-08 16:03 ` Daniel Vetter
2021-11-08 17:55 ` Ville Syrjälä
2021-11-08 17:55 ` Ville Syrjälä
2021-11-15 12:15 ` Maxime Ripard
2021-11-15 12:15 ` Maxime Ripard
2021-11-17 10:01 ` Maxime Ripard
2021-11-17 10:01 ` Maxime Ripard
2021-11-02 14:59 ` [PATCH 03/13] drm/atomic: Add HDMI scrambler state helper Maxime Ripard
2021-11-02 14:59 ` [PATCH 04/13] drm/atomic: Add HDMI reset link helper Maxime Ripard
2021-11-02 14:59 ` [PATCH 05/13] drm/scdc: Document hotplug gotchas Maxime Ripard
2021-11-02 14:59 ` [PATCH 06/13] drm/vc4: hdmi: Remove unused argument in vc4_hdmi_supports_scrambling Maxime Ripard
2021-11-02 14:59 ` [PATCH 07/13] drm/vc4: hdmi: Remove mutex in detect Maxime Ripard
2021-11-02 14:59 ` [PATCH 08/13] drm/vc4: hdmi: Remove HDMI flag from encoder Maxime Ripard
2021-11-02 14:59 ` [PATCH 09/13] drm/vc4: hdmi: Simplify the hotplug handling Maxime Ripard
2021-11-02 14:59 ` [PATCH 10/13] drm/vc4: hdmi: Simplify the connector state retrieval Maxime Ripard
2021-11-02 14:59 ` [PATCH 11/13] drm/vc4: hdmi: Switch to detect_ctx Maxime Ripard
2021-11-02 14:59 ` [PATCH 12/13] drm/vc4: hdmi: Leverage new SCDC atomic_check Maxime Ripard
2021-11-02 14:59 ` [PATCH 13/13] drm/vc4: hdmi: Reset link on hotplug Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYJsM6/hZ43b1tm9@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Xinhui.Pan@amd.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=benjamin.gaignard@linaro.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=phil@raspberrypi.com \
--cc=robert.foss@linaro.org \
--cc=rodrigo.vivi@intel.com \
--cc=thierry.reding@gmail.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.