Re: [PATCH 1/1] clk: imx8m: Do not set IMX_COMPOSITE_CORE for non-regular composites

From: Abel Vesa <abel.vesa@nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 1/1] clk: imx8m: Do not set IMX_COMPOSITE_CORE for non-regular composites
Date: Wed, 3 Nov 2021 22:45:50 +0200	[thread overview]
Message-ID: <YYL0/hpn83XI84LP@ryzen> (raw)
In-Reply-To: <20211103123947.3222443-1-alexander.stein@ew.tq-group.com>

On 21-11-03 13:39:47, Alexander Stein wrote:
> Only imx8m_clk_hw_composite_core needs to set this flag.
> 
> Fixes: a60fe746df94 ("clk: imx: Rework all imx_clk_hw_composite wrappers")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Looking at the commit a60fe746df94 it's obvious this change reverts the
flags as they were before.

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

Stephen, will you apply this on clk/next or should I send a subsequent
pull request ?

> ---
> This is from clk_summary on a imx8mq custom board where you can clearly
> see the before the divider is limited to 8 (core composite)
> 
> before:
> video_pll1_out        2        2        0  1031999997          0     0  50000         Y
>    dsi_phy_ref        1        1        0   129000000          0     0  50000         Y
>    lcdif_pixel        2        2        0   129000000          0     0  50000         Y
> 
> after:
> video_pll1_out        2        2        0  1031999997          0     0  50000         Y
>    dsi_phy_ref        1        1        0    24000000          0     0  50000         Y
>    lcdif_pixel        2        2        0    68800000          0     0  50000         Y
> 
>  drivers/clk/imx/clk.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
> index 819949973db1..7d220a01de1f 100644
> --- a/drivers/clk/imx/clk.h
> +++ b/drivers/clk/imx/clk.h
> @@ -391,11 +391,11 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name,
>  
>  #define imx8m_clk_hw_composite(name, parent_names, reg) \
>  	_imx8m_clk_hw_composite(name, parent_names, reg, \
> -			IMX_COMPOSITE_CORE, IMX_COMPOSITE_CLK_FLAGS_DEFAULT)
> +			0, IMX_COMPOSITE_CLK_FLAGS_DEFAULT)
>  
>  #define imx8m_clk_hw_composite_critical(name, parent_names, reg) \
>  	_imx8m_clk_hw_composite(name, parent_names, reg, \
> -			IMX_COMPOSITE_CORE, IMX_COMPOSITE_CLK_FLAGS_CRITICAL)
> +			0, IMX_COMPOSITE_CLK_FLAGS_CRITICAL)
>  
>  #define imx8m_clk_hw_composite_bus(name, parent_names, reg)	\
>  	_imx8m_clk_hw_composite(name, parent_names, reg, \
> -- 
> 2.25.1
>