[LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[Bogdan Lezhepekov via ltp]

---
 testcases/kernel/containers/netns/netns_netlink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c
index ddd8ce910..f9ae255f5 100644
--- a/testcases/kernel/containers/netns/netns_netlink.c
+++ b/testcases/kernel/containers/netns/netns_netlink.c
@@ -120,6 +120,7 @@ static struct tst_test test = {
 	.forks_child = 1,
 	.needs_kconfigs = (const char *[]) {
 		"CONFIG_NET_NS=y",
+		"CONFIG_TUN=y",
 		NULL
 	},
 };
-- 
2.33.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[Cyril Hrubis]

Hi!
>  testcases/kernel/containers/netns/netns_netlink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c
> index ddd8ce910..f9ae255f5 100644
> --- a/testcases/kernel/containers/netns/netns_netlink.c
> +++ b/testcases/kernel/containers/netns/netns_netlink.c
> @@ -120,6 +120,7 @@ static struct tst_test test = {
>  	.forks_child = 1,
>  	.needs_kconfigs = (const char *[]) {
>  		"CONFIG_NET_NS=y",
> +		"CONFIG_TUN=y",

Shouldn't that be just "CONFIG_TUN" as that would match both
"CONFIG_TUN=y" and "CONFIG_TUN=m"?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[Bogdan Lezhepekov via ltp]

[-- Attachment #1.1: Type: text/plain, Size: 1152 bytes --]

Hi Cyril,

I was missing that it's possible with the test API. Then of course it would be better.

Should I submit V2?

Thanks,
Bogdan

________________________________
From: Cyril Hrubis <chrubis@suse.cz>
Sent: Thursday, November 4, 2021 15:26
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: ltp@lists.linux.it <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

Hi!
>  testcases/kernel/containers/netns/netns_netlink.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c
> index ddd8ce910..f9ae255f5 100644
> --- a/testcases/kernel/containers/netns/netns_netlink.c
> +++ b/testcases/kernel/containers/netns/netns_netlink.c
> @@ -120,6 +120,7 @@ static struct tst_test test = {
>        .forks_child = 1,
>        .needs_kconfigs = (const char *[]) {
>                "CONFIG_NET_NS=y",
> +             "CONFIG_TUN=y",

Shouldn't that be just "CONFIG_TUN" as that would match both
"CONFIG_TUN=y" and "CONFIG_TUN=m"?

--
Cyril Hrubis
chrubis@suse.cz


[-- Attachment #1.2: Type: text/html, Size: 2983 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[Cyril Hrubis]

Hi!
> I was missing that it's possible with the test API. Then of course it would be better.

Actually the config parser implements full boolean expressions :-).

> Should I submit V2?

No need, I will remove the =y before applying.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[Cyril Hrubis]

Hi!
I've fixed the kconfig line and also added your Signed-off-by and
pushed, thanks.

Please make sure that you commit your patches with -s

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

[Bogdan Lezhepekov via ltp]

[-- Attachment #1.1: Type: text/plain, Size: 510 bytes --]

Hi,

Thanks a lot!

-Bogdan
________________________________
From: Cyril Hrubis <chrubis@suse.cz>
Sent: Thursday, November 4, 2021 16:10
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: ltp@lists.linux.it <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

Hi!
I've fixed the kconfig line and also added your Signed-off-by and
pushed, thanks.

Please make sure that you commit your patches with -s

--
Cyril Hrubis
chrubis@suse.cz


[-- Attachment #1.2: Type: text/html, Size: 1736 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp