All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	kbuild-all@lists.01.org, Andrzej Hajda <andrzej.hajda@intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	linux-rockchip@lists.infradead.org,
	"Kristian H . Kristensen" <hoegsberg@google.com>
Subject: Re: [PATCH 1/2] drm/input_helper: Add new input-handling helper
Date: Thu, 4 Nov 2021 14:45:18 -0700	[thread overview]
Message-ID: <YYRUbhWH1MlDvSsR@google.com> (raw)
In-Reply-To: <202111041849.GKXf3qid-lkp@intel.com>

On Thu, Nov 04, 2021 at 06:47:34PM +0800, kernel test robot wrote:
> Hi Brian,

Hi robot!

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

I'm not sure how to do that in a v2 patch -- one doesn't normally credit
"Reported-by" for every testing/review improvement on an in-development
patch series.

> All errors (new ones prefixed by >>):
> 
>    or1k-linux-ld: drivers/gpu/drm/drm_input_helper.o: in function `drm_input_disconnect':
> >> drm_input_helper.c:(.text+0x48): undefined reference to `input_close_device'

I've cooked a local change to separate the CONFIG_INPUT dependencies
under another Kconfig symbol which optionally builds this stuff into the
drm helper module, only when CONFIG_INPUT is present. That should fix
the build issues while still leaving DRM_KMS_HELPER workable with or
without CONFIG_INPUT.

I'll wait to see if there's any other feedback before spinning though.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	kbuild-all@lists.01.org, Andrzej Hajda <andrzej.hajda@intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	linux-rockchip@lists.infradead.org,
	"Kristian H . Kristensen" <hoegsberg@google.com>
Subject: Re: [PATCH 1/2] drm/input_helper: Add new input-handling helper
Date: Thu, 4 Nov 2021 14:45:18 -0700	[thread overview]
Message-ID: <YYRUbhWH1MlDvSsR@google.com> (raw)
In-Reply-To: <202111041849.GKXf3qid-lkp@intel.com>

On Thu, Nov 04, 2021 at 06:47:34PM +0800, kernel test robot wrote:
> Hi Brian,

Hi robot!

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

I'm not sure how to do that in a v2 patch -- one doesn't normally credit
"Reported-by" for every testing/review improvement on an in-development
patch series.

> All errors (new ones prefixed by >>):
> 
>    or1k-linux-ld: drivers/gpu/drm/drm_input_helper.o: in function `drm_input_disconnect':
> >> drm_input_helper.c:(.text+0x48): undefined reference to `input_close_device'

I've cooked a local change to separate the CONFIG_INPUT dependencies
under another Kconfig symbol which optionally builds this stuff into the
drm helper module, only when CONFIG_INPUT is present. That should fix
the build issues while still leaving DRM_KMS_HELPER workable with or
without CONFIG_INPUT.

I'll wait to see if there's any other feedback before spinning though.

Brian

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] drm/input_helper: Add new input-handling helper
Date: Thu, 04 Nov 2021 14:45:18 -0700	[thread overview]
Message-ID: <YYRUbhWH1MlDvSsR@google.com> (raw)
In-Reply-To: <202111041849.GKXf3qid-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Thu, Nov 04, 2021 at 06:47:34PM +0800, kernel test robot wrote:
> Hi Brian,

Hi robot!

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

I'm not sure how to do that in a v2 patch -- one doesn't normally credit
"Reported-by" for every testing/review improvement on an in-development
patch series.

> All errors (new ones prefixed by >>):
> 
>    or1k-linux-ld: drivers/gpu/drm/drm_input_helper.o: in function `drm_input_disconnect':
> >> drm_input_helper.c:(.text+0x48): undefined reference to `input_close_device'

I've cooked a local change to separate the CONFIG_INPUT dependencies
under another Kconfig symbol which optionally builds this stuff into the
drm helper module, only when CONFIG_INPUT is present. That should fix
the build issues while still leaving DRM_KMS_HELPER workable with or
without CONFIG_INPUT.

I'll wait to see if there's any other feedback before spinning though.

Brian

  reply	other threads:[~2021-11-04 21:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 23:40 [PATCH 0/2] drm: Support input-boosted panel self-refresh exit Brian Norris
2021-11-03 23:40 ` Brian Norris
2021-11-03 23:40 ` [PATCH 1/2] drm/input_helper: Add new input-handling helper Brian Norris
2021-11-03 23:40   ` Brian Norris
2021-11-04 10:47   ` kernel test robot
2021-11-04 10:47     ` kernel test robot
2021-11-04 10:47     ` kernel test robot
2021-11-04 21:45     ` Brian Norris [this message]
2021-11-04 21:45       ` Brian Norris
2021-11-04 21:45       ` Brian Norris
2021-11-04 13:20   ` kernel test robot
2021-11-04 13:20     ` kernel test robot
2021-11-04 13:20     ` kernel test robot
2021-11-04 13:46   ` kernel test robot
2021-11-04 13:46     ` kernel test robot
2021-11-04 13:46     ` kernel test robot
2021-11-05 23:11   ` Dmitry Torokhov
2021-11-05 23:11     ` Dmitry Torokhov
2021-11-13  0:52   ` Doug Anderson
2021-11-13  0:52     ` Doug Anderson
2021-11-17 18:38     ` Brian Norris
2021-11-17 18:38       ` Brian Norris
2021-11-17 20:47       ` Dmitry Torokhov
2021-11-17 20:47         ` Dmitry Torokhov
2021-11-17 20:56         ` Doug Anderson
2021-11-17 20:56           ` Doug Anderson
2021-11-17 22:27     ` Rob Clark
2021-11-17 22:27       ` Rob Clark
2021-11-03 23:40 ` [PATCH 2/2] drm/self_refresh: Disable self-refresh on input events Brian Norris
2021-11-03 23:40   ` Brian Norris
2021-11-13  0:52   ` Doug Anderson
2021-11-13  0:52     ` Doug Anderson
2021-11-17 18:24     ` Brian Norris
2021-11-17 18:24       ` Brian Norris
2021-11-17 19:12   ` Daniel Vetter
2021-11-17 19:12     ` Daniel Vetter
2021-11-17 19:36     ` Brian Norris
2021-11-17 19:36       ` Brian Norris
2021-11-18  6:39       ` Daniel Vetter
2021-11-18  6:39         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYRUbhWH1MlDvSsR@google.com \
    --to=briannorris@chromium.org \
    --cc=airlied@linux.ie \
    --cc=andrzej.hajda@intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hoegsberg@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.