From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.com>,
Ext4 <linux-ext4@vger.kernel.org>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 3/9] syscalls/fanotify21: Introduce FAN_FS_ERROR test
Date: Fri, 5 Nov 2021 09:59:06 +0100 [thread overview]
Message-ID: <YYTyWs4UPEL0eqjR@pevik> (raw)
In-Reply-To: <CAOQ4uxiwodQm_9+XVY-cWhV6aWKkqTosBfZ0HyAQTVNijJrwuQ@mail.gmail.com>
Hi all,
...
> > +static struct tst_test test = {
> > + .test = do_test,
> > + .tcnt = ARRAY_SIZE(testcases),
> > + .setup = setup,
> > + .cleanup = cleanup,
> > + .mount_device = 1,
> > + .mntpoint = MOUNT_PATH,
> > + .all_filesystems = 0,
> That's probably redundant and the default value anyway.
> If you want to stress out that this test cannot be run on other filesystems
> maybe add a comment why that is above dev_fs_type.
Yes, good catch. Thanks!
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.com>,
Ext4 <linux-ext4@vger.kernel.org>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 3/9] syscalls/fanotify21: Introduce FAN_FS_ERROR test
Date: Fri, 5 Nov 2021 09:59:06 +0100 [thread overview]
Message-ID: <YYTyWs4UPEL0eqjR@pevik> (raw)
In-Reply-To: <CAOQ4uxiwodQm_9+XVY-cWhV6aWKkqTosBfZ0HyAQTVNijJrwuQ@mail.gmail.com>
Hi all,
...
> > +static struct tst_test test = {
> > + .test = do_test,
> > + .tcnt = ARRAY_SIZE(testcases),
> > + .setup = setup,
> > + .cleanup = cleanup,
> > + .mount_device = 1,
> > + .mntpoint = MOUNT_PATH,
> > + .all_filesystems = 0,
> That's probably redundant and the default value anyway.
> If you want to stress out that this test cannot be run on other filesystems
> maybe add a comment why that is above dev_fs_type.
Yes, good catch. Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-05 8:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 21:17 [PATCH v3 0/9] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-29 21:17 ` [PATCH v3 1/9] syscalls: fanotify: Add macro to require specific mark types Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-11-02 11:27 ` Matthew Bobrowski
2021-11-02 11:27 ` [LTP] " Matthew Bobrowski via ltp
2021-11-02 12:13 ` Amir Goldstein
2021-11-02 12:13 ` [LTP] " Amir Goldstein
2021-11-03 16:13 ` Petr Vorel
2021-11-03 16:13 ` Petr Vorel
2021-10-29 21:17 ` [PATCH v3 2/9] syscalls: fanotify: Add macro to require specific events Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-30 6:11 ` Amir Goldstein
2021-10-30 6:11 ` [LTP] " Amir Goldstein
2021-11-02 11:58 ` Matthew Bobrowski
2021-11-02 11:58 ` [LTP] " Matthew Bobrowski via ltp
2021-11-02 12:11 ` Amir Goldstein
2021-11-02 12:11 ` [LTP] " Amir Goldstein
2021-10-29 21:17 ` [PATCH v3 3/9] syscalls/fanotify21: Introduce FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-30 6:15 ` Amir Goldstein
2021-10-30 6:15 ` [LTP] " Amir Goldstein
2021-11-05 8:59 ` Petr Vorel [this message]
2021-11-05 8:59 ` Petr Vorel
2021-10-29 21:17 ` [PATCH v3 4/9] syscalls/fanotify21: Validate the generic error info Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-29 21:17 ` [PATCH v3 5/9] syscalls/fanotify21: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-11-05 9:49 ` Petr Vorel
2021-11-05 9:49 ` Petr Vorel
2021-10-29 21:17 ` [PATCH v3 6/9] syscalls/fanotify21: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-29 21:17 ` [PATCH v3 7/9] syscalls/fanotify21: Create a corrupted file Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-29 21:17 ` [PATCH v3 8/9] syscalls/fanotify21: Test file event with broken inode Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-29 21:17 ` [PATCH v3 9/9] syscalls/fanotify21: Test capture of multiple errors Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] " Gabriel Krisman Bertazi
2021-10-30 6:21 ` [PATCH v3 0/9] Test the new fanotify FAN_FS_ERROR event Amir Goldstein
2021-10-30 6:21 ` [LTP] " Amir Goldstein
2021-11-05 10:10 ` Petr Vorel
2021-11-05 10:10 ` Petr Vorel
2021-11-05 13:02 ` Amir Goldstein
2021-11-05 13:02 ` Amir Goldstein
2021-11-05 13:10 ` Petr Vorel
2021-11-05 13:10 ` Petr Vorel
2021-11-15 21:26 ` Petr Vorel
2021-11-15 21:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYTyWs4UPEL0eqjR@pevik \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=repnop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.