All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Dave Gerlach <d-gerlach@ti.com>,
	soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Lee Jones <lee.jones@linaro.org>,
	Zhen Lei <thunder.leizhen@huawei.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: fix wkup_m3_rproc_boot_thread return type
Date: Mon, 8 Nov 2021 09:50:07 +0200	[thread overview]
Message-ID: <YYjWr6mALJvwJp0H@atomide.com> (raw)
In-Reply-To: <20211105075119.2327190-1-arnd@kernel.org>

* Arnd Bergmann <arnd@kernel.org> [211105 07:52]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The wkup_m3_rproc_boot_thread() function uses a nonstandard prototype,
> which broke after Eric's recent cleanup:
> 
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
>   429 |         return 0;
>       |                ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
>   416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Change it to the normal prototype as it should have been from the
> start.

Thanks

Acked-by: Tony Lindgren <tony@atomide.com>

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Dave Gerlach <d-gerlach@ti.com>,
	soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Lee Jones <lee.jones@linaro.org>,
	Zhen Lei <thunder.leizhen@huawei.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: fix wkup_m3_rproc_boot_thread return type
Date: Mon, 8 Nov 2021 09:50:07 +0200	[thread overview]
Message-ID: <YYjWr6mALJvwJp0H@atomide.com> (raw)
Message-ID: <20211108075007.lPrXjLtPDCOah9fI2hWfGaKboYUVTuUxwLnabM7vHwI@z> (raw)
In-Reply-To: <20211105075119.2327190-1-arnd@kernel.org>

* Arnd Bergmann <arnd@kernel.org> [211105 07:52]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The wkup_m3_rproc_boot_thread() function uses a nonstandard prototype,
> which broke after Eric's recent cleanup:
> 
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
>   429 |         return 0;
>       |                ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
>   416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Change it to the normal prototype as it should have been from the
> start.

Thanks

Acked-by: Tony Lindgren <tony@atomide.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-08  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  7:51 [PATCH] soc: ti: fix wkup_m3_rproc_boot_thread return type Arnd Bergmann
2021-11-05  7:51 ` Arnd Bergmann
2021-11-05 16:17 ` Santosh Shilimkar
2021-11-05 16:17   ` Santosh Shilimkar
2021-11-08  7:50 ` Tony Lindgren [this message]
2021-11-08  7:50   ` Tony Lindgren
2021-11-08 17:00 ` Eric W. Biederman
2021-11-08 17:00   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYjWr6mALJvwJp0H@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=d-gerlach@ti.com \
    --cc=ebiederm@xmission.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=soc@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.