All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 01/13] syscalls/quotactl01: Also test with vfsv1 format
Date: Mon, 8 Nov 2021 16:25:42 +0100	[thread overview]
Message-ID: <YYlBdhQEasTYSsSV@yuki> (raw)
In-Reply-To: <1635337569-4634-1-git-send-email-xuyang2018.jy@fujitsu.com>

Hi!
>  static void setup(void)
>  {
> -	const char *const cmd[] = {"quotacheck", "-ugF", "vfsv0", MNTPOINT, NULL};
> +	const char *const cmd[] = {"quotacheck", "-ugF", fmt_variants[tst_variant].fmt_name, MNTPOINT, NULL};

I would be inclined to store the variants pointer on a first line in the
setup so that the code gets slightly easier to read as:

	const struct quotactl_fmt_variant *var = &fmt_variants[tst_variant];

Then we can do var->fmt_name and var->fmt_id in the rest of the setup code...

Anyways the code looks good:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2021-11-08 15:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 12:25 [LTP] [PATCH v2 01/13] syscalls/quotactl01: Also test with vfsv1 format Yang Xu
2021-10-27 12:25 ` [LTP] [PATCH v2 02/13] syscalls/quotactl06: " Yang Xu
2021-11-08 15:29   ` Cyril Hrubis
2021-11-09  6:59     ` xuyang2018.jy
2021-10-27 12:25 ` [LTP] [PATCH v2 03/13] syscalls/quotactl04: Remove useless mount option Yang Xu
2021-11-08 15:40   ` Cyril Hrubis
2021-11-09  8:14     ` xuyang2018.jy
2021-10-27 12:26 ` [LTP] [PATCH v2 04/13] syscalls/quotactl:Add docparse formatting Yang Xu
2021-11-08 16:08   ` Cyril Hrubis
2021-10-27 12:26 ` [LTP] [PATCH v2 05/13] lapi/syscalls: Add syscall number for quotactl_fd Yang Xu
2021-11-08 16:09   ` Cyril Hrubis
2021-11-08  3:27 ` [LTP] [PATCH v2 01/13] syscalls/quotactl01: Also test with vfsv1 format xuyang2018.jy
2021-11-08 15:25 ` Cyril Hrubis [this message]
2021-11-09  5:13   ` xuyang2018.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYlBdhQEasTYSsSV@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.