All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/3] lib: adding .supported_archs field in tst_test structure
Date: Tue, 9 Nov 2021 17:11:50 +0100	[thread overview]
Message-ID: <YYqdxmnJi5je9DvV@yuki> (raw)
In-Reply-To: <20211109130910.1583233-1-liwang@redhat.com>

Hi!
> diff --git a/include/tst_arch.h b/include/tst_arch.h
> new file mode 100644
> index 000000000..e6d0a63d6
> --- /dev/null
> +++ b/include/tst_arch.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later
> + * Copyright (c) 2021 Li Wang <liwang@redhat.com>
> + */
> +
> +#ifndef TST_ARCH_H__
> +#define TST_ARCH_H__
> +
> +enum tst_arch_type {
> +	TST_UNKNOWN,
> +	TST_I386,

I would still probably name this TST_X86, Linux does not support i386
anymore, the remaining 32bit distributions usually require at least i586
or i686...

Anyways:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2021-11-09 16:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 13:09 [LTP] [PATCH v4 1/3] lib: adding .supported_archs field in tst_test structure Li Wang
2021-11-09 13:09 ` [LTP] [PATCH v4 2/3] testcase: make use of .supported_archs Li Wang
2021-11-09 16:23   ` Cyril Hrubis
2021-11-16 10:27     ` Richard Palethorpe
2021-11-09 13:09 ` [LTP] [PATCH v4 3/3] max_map_count: replace ifdefs by tst_arch Li Wang
2021-11-09 16:24   ` Cyril Hrubis
2021-11-09 16:11 ` Cyril Hrubis [this message]
2021-11-12  6:41   ` [LTP] [PATCH v4 1/3] lib: adding .supported_archs field in tst_test structure Li Wang
2021-11-16 10:30     ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYqdxmnJi5je9DvV@yuki \
    --to=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.