From: Andrew Lunn <andrew@lunn.ch>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: "Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>, "Pavel Machek" <pavel@ucw.cz>,
"John Crispin" <john@phrozen.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-leds@vger.kernel.org, "Marek Behún" <kabel@kernel.org>
Subject: Re: [RFC PATCH v3 4/8] leds: trigger: netdev: rename and expose NETDEV trigger enum modes
Date: Wed, 10 Nov 2021 23:29:20 +0100 [thread overview]
Message-ID: <YYxHwJLdNpDLPLd4@lunn.ch> (raw)
In-Reply-To: <YYwkJPQeej3/eRUl@Ansuel-xps.localdomain>
On Wed, Nov 10, 2021 at 08:57:24PM +0100, Ansuel Smith wrote:
> On Tue, Nov 09, 2021 at 09:58:27PM +0100, Andrew Lunn wrote:
> > On Tue, Nov 09, 2021 at 03:26:04AM +0100, Ansuel Smith wrote:
> > > Rename NETDEV trigger enum modes to a more simbolic name and move them
> >
> > symbolic. Randy is slipping :-)
> >
> > > in leds.h to make them accessible by any user.
> >
> > any user? I would be more specific than that. Other triggers dealing
> > with netdev states?
> >
>
> Ok will be more specific. A LED driver require to explicitly support the
> trigger to run in hardware mode. The LED driver will take the
> trigger_data and elaborate his struct to parse all the option
> (blink_mode bitmap, interval)
>
> So the user would be a LED driver that adds support for that specific
> trigger. That is also the reason we need to export them.
Say i have a SATA controller where i can configure it to blink on
reads, or writes, or both. It also needs to understand these netdev
modes? I was meaning you need to narrow the comment down to a trigger
which has something to do with netdev. I assume other sorts of
hardware offloads will appear in the future, once the generic
infrastructure is there.
Andrew
next prev parent reply other threads:[~2021-11-10 22:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 2:26 [RFC PATCH v3 0/8] Adds support for PHY LEDs with offload triggers Ansuel Smith
2021-11-09 2:26 ` [RFC PATCH v3 1/8] leds: add support for hardware driven LEDs Ansuel Smith
2021-11-09 6:16 ` Randy Dunlap
2021-11-09 20:25 ` kernel test robot
2021-11-09 20:34 ` Andrew Lunn
2021-11-09 20:40 ` Ansuel Smith
2021-11-09 2:26 ` [RFC PATCH v3 2/8] leds: add function to configure hardware controlled LED Ansuel Smith
2021-11-09 3:01 ` Marek Behún
2021-11-09 14:22 ` Ansuel Smith
2021-11-09 20:49 ` Andrew Lunn
2021-11-10 19:51 ` Ansuel Smith
2021-11-10 22:24 ` Andrew Lunn
2021-11-09 22:18 ` Marek Behún
2021-11-09 6:12 ` Randy Dunlap
2021-11-09 2:26 ` [RFC PATCH v3 3/8] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode Ansuel Smith
2021-11-09 3:02 ` Marek Behún
2021-11-09 14:24 ` Ansuel Smith
2021-11-09 20:53 ` Andrew Lunn
2021-11-09 2:26 ` [RFC PATCH v3 4/8] leds: trigger: netdev: rename and expose NETDEV trigger enum modes Ansuel Smith
2021-11-09 20:58 ` Andrew Lunn
2021-11-10 19:57 ` Ansuel Smith
2021-11-10 22:29 ` Andrew Lunn [this message]
2021-11-09 2:26 ` [RFC PATCH v3 5/8] leds: trigger: netdev: add hardware control support Ansuel Smith
2021-11-09 3:12 ` Marek Behún
2021-11-09 15:02 ` Ansuel Smith
2021-11-09 2:26 ` [RFC PATCH v3 6/8] leds: trigger: add hardware-phy-activity trigger Ansuel Smith
2021-11-09 3:25 ` Marek Behún
2021-11-09 21:09 ` Andrew Lunn
2021-11-10 20:04 ` Ansuel Smith
2021-11-10 22:32 ` Andrew Lunn
2021-11-09 6:02 ` Randy Dunlap
2021-11-09 15:06 ` Ansuel Smith
2021-11-09 21:17 ` Andrew Lunn
2021-11-09 21:28 ` Andrew Lunn
2021-11-09 2:26 ` [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support Ansuel Smith
2021-11-09 6:03 ` Randy Dunlap
2021-11-09 21:22 ` Andrew Lunn
2021-11-09 2:26 ` [RFC PATCH v3 8/8] dt-bindings: net: dsa: qca8k: add LEDs definition example Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYxHwJLdNpDLPLd4@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.