From: Joerg Roedel <jroedel@suse.de>
To: Michael Sterritt <sterritt@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-coco@lists.linux.dev, Paolo Bonzini <pbonzini@redhat.com>,
marcorr@google.com, pgonda@google.com
Subject: Re: [PATCH v2] x86/sev-es: Fix SEV-ES INS/OUTS instructions for word, dword, and qword
Date: Wed, 24 Nov 2021 14:28:49 +0100 [thread overview]
Message-ID: <YZ4+EYF8dhrzRy2h@suse.de> (raw)
In-Reply-To: <20211119232757.176201-1-sterritt@google.com>
On Fri, Nov 19, 2021 at 03:27:57PM -0800, Michael Sterritt wrote:
> Properly type the operands being passed to __put_user()/__get_user().
> Otherwise, these routines truncate data for dependent instructions
> (e.g., INSW) and only read/write one byte.
>
> Tested: Tested by sending a string with `REP OUTSW` to a port and then
> reading it back in with `REP INSW` on the same port. Previous behavior
> was to only send and receive the first char of the size. For example,
> word operations for "abcd" would only read/write "ac". With change, the
> full string is now written and read back.
>
> Fixes: f980f9c31a923 (x86/sev-es: Compile early handler code into kernel image)
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Marc Orr <marcorr@google.com>
> Reviewed-by: Peter Gonda <pgonda@google.com>
> Signed-off-by: Michael Sterritt <sterritt@google.com>
Reviewed-by: Joerg Roedel <jroedel@suse.de>
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Michael Sterritt <sterritt@google.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org, kvm@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, marcorr@google.com,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
linux-coco@lists.linux.dev, pgonda@google.com,
"H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] x86/sev-es: Fix SEV-ES INS/OUTS instructions for word, dword, and qword
Date: Wed, 24 Nov 2021 14:28:49 +0100 [thread overview]
Message-ID: <YZ4+EYF8dhrzRy2h@suse.de> (raw)
In-Reply-To: <20211119232757.176201-1-sterritt@google.com>
On Fri, Nov 19, 2021 at 03:27:57PM -0800, Michael Sterritt wrote:
> Properly type the operands being passed to __put_user()/__get_user().
> Otherwise, these routines truncate data for dependent instructions
> (e.g., INSW) and only read/write one byte.
>
> Tested: Tested by sending a string with `REP OUTSW` to a port and then
> reading it back in with `REP INSW` on the same port. Previous behavior
> was to only send and receive the first char of the size. For example,
> word operations for "abcd" would only read/write "ac". With change, the
> full string is now written and read back.
>
> Fixes: f980f9c31a923 (x86/sev-es: Compile early handler code into kernel image)
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Marc Orr <marcorr@google.com>
> Reviewed-by: Peter Gonda <pgonda@google.com>
> Signed-off-by: Michael Sterritt <sterritt@google.com>
Reviewed-by: Joerg Roedel <jroedel@suse.de>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-11-24 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 23:27 [PATCH v2] x86/sev-es: Fix SEV-ES INS/OUTS instructions for word, dword, and qword Michael Sterritt
2021-11-24 13:28 ` Joerg Roedel [this message]
2021-11-24 13:28 ` Joerg Roedel
2021-12-03 17:24 ` [tip: x86/urgent] x86/sev: " tip-bot2 for Michael Sterritt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ4+EYF8dhrzRy2h@suse.de \
--to=jroedel@suse.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=sterritt@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.