From: Tzung-Bi Shih <tzungbi@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Xin Ji <xji@analogixsemi.com>, Sam Ravnborg <sam@ravnborg.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Maxime Ripard <maxime@cerno.tech>,
Hsin-Yi Wang <hsinyi@chromium.org>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
Date: Thu, 25 Nov 2021 16:16:33 +0800 [thread overview]
Message-ID: <YZ9GYUrBvmCQaZtg@google.com> (raw)
In-Reply-To: <20211124145219.GD13656@kili>
On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote:
> This code accidentally returns IS_ERR(), which is 1, instead of
> propagating the negative error code. The caller doesn't check for
> errors so it doesn't affect run time at all.
>
> Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Pi-Hsun Shih <pihsun@chromium.org>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Robert Foss <robert.foss@linaro.org>,
dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
kernel-janitors@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>, Xin Ji <xji@analogixsemi.com>,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
Date: Thu, 25 Nov 2021 16:16:33 +0800 [thread overview]
Message-ID: <YZ9GYUrBvmCQaZtg@google.com> (raw)
In-Reply-To: <20211124145219.GD13656@kili>
On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote:
> This code accidentally returns IS_ERR(), which is 1, instead of
> propagating the negative error code. The caller doesn't check for
> errors so it doesn't affect run time at all.
>
> Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
next prev parent reply other threads:[~2021-11-25 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 14:52 [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio() Dan Carpenter
2021-11-24 14:52 ` Dan Carpenter
2021-11-25 8:16 ` Tzung-Bi Shih [this message]
2021-11-25 8:16 ` Tzung-Bi Shih
2021-11-25 10:08 ` Robert Foss
2021-11-25 10:08 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ9GYUrBvmCQaZtg@google.com \
--to=tzungbi@google.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=pihsun@chromium.org \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.