All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
Cc: g@quicinc.com, agross@kernel.org, bjorn.andersson@linaro.org,
	mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
	tglx@linutronix.de, maz@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH v4 2/6] clk: qcom: Add LUCID_EVO PLL type for SDX65
Date: Thu, 18 Nov 2021 10:11:07 +0530	[thread overview]
Message-ID: <YZXZY/1xqF1C+eCG@matsya> (raw)
In-Reply-To: <20211118015450.GB18984@quicinc.com>

On 17-11-21, 17:54, Vamsi Krishna Lanka wrote:
> On Tue, Nov 16, 2021 at 01:55:29PM +0530, Vinod Koul wrote:
> > On 15-11-21, 23:38, quic_vamslank@quicinc.com wrote:
> > > From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>

> > > +{
> > > +	struct clk_alpha_pll *pll = to_clk_alpha_pll(hw);
> > > +	struct regmap *regmap = pll->clkr.regmap;
> > > +	u32 l, frac;
> > > +
> > > +	regmap_read(regmap, PLL_L_VAL(pll), &l);
> > > +	l &= LUCID_EVO_PLL_L_VAL_MASK;
> > > +	regmap_read(regmap, PLL_ALPHA_VAL(pll), &frac);
> > > +
> > > +	return alpha_pll_calc_rate(parent_rate, l, frac, pll_alpha_width(pll));
> > > +}
> > 
> > I think this can use __alpha_pll_trion_set_rate()

> 
> I didn't get with which function are you comparing this. I cannot able to
> find any function similar to this.

This is in upstream, pls see commit: 80ca7765fc75 ("clk: qcom:
clk-alpha-pll: modularize alpha_pll_trion_set_rate()")

-- 
~Vinod

  reply	other threads:[~2021-11-18  4:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  7:38 [PATCH v4 0/6] Add Pdc, GCC and RPMh clock support for SDX65 quic_vamslank
2021-11-16  7:38 ` [PATCH v4 1/6] dt-bindings: clock: Add SDX65 GCC clock bindings quic_vamslank
2021-11-19  1:06   ` Rob Herring
2021-11-16  7:38 ` [PATCH v4 2/6] clk: qcom: Add LUCID_EVO PLL type for SDX65 quic_vamslank
2021-11-16  8:25   ` Vinod Koul
2021-11-18  1:54     ` Vamsi Krishna Lanka
2021-11-18  4:41       ` Vinod Koul [this message]
2021-11-16  7:38 ` [PATCH v4 3/6] clk: qcom: Add SDX65 GCC support quic_vamslank
2021-11-16  8:33   ` Vinod Koul
2021-11-18  1:51     ` Vamsi Krishna Lanka
2021-11-18  4:39       ` Vinod Koul
2021-11-18  5:04         ` Vamsi Krishna Lanka
2021-11-18  5:08           ` Vinod Koul
2021-11-16  7:38 ` [PATCH v4 4/6] dt-bindings: clock: Introduce RPMHCC bindings for SDX65 quic_vamslank
2021-11-16  8:34   ` Vinod Koul
2021-11-16  7:38 ` [PATCH v4 5/6] clk: qcom: Add support for SDX65 RPMh clocks quic_vamslank
2021-11-16  8:35   ` Vinod Koul
2021-11-16  7:38 ` [PATCH v4 6/6] dt-bindings: clock: Introduce pdc bindings for SDX65 quic_vamslank
2021-11-16  8:36   ` Vinod Koul
2021-11-16  8:33 ` [PATCH v4 0/6] Add Pdc, GCC and RPMh clock support " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZXZY/1xqF1C+eCG@matsya \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=g@quicinc.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_vamslank@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.