From: Rob Herring <robh@kernel.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [RFC PATCH v3 1/7] dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller
Date: Fri, 19 Nov 2021 10:52:04 -0600 [thread overview]
Message-ID: <YZfWNNkO1Kcghona@robh.at.kernel.org> (raw)
In-Reply-To: <20211110225808.16388-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Wed, Nov 10, 2021 at 10:58:02PM +0000, Lad Prabhakar wrote:
> Add DT bindings for the Renesas RZ/G2L Interrupt Controller.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> .../renesas,rzg2l-irqc.yaml | 137 ++++++++++++++++++
> 1 file changed, 137 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> new file mode 100644
> index 000000000000..ebe318fe336b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> @@ -0,0 +1,137 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/renesas,rzg2l-irqc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas RZ/G2L Interrupt Controller
> +
> +maintainers:
> + - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> + - Geert Uytterhoeven <geert+renesas@glider.be>
> +
> +description: |
> + The RZ/G2L Interrupt Controller is a front-end for the GIC found on Renesas RZ/G2L SoC's
> + - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts
> + - GPIO pins used as external interrupt input pins, mapped to 32 GIC SPI interrupts
> + - NMI edge select (NMI is not treated as NMI exception and supports fall edge and
> + stand-up edge detection interrupts)
> +
> +allOf:
> + - $ref: /schemas/interrupt-controller.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - renesas,r9a07g044-irqc # RZ/G2L
> + - const: renesas,rzg2l-irqc
> +
> + '#interrupt-cells':
> + const: 2
> +
> + '#address-cells':
> + const: 0
> +
> + interrupt-controller: true
> +
> + reg:
> + maxItems: 1
> +
> + interrupt-map:
> + maxItems: 41
> + description: Specifies the mapping from external interrupts to GIC interrupts.
> +
> + interrupt-map-mask:
> + items:
> + - const: 40
> + - const: 0
Are you sure this is what you want? I'd expect <0xff 0x0> here.
Otherwise, it's kind of pointless to list out 41 interrupt-map entries.
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: clk
> + - const: pclk
> +
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - '#interrupt-cells'
> + - '#address-cells'
> + - interrupt-controller
> + - reg
> + - interrupt-map
> + - interrupt-map-mask
> + - clocks
> + - clock-names
> + - power-domains
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/r9a07g044-cpg.h>
> +
> + irqc: interrupt-controller@110a0000 {
> + compatible = "renesas,r9a07g044-irqc", "renesas,rzg2l-irqc";
> + #interrupt-cells = <2>;
> + #address-cells = <0>;
> + interrupt-controller;
> + reg = <0x110a0000 0x10000>;
> + interrupt-map = <0 0 &gic GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
> + <1 0 &gic GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
> + <2 0 &gic GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
> + <3 0 &gic GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
> + <4 0 &gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> + <5 0 &gic GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> + <6 0 &gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> + <7 0 &gic GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
> + <8 0 &gic GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> + <9 0 &gic GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>,
> + <10 0 &gic GIC_SPI 445 IRQ_TYPE_LEVEL_HIGH>,
> + <11 0 &gic GIC_SPI 446 IRQ_TYPE_LEVEL_HIGH>,
> + <12 0 &gic GIC_SPI 447 IRQ_TYPE_LEVEL_HIGH>,
> + <13 0 &gic GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>,
> + <14 0 &gic GIC_SPI 449 IRQ_TYPE_LEVEL_HIGH>,
> + <15 0 &gic GIC_SPI 450 IRQ_TYPE_LEVEL_HIGH>,
> + <16 0 &gic GIC_SPI 451 IRQ_TYPE_LEVEL_HIGH>,
> + <17 0 &gic GIC_SPI 452 IRQ_TYPE_LEVEL_HIGH>,
> + <18 0 &gic GIC_SPI 453 IRQ_TYPE_LEVEL_HIGH>,
> + <19 0 &gic GIC_SPI 454 IRQ_TYPE_LEVEL_HIGH>,
> + <20 0 &gic GIC_SPI 455 IRQ_TYPE_LEVEL_HIGH>,
> + <21 0 &gic GIC_SPI 456 IRQ_TYPE_LEVEL_HIGH>,
> + <22 0 &gic GIC_SPI 457 IRQ_TYPE_LEVEL_HIGH>,
> + <23 0 &gic GIC_SPI 458 IRQ_TYPE_LEVEL_HIGH>,
> + <24 0 &gic GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>,
> + <25 0 &gic GIC_SPI 460 IRQ_TYPE_LEVEL_HIGH>,
> + <26 0 &gic GIC_SPI 461 IRQ_TYPE_LEVEL_HIGH>,
> + <27 0 &gic GIC_SPI 462 IRQ_TYPE_LEVEL_HIGH>,
> + <28 0 &gic GIC_SPI 463 IRQ_TYPE_LEVEL_HIGH>,
> + <29 0 &gic GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>,
> + <30 0 &gic GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>,
> + <31 0 &gic GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>,
> + <32 0 &gic GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>,
> + <33 0 &gic GIC_SPI 468 IRQ_TYPE_LEVEL_HIGH>,
> + <34 0 &gic GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>,
> + <35 0 &gic GIC_SPI 470 IRQ_TYPE_LEVEL_HIGH>,
> + <36 0 &gic GIC_SPI 471 IRQ_TYPE_LEVEL_HIGH>,
> + <37 0 &gic GIC_SPI 472 IRQ_TYPE_LEVEL_HIGH>,
> + <38 0 &gic GIC_SPI 473 IRQ_TYPE_LEVEL_HIGH>,
> + <39 0 &gic GIC_SPI 474 IRQ_TYPE_LEVEL_HIGH>,
> + <40 0 &gic GIC_SPI 475 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-map-mask = <40 0>;
> + clocks = <&cpg CPG_MOD R9A07G044_IA55_CLK>,
> + <&cpg CPG_MOD R9A07G044_IA55_PCLK>;
> + clock-names = "clk", "pclk";
> + power-domains = <&cpg>;
> + resets = <&cpg R9A07G044_IA55_RESETN>;
> + };
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2021-11-19 16:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 22:58 [RFC PATCH v3 0/7] Renesas RZ/G2L IRQC support Lad Prabhakar
2021-11-10 22:58 ` [RFC PATCH v3 1/7] dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller Lad Prabhakar
2021-11-19 16:52 ` Rob Herring [this message]
2021-11-10 22:58 ` [RFC PATCH v3 2/7] irqchip: Add RZ/G2L IA55 Interrupt Controller driver Lad Prabhakar
2021-12-10 14:37 ` Marc Zyngier
2021-11-10 22:58 ` [RFC PATCH v3 3/7] soc: renesas: Enable IRQC driver for RZ/G2L Lad Prabhakar
2021-11-10 22:58 ` [RFC PATCH v3 4/7] gpio: gpiolib: Allow free() callback to be overridden Lad Prabhakar
2021-11-10 22:58 ` [RFC PATCH v3 5/7] gpio: gpiolib: Add ngirq member to struct gpio_irq_chip Lad Prabhakar
2021-11-11 20:52 ` Andy Shevchenko
2021-11-11 21:15 ` Lad, Prabhakar
2021-11-10 22:58 ` [RFC PATCH v3 6/7] pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt Lad Prabhakar
2021-11-10 22:58 ` [RFC PATCH v3 7/7] arm64: dts: renesas: r9a07g044: Add IRQC node to SoC DTSI Lad Prabhakar
2021-11-12 14:12 ` [RFC PATCH v3 0/7] Renesas RZ/G2L IRQC support Geert Uytterhoeven
2021-11-12 14:22 ` Lad, Prabhakar
2021-11-22 19:25 ` Lad, Prabhakar
2021-12-10 1:08 ` Lad, Prabhakar
2021-12-10 2:04 ` Linus Walleij
2021-12-10 9:37 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZfWNNkO1Kcghona@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.