From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Nick Desaulniers <ndesaulniers@google.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [pinctrl-intel:review-andy 18/19] drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here
Date: Fri, 19 Nov 2021 19:44:06 +0200 [thread overview]
Message-ID: <YZfiZmd14pD4JQMY@smile.fi.intel.com> (raw)
In-Reply-To: <YZfc4wmvcQW9Kpcz@archlinux-ax161>
On Fri, Nov 19, 2021 at 10:20:35AM -0700, Nathan Chancellor wrote:
> On Fri, Nov 19, 2021 at 10:33:36AM +0200, Andy Shevchenko wrote:
> > On Fri, Nov 19, 2021 at 04:08:32PM +0800, kernel test robot wrote:
...
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here [-Wuninitialized]
> > > if (IS_ERR(pin->name))
> > > ^~~
> > > drivers/pinctrl/pinctrl-zynqmp.c:811:37: note: initialize the variable 'pin' to silence this warning
> > > struct pinctrl_pin_desc *pins, *pin;
> > > ^
> > > = NULL
> > > 1 warning generated.
> >
> > Utterly inappropriate suggestion by the compiler (it found an actual error,
> > though).
> >
> > Can be Clang fixed, really?
>
> I reported this upstream: https://bugs.llvm.org/show_bug.cgi?id=52559
Thanks!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [pinctrl-intel:review-andy 18/19] drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here
Date: Fri, 19 Nov 2021 19:44:06 +0200 [thread overview]
Message-ID: <YZfiZmd14pD4JQMY@smile.fi.intel.com> (raw)
In-Reply-To: <YZfc4wmvcQW9Kpcz@archlinux-ax161>
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On Fri, Nov 19, 2021 at 10:20:35AM -0700, Nathan Chancellor wrote:
> On Fri, Nov 19, 2021 at 10:33:36AM +0200, Andy Shevchenko wrote:
> > On Fri, Nov 19, 2021 at 04:08:32PM +0800, kernel test robot wrote:
...
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here [-Wuninitialized]
> > > if (IS_ERR(pin->name))
> > > ^~~
> > > drivers/pinctrl/pinctrl-zynqmp.c:811:37: note: initialize the variable 'pin' to silence this warning
> > > struct pinctrl_pin_desc *pins, *pin;
> > > ^
> > > = NULL
> > > 1 warning generated.
> >
> > Utterly inappropriate suggestion by the compiler (it found an actual error,
> > though).
> >
> > Can be Clang fixed, really?
>
> I reported this upstream: https://bugs.llvm.org/show_bug.cgi?id=52559
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-19 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 8:08 [pinctrl-intel:review-andy 18/19] drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here kernel test robot
2021-11-19 8:08 ` kernel test robot
2021-11-19 8:33 ` Andy Shevchenko
2021-11-19 8:33 ` Andy Shevchenko
2021-11-19 17:20 ` Nathan Chancellor
2021-11-19 17:20 ` Nathan Chancellor
2021-11-19 17:44 ` Andy Shevchenko [this message]
2021-11-19 17:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZfiZmd14pD4JQMY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.