From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alessandro B Maurici <abmaurici@gmail.com>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] phy: fix possible double lock calling link changed handler
Date: Tue, 23 Nov 2021 15:11:22 +0100 [thread overview]
Message-ID: <YZz2irnGkrVQPjTb@lunn.ch> (raw)
In-Reply-To: <017ea94f-7caf-3d4e-5900-aa23a212aa26@gmail.com>
> Seeing the following code snippet in lan743x_phy_link_status_change()
> I wonder why it doesn't use phydev->speed and phydev->duplex directly.
> The current code seems to include unneeded overhead.
Yes, that is the change i would make. When adding the extra locks i
missed that a driver was doing something like this. I will check all
other callers to see if they are using it in odd contexts.
Andrew
next prev parent reply other threads:[~2021-11-23 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 2:55 [PATCH] phy: fix possible double lock calling link changed handler Alessandro B Maurici
2021-11-23 4:18 ` Andrew Lunn
2021-11-23 4:49 ` Alessandro B Maurici
2021-11-23 8:21 ` Heiner Kallweit
2021-11-23 14:11 ` Andrew Lunn [this message]
2021-11-23 16:06 ` Alessandro B Maurici
2021-11-23 20:32 ` Heiner Kallweit
2021-11-23 22:31 ` Alessandro B Maurici
2021-11-23 14:09 ` Andrew Lunn
2021-11-23 14:14 ` Russell King (Oracle)
2021-11-23 15:58 ` Alessandro B Maurici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZz2irnGkrVQPjTb@lunn.ch \
--to=andrew@lunn.ch \
--cc=abmaurici@gmail.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.