From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [v14 0/2] Support pwm driver for aspeed ast26xx
Date: Tue, 7 Dec 2021 15:19:55 -0600 [thread overview]
Message-ID: <Ya/P+4CNTnUUqlG9@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XfM4C7v3keXaxMs9SkqNzb8XWbZ6QvcZXWcy3ZKJCrvWQ@mail.gmail.com>
On Tue, Dec 07, 2021 at 06:45:47AM +0000, Joel Stanley wrote:
> Hi Billy,
>
> On Tue, 30 Nov 2021 at 05:58, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> >
> > The legacy driver of aspeed pwm is binding with tach controller and it
> > doesn't follow the pwm framworks usage. In addition, the pwm register
> > usage of the 6th generation of ast26xx has drastic change. So these
> > patch serials add the new aspeed pwm driver to fix up the problem above.
>
> Sorry for not taking a look earlier. Well done on making it this far.
>
> There's a few things that need to be addressed before merging this.
>
> Firstly, the bindings need fixing up. I think these should be the one
> file. The device tree bindings are supposed to describe the hardware,
> and it doesn't make sense to separate them out just because we plan on
> using two subsystems to implement the functionality.
>
> Rob, please chime in if you would prefer something different.
I prefer to see a common binding for fans which I said multiple times
on this series. As the same thing keeps getting posted, I've stopped
looking at this one.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Andrew Jeffery <andrew@aj.id.au>,
Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-hwmon@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pwm@vger.kernel.org, BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [v14 0/2] Support pwm driver for aspeed ast26xx
Date: Tue, 7 Dec 2021 15:19:55 -0600 [thread overview]
Message-ID: <Ya/P+4CNTnUUqlG9@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XfM4C7v3keXaxMs9SkqNzb8XWbZ6QvcZXWcy3ZKJCrvWQ@mail.gmail.com>
On Tue, Dec 07, 2021 at 06:45:47AM +0000, Joel Stanley wrote:
> Hi Billy,
>
> On Tue, 30 Nov 2021 at 05:58, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> >
> > The legacy driver of aspeed pwm is binding with tach controller and it
> > doesn't follow the pwm framworks usage. In addition, the pwm register
> > usage of the 6th generation of ast26xx has drastic change. So these
> > patch serials add the new aspeed pwm driver to fix up the problem above.
>
> Sorry for not taking a look earlier. Well done on making it this far.
>
> There's a few things that need to be addressed before merging this.
>
> Firstly, the bindings need fixing up. I think these should be the one
> file. The device tree bindings are supposed to describe the hardware,
> and it doesn't make sense to separate them out just because we plan on
> using two subsystems to implement the functionality.
>
> Rob, please chime in if you would prefer something different.
I prefer to see a common binding for fans which I said multiple times
on this series. As the same thing keeps getting posted, I've stopped
looking at this one.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Andrew Jeffery <andrew@aj.id.au>,
Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-hwmon@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pwm@vger.kernel.org, BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [v14 0/2] Support pwm driver for aspeed ast26xx
Date: Tue, 7 Dec 2021 15:19:55 -0600 [thread overview]
Message-ID: <Ya/P+4CNTnUUqlG9@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XfM4C7v3keXaxMs9SkqNzb8XWbZ6QvcZXWcy3ZKJCrvWQ@mail.gmail.com>
On Tue, Dec 07, 2021 at 06:45:47AM +0000, Joel Stanley wrote:
> Hi Billy,
>
> On Tue, 30 Nov 2021 at 05:58, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> >
> > The legacy driver of aspeed pwm is binding with tach controller and it
> > doesn't follow the pwm framworks usage. In addition, the pwm register
> > usage of the 6th generation of ast26xx has drastic change. So these
> > patch serials add the new aspeed pwm driver to fix up the problem above.
>
> Sorry for not taking a look earlier. Well done on making it this far.
>
> There's a few things that need to be addressed before merging this.
>
> Firstly, the bindings need fixing up. I think these should be the one
> file. The device tree bindings are supposed to describe the hardware,
> and it doesn't make sense to separate them out just because we plan on
> using two subsystems to implement the functionality.
>
> Rob, please chime in if you would prefer something different.
I prefer to see a common binding for fans which I said multiple times
on this series. As the same thing keeps getting posted, I've stopped
looking at this one.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-07 21:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 5:59 [v14 0/2] Support pwm driver for aspeed ast26xx Billy Tsai
2021-11-30 5:59 ` Billy Tsai
2021-11-30 5:59 ` Billy Tsai
2021-11-30 5:59 ` [v14 1/2] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2021-11-30 5:59 ` Billy Tsai
2021-11-30 5:59 ` Billy Tsai
2021-11-30 5:59 ` [v14 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2021-11-30 5:59 ` Billy Tsai
2021-11-30 5:59 ` Billy Tsai
2021-11-30 6:58 ` Uwe Kleine-König
2021-11-30 6:58 ` Uwe Kleine-König
2021-11-30 6:58 ` Uwe Kleine-König
2021-12-07 6:45 ` [v14 0/2] Support pwm driver for aspeed ast26xx Joel Stanley
2021-12-07 6:45 ` Joel Stanley
2021-12-07 6:45 ` Joel Stanley
2021-12-07 21:19 ` Rob Herring [this message]
2021-12-07 21:19 ` Rob Herring
2021-12-07 21:19 ` Rob Herring
2021-12-08 4:02 ` Billy Tsai
2021-12-08 4:02 ` Billy Tsai
2021-12-08 4:02 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya/P+4CNTnUUqlG9@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.