All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH for-next] RDMA/bnxt_re: Fix endianness warning
@ 2021-12-05 20:45 Kamal Heib
  2021-12-06  7:23 ` Leon Romanovsky
  2021-12-06 23:57 ` Jason Gunthorpe
  0 siblings, 2 replies; 4+ messages in thread
From: Kamal Heib @ 2021-12-05 20:45 UTC (permalink / raw)
  To: linux-rdma; +Cc: Selvin Xavier, Jason Gunthorpe, Kamal Heib, kernel test robot

Fix the following sparce warning:
CHECK   ../drivers/infiniband/hw/bnxt_re/qplib_fp.c
drivers/infiniband/hw/bnxt_re/qplib_fp.c:1260:26: sparse: warning:
 incorrect type in assignment (different base types)

Fixes: 0e938533d96d ("RDMA/bnxt_re: Remove dynamic pkey table")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index f6472cca9ec7..96e581ced50e 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -1257,7 +1257,7 @@ int bnxt_qplib_modify_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
 		req.access = qp->access;
 
 	if (bmask & CMDQ_MODIFY_QP_MODIFY_MASK_PKEY)
-		req.pkey = IB_DEFAULT_PKEY_FULL;
+		req.pkey = cpu_to_le16(IB_DEFAULT_PKEY_FULL);
 
 	if (bmask & CMDQ_MODIFY_QP_MODIFY_MASK_QKEY)
 		req.qkey = cpu_to_le32(qp->qkey);
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH for-next] RDMA/bnxt_re: Fix endianness warning
  2021-12-05 20:45 [PATCH for-next] RDMA/bnxt_re: Fix endianness warning Kamal Heib
@ 2021-12-06  7:23 ` Leon Romanovsky
  2021-12-06 15:57   ` Selvin Xavier
  2021-12-06 23:57 ` Jason Gunthorpe
  1 sibling, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2021-12-06  7:23 UTC (permalink / raw)
  To: Kamal Heib; +Cc: linux-rdma, Selvin Xavier, Jason Gunthorpe, kernel test robot

On Sun, Dec 05, 2021 at 10:45:37PM +0200, Kamal Heib wrote:
> Fix the following sparce warning:
> CHECK   ../drivers/infiniband/hw/bnxt_re/qplib_fp.c
> drivers/infiniband/hw/bnxt_re/qplib_fp.c:1260:26: sparse: warning:
>  incorrect type in assignment (different base types)
> 
> Fixes: 0e938533d96d ("RDMA/bnxt_re: Remove dynamic pkey table")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

sparce -> sparse

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH for-next] RDMA/bnxt_re: Fix endianness warning
  2021-12-06  7:23 ` Leon Romanovsky
@ 2021-12-06 15:57   ` Selvin Xavier
  0 siblings, 0 replies; 4+ messages in thread
From: Selvin Xavier @ 2021-12-06 15:57 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Kamal Heib, linux-rdma, Jason Gunthorpe, kernel test robot

On Mon, Dec 6, 2021 at 12:54 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Sun, Dec 05, 2021 at 10:45:37PM +0200, Kamal Heib wrote:
> > Fix the following sparce warning:
> > CHECK   ../drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > drivers/infiniband/hw/bnxt_re/qplib_fp.c:1260:26: sparse: warning:
> >  incorrect type in assignment (different base types)
> >
> > Fixes: 0e938533d96d ("RDMA/bnxt_re: Remove dynamic pkey table")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> > ---
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> sparce -> sparse
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH for-next] RDMA/bnxt_re: Fix endianness warning
  2021-12-05 20:45 [PATCH for-next] RDMA/bnxt_re: Fix endianness warning Kamal Heib
  2021-12-06  7:23 ` Leon Romanovsky
@ 2021-12-06 23:57 ` Jason Gunthorpe
  1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2021-12-06 23:57 UTC (permalink / raw)
  To: Kamal Heib; +Cc: linux-rdma, Selvin Xavier, kernel test robot

On Sun, Dec 05, 2021 at 10:45:37PM +0200, Kamal Heib wrote:
> Fix the following sparce warning:
> CHECK   ../drivers/infiniband/hw/bnxt_re/qplib_fp.c
> drivers/infiniband/hw/bnxt_re/qplib_fp.c:1260:26: sparse: warning:
>  incorrect type in assignment (different base types)
> 
> Fixes: 0e938533d96d ("RDMA/bnxt_re: Remove dynamic pkey table")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-06 23:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-05 20:45 [PATCH for-next] RDMA/bnxt_re: Fix endianness warning Kamal Heib
2021-12-06  7:23 ` Leon Romanovsky
2021-12-06 15:57   ` Selvin Xavier
2021-12-06 23:57 ` Jason Gunthorpe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.