From: Rob Herring <robh@kernel.org>
To: Biao Huang <biao.huang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
srv_heupstream@mediatek.com, macpaul.lin@mediatek.com,
angelogioacchino.delregno@collabora.com, dkirjanov@suse.de
Subject: Re: [PATCH v3 4/7] net-next: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
Date: Sun, 28 Nov 2021 17:57:41 -0600 [thread overview]
Message-ID: <YaQXdaXzJ3LD7ab2@robh.at.kernel.org> (raw)
In-Reply-To: <5f6fec21ef9f2bca6007283b37e35301cfe745ed.camel@mediatek.com>
On Thu, Nov 18, 2021 at 11:09:55AM +0800, Biao Huang wrote:
> Dear Matthias,
> Agree, converting and changes should be seperated.
>
> There are some changes in the driver, but mediatek-dwmac.txt
>
> is not updated for a long time, and is not accurate enough.
>
> So this patch is more like a new yaml replace the old txt,
> than a word-to-word converting.
>
>
> Anyway, only 3 little changes compare to old mediate-dwmac.txt, others
> almost keep the same:
> 1. compatible " const: snps,dwmac-4.20"
> 2. delete "snps,reset-active-low;" in example, since driver
> remove this property long ago.
> 3. add "snps,reset-delays-us = <0 10000 10000>;" in example,
>
> Should I split this patch?
> If yes, I'll split in next send.
> Thanks.
It's fine with one patch, but describe the changes in the commit msg.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Biao Huang <biao.huang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
srv_heupstream@mediatek.com, macpaul.lin@mediatek.com,
angelogioacchino.delregno@collabora.com, dkirjanov@suse.de
Subject: Re: [PATCH v3 4/7] net-next: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
Date: Sun, 28 Nov 2021 17:57:41 -0600 [thread overview]
Message-ID: <YaQXdaXzJ3LD7ab2@robh.at.kernel.org> (raw)
In-Reply-To: <5f6fec21ef9f2bca6007283b37e35301cfe745ed.camel@mediatek.com>
On Thu, Nov 18, 2021 at 11:09:55AM +0800, Biao Huang wrote:
> Dear Matthias,
> Agree, converting and changes should be seperated.
>
> There are some changes in the driver, but mediatek-dwmac.txt
>
> is not updated for a long time, and is not accurate enough.
>
> So this patch is more like a new yaml replace the old txt,
> than a word-to-word converting.
>
>
> Anyway, only 3 little changes compare to old mediate-dwmac.txt, others
> almost keep the same:
> 1. compatible " const: snps,dwmac-4.20"
> 2. delete "snps,reset-active-low;" in example, since driver
> remove this property long ago.
> 3. add "snps,reset-delays-us = <0 10000 10000>;" in example,
>
> Should I split this patch?
> If yes, I'll split in next send.
> Thanks.
It's fine with one patch, but describe the changes in the commit msg.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Biao Huang <biao.huang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
srv_heupstream@mediatek.com, macpaul.lin@mediatek.com,
angelogioacchino.delregno@collabora.com, dkirjanov@suse.de
Subject: Re: [PATCH v3 4/7] net-next: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
Date: Sun, 28 Nov 2021 17:57:41 -0600 [thread overview]
Message-ID: <YaQXdaXzJ3LD7ab2@robh.at.kernel.org> (raw)
In-Reply-To: <5f6fec21ef9f2bca6007283b37e35301cfe745ed.camel@mediatek.com>
On Thu, Nov 18, 2021 at 11:09:55AM +0800, Biao Huang wrote:
> Dear Matthias,
> Agree, converting and changes should be seperated.
>
> There are some changes in the driver, but mediatek-dwmac.txt
>
> is not updated for a long time, and is not accurate enough.
>
> So this patch is more like a new yaml replace the old txt,
> than a word-to-word converting.
>
>
> Anyway, only 3 little changes compare to old mediate-dwmac.txt, others
> almost keep the same:
> 1. compatible " const: snps,dwmac-4.20"
> 2. delete "snps,reset-active-low;" in example, since driver
> remove this property long ago.
> 3. add "snps,reset-delays-us = <0 10000 10000>;" in example,
>
> Should I split this patch?
> If yes, I'll split in next send.
> Thanks.
It's fine with one patch, but describe the changes in the commit msg.
Rob
next prev parent reply other threads:[~2021-11-29 0:00 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 9:39 [PATCH v3 0/7] MediaTek Ethernet Patches on MT8195 Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 1/7] net-next: stmmac: dwmac-mediatek: add platform level clocks management Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 2/7] net-next: stmmac: dwmac-mediatek: Reuse more common features Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 3/7] arm64: dts: mt2712: update ethernet device node Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 4/7] net-next: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 13:48 ` Rob Herring
2021-11-12 13:48 ` Rob Herring
2021-11-12 13:48 ` Rob Herring
2021-11-15 1:39 ` Biao Huang
2021-11-15 1:39 ` Biao Huang
2021-11-15 1:39 ` Biao Huang
2021-11-17 15:11 ` Matthias Brugger
2021-11-17 15:11 ` Matthias Brugger
2021-11-17 15:11 ` Matthias Brugger
2021-11-18 3:09 ` Biao Huang
2021-11-18 3:09 ` Biao Huang
2021-11-18 3:09 ` Biao Huang
2021-11-28 23:57 ` Rob Herring [this message]
2021-11-28 23:57 ` Rob Herring
2021-11-28 23:57 ` Rob Herring
2021-11-29 1:46 ` Biao Huang
2021-11-29 1:46 ` Biao Huang
2021-11-29 1:46 ` Biao Huang
2021-11-28 23:59 ` Rob Herring
2021-11-28 23:59 ` Rob Herring
2021-11-28 23:59 ` Rob Herring
2021-11-29 1:44 ` Biao Huang
2021-11-29 1:44 ` Biao Huang
2021-11-29 1:44 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 5/7] net-next: stmmac: dwmac-mediatek: add support for mt8195 Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 6/7] arm64: dts: mt8195: add ethernet device node Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` [PATCH v3 7/7] net-next: dt-bindings: dwmac: add support for mt8195 Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 9:39 ` Biao Huang
2021-11-12 13:48 ` Rob Herring
2021-11-12 13:48 ` Rob Herring
2021-11-12 13:48 ` Rob Herring
2021-11-29 0:05 ` Rob Herring
2021-11-29 0:05 ` Rob Herring
2021-11-29 0:05 ` Rob Herring
2021-11-29 1:35 ` Biao Huang
2021-11-29 1:35 ` Biao Huang
2021-11-29 1:35 ` Biao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaQXdaXzJ3LD7ab2@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dkirjanov@suse.de \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.