From: Wolfram Sang <wsa@kernel.org>
To: John Keeping <john@metanate.com>
Cc: linux-i2c@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: rk3x: enable clock before getting rate
Date: Mon, 29 Nov 2021 10:40:02 +0100 [thread overview]
Message-ID: <YaSf8uDjGCBHcHyZ@kunai> (raw)
In-Reply-To: <20211004131539.1253195-1-john@metanate.com>
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
On Mon, Oct 04, 2021 at 02:15:39PM +0100, John Keeping wrote:
> clk_get_rate() is documented as requiring the clock to be enabled.
> Ensure that the bus clock is enabled before calling clk_get_rate() in
> rk3x_i2c_probe() to satisfy this requirement.
>
> Signed-off-by: John Keeping <john@metanate.com>
Doesn't look like an urgent bugfix, so applied to for-next, thanks! Let
me know if it should go to for-current instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: John Keeping <john@metanate.com>
Cc: linux-i2c@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: rk3x: enable clock before getting rate
Date: Mon, 29 Nov 2021 10:40:02 +0100 [thread overview]
Message-ID: <YaSf8uDjGCBHcHyZ@kunai> (raw)
In-Reply-To: <20211004131539.1253195-1-john@metanate.com>
[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]
On Mon, Oct 04, 2021 at 02:15:39PM +0100, John Keeping wrote:
> clk_get_rate() is documented as requiring the clock to be enabled.
> Ensure that the bus clock is enabled before calling clk_get_rate() in
> rk3x_i2c_probe() to satisfy this requirement.
>
> Signed-off-by: John Keeping <john@metanate.com>
Doesn't look like an urgent bugfix, so applied to for-next, thanks! Let
me know if it should go to for-current instead.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: John Keeping <john@metanate.com>
Cc: linux-i2c@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: rk3x: enable clock before getting rate
Date: Mon, 29 Nov 2021 10:40:02 +0100 [thread overview]
Message-ID: <YaSf8uDjGCBHcHyZ@kunai> (raw)
In-Reply-To: <20211004131539.1253195-1-john@metanate.com>
[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]
On Mon, Oct 04, 2021 at 02:15:39PM +0100, John Keeping wrote:
> clk_get_rate() is documented as requiring the clock to be enabled.
> Ensure that the bus clock is enabled before calling clk_get_rate() in
> rk3x_i2c_probe() to satisfy this requirement.
>
> Signed-off-by: John Keeping <john@metanate.com>
Doesn't look like an urgent bugfix, so applied to for-next, thanks! Let
me know if it should go to for-current instead.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-29 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:15 [PATCH] i2c: rk3x: enable clock before getting rate John Keeping
2021-10-04 13:15 ` John Keeping
2021-10-04 13:15 ` John Keeping
2021-11-21 18:00 ` Heiko Stübner
2021-11-21 18:00 ` Heiko Stübner
2021-11-21 18:00 ` Heiko Stübner
2021-11-22 7:39 ` Wolfram Sang
2021-11-22 7:39 ` Wolfram Sang
2021-11-22 7:39 ` Wolfram Sang
2021-11-29 9:40 ` Wolfram Sang [this message]
2021-11-29 9:40 ` Wolfram Sang
2021-11-29 9:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaSf8uDjGCBHcHyZ@kunai \
--to=wsa@kernel.org \
--cc=heiko@sntech.de \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.