All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Scott Branden <sbranden@broadcom.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-rpi-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dom Cobley <dom@raspberrypi.com>,
	devicetree@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware
Date: Mon, 29 Nov 2021 16:49:51 -0600	[thread overview]
Message-ID: <YaVZDxac/OGyJVC9@robh.at.kernel.org> (raw)
In-Reply-To: <20211117145040.334827-2-maxime@cerno.tech>

On Wed, Nov 17, 2021 at 03:50:36PM +0100, Maxime Ripard wrote:
> The firmware can free all the resources it was using to run the display
> engine that won't be needed once the kernel has taken over.
> 
> Thus, we need a phandle to the firmware DT node to be able to send that
> message when relevant.

Why? Just use of_find_compatible_node(). 

> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../devicetree/bindings/display/brcm,bcm2835-vc4.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> index 49a5e041aa49..18de6912b833 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> @@ -21,6 +21,11 @@ properties:
>        - brcm,bcm2835-vc4
>        - brcm,cygnus-vc4
>  
> +  raspberrypi,firmware:
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
> +    description: >
> +      Phandle to the firmware node
> +
>  required:
>    - compatible
>  
> -- 
> 2.33.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Scott Branden <sbranden@broadcom.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-rpi-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dom Cobley <dom@raspberrypi.com>,
	devicetree@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware
Date: Mon, 29 Nov 2021 16:49:51 -0600	[thread overview]
Message-ID: <YaVZDxac/OGyJVC9@robh.at.kernel.org> (raw)
In-Reply-To: <20211117145040.334827-2-maxime@cerno.tech>

On Wed, Nov 17, 2021 at 03:50:36PM +0100, Maxime Ripard wrote:
> The firmware can free all the resources it was using to run the display
> engine that won't be needed once the kernel has taken over.
> 
> Thus, we need a phandle to the firmware DT node to be able to send that
> message when relevant.

Why? Just use of_find_compatible_node(). 

> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../devicetree/bindings/display/brcm,bcm2835-vc4.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> index 49a5e041aa49..18de6912b833 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> @@ -21,6 +21,11 @@ properties:
>        - brcm,bcm2835-vc4
>        - brcm,cygnus-vc4
>  
> +  raspberrypi,firmware:
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
> +    description: >
> +      Phandle to the firmware node
> +
>  required:
>    - compatible
>  
> -- 
> 2.33.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Scott Branden <sbranden@broadcom.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	David Airlie <airlied@linux.ie>, Ray Jui <rjui@broadcom.com>,
	dri-devel@lists.freedesktop.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Phil Elwell <phil@raspberrypi.com>,
	linux-arm-kernel@lists.infradead.org,
	Dom Cobley <dom@raspberrypi.com>
Subject: Re: [PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware
Date: Mon, 29 Nov 2021 16:49:51 -0600	[thread overview]
Message-ID: <YaVZDxac/OGyJVC9@robh.at.kernel.org> (raw)
In-Reply-To: <20211117145040.334827-2-maxime@cerno.tech>

On Wed, Nov 17, 2021 at 03:50:36PM +0100, Maxime Ripard wrote:
> The firmware can free all the resources it was using to run the display
> engine that won't be needed once the kernel has taken over.
> 
> Thus, we need a phandle to the firmware DT node to be able to send that
> message when relevant.

Why? Just use of_find_compatible_node(). 

> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../devicetree/bindings/display/brcm,bcm2835-vc4.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> index 49a5e041aa49..18de6912b833 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> @@ -21,6 +21,11 @@ properties:
>        - brcm,bcm2835-vc4
>        - brcm,cygnus-vc4
>  
> +  raspberrypi,firmware:
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
> +    description: >
> +      Phandle to the firmware node
> +
>  required:
>    - compatible
>  
> -- 
> 2.33.1
> 
> 

  reply	other threads:[~2021-11-29 22:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 14:50 [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline Maxime Ripard
2021-11-17 14:50 ` Maxime Ripard
2021-11-17 14:50 ` Maxime Ripard
2021-11-17 14:50 ` [PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-29 22:49   ` Rob Herring [this message]
2021-11-29 22:49     ` Rob Herring
2021-11-29 22:49     ` Rob Herring
2021-11-17 14:50 ` [PATCH 2/5] firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50 ` [PATCH 3/5] drm/vc4: Remove conflicting framebuffers before callind bind_all Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50 ` [PATCH 4/5] drm/vc4: Notify the firmware when DRM is in charge Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50 ` [PATCH 5/5] ARM: dts: rpi: Add the firmware node to vc4 Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-17 14:50   ` Maxime Ripard
2021-11-30 11:45 ` [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline nicolas saenz julienne
2021-11-30 11:45   ` nicolas saenz julienne
2021-11-30 11:45   ` nicolas saenz julienne
2021-12-03 13:50   ` Maxime Ripard
2021-12-03 13:50     ` Maxime Ripard
2021-12-03 13:50     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaVZDxac/OGyJVC9@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=daniel.vetter@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dom@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime@cerno.tech \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=tim.gover@raspberrypi.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.