All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Peter Collingbourne <pcc@google.com>
Cc: Anibal Limon <anibal.limon@linaro.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Robert Foss <robert.foss@linaro.org>
Subject: Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing
Date: Tue, 30 Nov 2021 11:00:49 +0530	[thread overview]
Message-ID: <YaW3Cff+AJqT8tS/@matsya> (raw)
In-Reply-To: <20211117020724.2647769-1-pcc@google.com>

On 16-11-21, 18:07, Peter Collingbourne wrote:
> It has been observed that with certain monitors such as the HP Z27n,
> the register 0x825e reads a value of 0x79 when the HDMI cable is
> connected and 0x78 when it is disconnected, i.e. bit 0 appears
> to correspond to the HDMI connection status and bit 2 is never
> set. Therefore, change the driver to check bit 0 instead of bit 2.

So we have got limited information on this but BIT-2 seems to be related
to HPD and empirical data from various monitors supports this, so this
seems the right thing to do.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Peter Collingbourne <pcc@google.com>
Cc: Robert Foss <robert.foss@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Anibal Limon <anibal.limon@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing
Date: Tue, 30 Nov 2021 11:00:49 +0530	[thread overview]
Message-ID: <YaW3Cff+AJqT8tS/@matsya> (raw)
In-Reply-To: <20211117020724.2647769-1-pcc@google.com>

On 16-11-21, 18:07, Peter Collingbourne wrote:
> It has been observed that with certain monitors such as the HP Z27n,
> the register 0x825e reads a value of 0x79 when the HDMI cable is
> connected and 0x78 when it is disconnected, i.e. bit 0 appears
> to correspond to the HDMI connection status and bit 2 is never
> set. Therefore, change the driver to check bit 0 instead of bit 2.

So we have got limited information on this but BIT-2 seems to be related
to HPD and empirical data from various monitors supports this, so this
seems the right thing to do.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

  parent reply	other threads:[~2021-11-30  5:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  2:07 [PATCH] lontium-lt9611: check a different register bit for HDMI sensing Peter Collingbourne
2021-11-17  2:07 ` Peter Collingbourne
2021-11-17  4:47 ` John Stultz
2021-11-17  4:47   ` John Stultz
2021-11-17  5:10   ` Vinod Koul
2021-11-17  5:10     ` Vinod Koul
2021-11-17  4:49 ` Anibal Limon
2021-11-17  5:09   ` Vinod Koul
2021-11-17  5:09     ` Vinod Koul
2021-11-30  5:30 ` Vinod Koul [this message]
2021-11-30  5:30   ` Vinod Koul
2021-11-30 12:17   ` Robert Foss
2021-11-30 12:17     ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaW3Cff+AJqT8tS/@matsya \
    --to=vkoul@kernel.org \
    --cc=anibal.limon@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pcc@google.com \
    --cc=robert.foss@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.