From: Wolfram Sang <wsa@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v5 1/3] i2c: aspeed: Add slave_enable() to toggle slave mode
Date: Tue, 30 Nov 2021 11:02:59 +0100 [thread overview]
Message-ID: <YaX2021qO696FG1D@ninjato> (raw)
In-Reply-To: <b8ee3be7-c0f6-d1fd-1ba1-13066b329ee3@os.amperecomputing.com>
Hi,
> Thanks Wolfram to help bring this up,
Sure thing! It would be sad to see this work bitrot.
> This driver was tested with Aspeed ast2500 and we have tried many way to
> avoid using slave_enable() to toggle slave mode but there is no progress.
I see. I also can't help you there. I have neither experience with nor
access to this HW.
> Our expectation is still to have this driver upstream'ed and I'm thinking
> about testing this driver on other HW and re-post the driver.
That sounds like a good plan.
> I have to admit that you are all right with the above comments. The fact is
> we still not be able to find any way to solve this differently. We don't own
> this HW and dont know what happen on this particular issue. The SCL clock
> stretching on this HW does not work as expected and the slave_enable() is
> the only solution for now. I hope if someone could help with the issue as
> well.
From this distance, it looks like HW access and a logic analyzer might
be helpful in understanding the behaviour. Pity that you don't own the
HW.
Good luck nonetheless!
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20211130/a98bc6a6/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: Corey Minyard <minyard@acm.org>, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
openipmi-developer@lists.sourceforge.net,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v5 1/3] i2c: aspeed: Add slave_enable() to toggle slave mode
Date: Tue, 30 Nov 2021 11:02:59 +0100 [thread overview]
Message-ID: <YaX2021qO696FG1D@ninjato> (raw)
In-Reply-To: <b8ee3be7-c0f6-d1fd-1ba1-13066b329ee3@os.amperecomputing.com>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
Hi,
> Thanks Wolfram to help bring this up,
Sure thing! It would be sad to see this work bitrot.
> This driver was tested with Aspeed ast2500 and we have tried many way to
> avoid using slave_enable() to toggle slave mode but there is no progress.
I see. I also can't help you there. I have neither experience with nor
access to this HW.
> Our expectation is still to have this driver upstream'ed and I'm thinking
> about testing this driver on other HW and re-post the driver.
That sounds like a good plan.
> I have to admit that you are all right with the above comments. The fact is
> we still not be able to find any way to solve this differently. We don't own
> this HW and dont know what happen on this particular issue. The SCL clock
> stretching on this HW does not work as expected and the slave_enable() is
> the only solution for now. I hope if someone could help with the issue as
> well.
From this distance, it looks like HW access and a logic analyzer might
be helpful in understanding the behaviour. Pity that you don't own the
HW.
Good luck nonetheless!
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: Corey Minyard <minyard@acm.org>, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
openipmi-developer@lists.sourceforge.net,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v5 1/3] i2c: aspeed: Add slave_enable() to toggle slave mode
Date: Tue, 30 Nov 2021 11:02:59 +0100 [thread overview]
Message-ID: <YaX2021qO696FG1D@ninjato> (raw)
In-Reply-To: <b8ee3be7-c0f6-d1fd-1ba1-13066b329ee3@os.amperecomputing.com>
[-- Attachment #1.1: Type: text/plain, Size: 1124 bytes --]
Hi,
> Thanks Wolfram to help bring this up,
Sure thing! It would be sad to see this work bitrot.
> This driver was tested with Aspeed ast2500 and we have tried many way to
> avoid using slave_enable() to toggle slave mode but there is no progress.
I see. I also can't help you there. I have neither experience with nor
access to this HW.
> Our expectation is still to have this driver upstream'ed and I'm thinking
> about testing this driver on other HW and re-post the driver.
That sounds like a good plan.
> I have to admit that you are all right with the above comments. The fact is
> we still not be able to find any way to solve this differently. We don't own
> this HW and dont know what happen on this particular issue. The SCL clock
> stretching on this HW does not work as expected and the slave_enable() is
> the only solution for now. I hope if someone could help with the issue as
> well.
From this distance, it looks like HW access and a logic analyzer might
be helpful in understanding the behaviour. Pity that you don't own the
HW.
Good luck nonetheless!
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-30 10:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 3:38 [PATCH v5 0/3] Add SSIF BMC driver Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-14 3:38 ` [PATCH v5 1/3] i2c: aspeed: Add slave_enable() to toggle slave mode Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-08-12 7:39 ` Wolfram Sang
2021-08-12 7:39 ` Wolfram Sang
2021-08-12 7:39 ` Wolfram Sang
2021-08-12 13:36 ` [Openipmi-developer] " Corey Minyard
2021-08-12 13:36 ` Corey Minyard
2021-08-12 13:36 ` Corey Minyard
2021-11-29 19:22 ` Wolfram Sang
2021-11-29 19:22 ` Wolfram Sang
2021-11-29 19:22 ` Wolfram Sang
2021-11-30 2:08 ` Quan Nguyen
2021-11-30 2:08 ` Quan Nguyen
2021-11-30 2:08 ` Quan Nguyen
2021-11-30 10:02 ` Wolfram Sang [this message]
2021-11-30 10:02 ` Wolfram Sang
2021-11-30 10:02 ` Wolfram Sang
2021-07-14 3:38 ` [PATCH v5 2/3] ipmi: ssif_bmc: Add SSIF BMC driver Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-14 3:38 ` [PATCH v5 3/3] bindings: ipmi: Add binding for " Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-14 3:38 ` Quan Nguyen
2021-07-15 17:43 ` Rob Herring
2021-07-15 17:43 ` Rob Herring
2021-07-15 17:43 ` Rob Herring
2021-07-16 2:45 ` Quan Nguyen
2021-07-16 2:45 ` Quan Nguyen
2021-07-16 2:45 ` Quan Nguyen
2021-07-15 23:32 ` [PATCH v5 0/3] Add " Corey Minyard
2021-07-15 23:32 ` Corey Minyard
2021-07-15 23:32 ` Corey Minyard
2021-07-16 2:47 ` Quan Nguyen
2021-07-16 2:47 ` Quan Nguyen
2021-07-16 2:47 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaX2021qO696FG1D@ninjato \
--to=wsa@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.