From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Olivier Moysan <olivier.moysan@st.com>,
linux-kernel@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Liam Girdwood <lgirdwood@gmail.com>,
amelie.delaunay@foss.st.com, Mark Brown <broonie@kernel.org>,
fabrice.gasnier@foss.st.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
alain.volmat@foss.st.com, arnaud.pouliquen@foss.st.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: stm32: i2s: allow additional properties.
Date: Wed, 1 Dec 2021 16:31:39 -0600 [thread overview]
Message-ID: <Yaf3yy3tiTOaNBDY@robh.at.kernel.org> (raw)
In-Reply-To: <20211125144053.774-3-olivier.moysan@foss.st.com>
On Thu, Nov 25, 2021 at 03:40:51PM +0100, Olivier Moysan wrote:
> The STM32 SPI peripheral supports both SPI and I2S protocols.
> In the SoC device tree the node describes the peripheral as an
> SPI peripheral by default. This default configuration can be
> overwritten in board device tree to use the IP as an I2S peripheral.
> In this case the address-cells and size-cells properties from
> SoC DT SPI node should not be checked against STM32 I2S bindings.
> Set additionalProperties to "true" to allow these extra properties.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
> Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> index 64b70ac539f8..33ba15363c0f 100644
> --- a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> @@ -73,7 +73,7 @@ required:
> - dmas
> - dma-names
>
> -additionalProperties: false
> +additionalProperties: true
This is only allowed for schemas that are incomplete collections of
properties such as common bindings.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Olivier Moysan <olivier.moysan@st.com>,
arnaud.pouliquen@foss.st.com, amelie.delaunay@foss.st.com,
alain.volmat@foss.st.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
fabrice.gasnier@foss.st.com
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: stm32: i2s: allow additional properties.
Date: Wed, 1 Dec 2021 16:31:39 -0600 [thread overview]
Message-ID: <Yaf3yy3tiTOaNBDY@robh.at.kernel.org> (raw)
In-Reply-To: <20211125144053.774-3-olivier.moysan@foss.st.com>
On Thu, Nov 25, 2021 at 03:40:51PM +0100, Olivier Moysan wrote:
> The STM32 SPI peripheral supports both SPI and I2S protocols.
> In the SoC device tree the node describes the peripheral as an
> SPI peripheral by default. This default configuration can be
> overwritten in board device tree to use the IP as an I2S peripheral.
> In this case the address-cells and size-cells properties from
> SoC DT SPI node should not be checked against STM32 I2S bindings.
> Set additionalProperties to "true" to allow these extra properties.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
> Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> index 64b70ac539f8..33ba15363c0f 100644
> --- a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> @@ -73,7 +73,7 @@ required:
> - dmas
> - dma-names
>
> -additionalProperties: false
> +additionalProperties: true
This is only allowed for schemas that are incomplete collections of
properties such as common bindings.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Olivier Moysan <olivier.moysan@st.com>,
arnaud.pouliquen@foss.st.com, amelie.delaunay@foss.st.com,
alain.volmat@foss.st.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
fabrice.gasnier@foss.st.com
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: stm32: i2s: allow additional properties.
Date: Wed, 1 Dec 2021 16:31:39 -0600 [thread overview]
Message-ID: <Yaf3yy3tiTOaNBDY@robh.at.kernel.org> (raw)
In-Reply-To: <20211125144053.774-3-olivier.moysan@foss.st.com>
On Thu, Nov 25, 2021 at 03:40:51PM +0100, Olivier Moysan wrote:
> The STM32 SPI peripheral supports both SPI and I2S protocols.
> In the SoC device tree the node describes the peripheral as an
> SPI peripheral by default. This default configuration can be
> overwritten in board device tree to use the IP as an I2S peripheral.
> In this case the address-cells and size-cells properties from
> SoC DT SPI node should not be checked against STM32 I2S bindings.
> Set additionalProperties to "true" to allow these extra properties.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
> Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> index 64b70ac539f8..33ba15363c0f 100644
> --- a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
> @@ -73,7 +73,7 @@ required:
> - dmas
> - dma-names
>
> -additionalProperties: false
> +additionalProperties: true
This is only allowed for schemas that are incomplete collections of
properties such as common bindings.
Rob
next prev parent reply other threads:[~2021-12-01 22:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 14:40 [PATCH v2 0/4] ARM: dts: stm32: merge spi and i2s nodes Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` [PATCH v2 1/4] ASoC: dt-bindings: stm32: i2s: add audio-graph-card port Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 21:26 ` Rob Herring
2021-11-25 21:26 ` Rob Herring
2021-11-25 21:26 ` Rob Herring
2021-11-26 10:25 ` Olivier MOYSAN
2021-11-26 10:25 ` Olivier MOYSAN
2021-11-26 10:25 ` Olivier MOYSAN
2021-12-01 22:34 ` Rob Herring
2021-12-01 22:34 ` Rob Herring
2021-12-01 22:34 ` Rob Herring
2021-12-07 13:52 ` Alexandre TORGUE
2021-12-07 13:52 ` Alexandre TORGUE
2021-12-07 13:59 ` [Linux-stm32] " Ahmad Fatoum
2021-12-07 13:59 ` Ahmad Fatoum
2021-12-08 9:55 ` Alexandre TORGUE
2021-12-08 9:55 ` Alexandre TORGUE
2021-12-08 9:55 ` Alexandre TORGUE
2021-12-08 12:08 ` Lee Jones
2021-12-08 12:08 ` Lee Jones
2021-12-08 12:08 ` Lee Jones
2021-12-08 13:34 ` Alexandre TORGUE
2021-12-08 13:34 ` Alexandre TORGUE
2021-12-08 13:34 ` Alexandre TORGUE
2021-12-11 20:05 ` Rob Herring
2021-12-11 20:05 ` Rob Herring
2021-12-11 20:05 ` Rob Herring
2021-12-13 16:26 ` Alexandre TORGUE
2021-12-13 16:26 ` Alexandre TORGUE
2021-12-13 16:26 ` Alexandre TORGUE
2021-11-25 14:40 ` [PATCH v2 2/4] ASoC: dt-bindings: stm32: i2s: allow additional properties Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-12-01 22:31 ` Rob Herring [this message]
2021-12-01 22:31 ` Rob Herring
2021-12-01 22:31 ` Rob Herring
2021-11-25 14:40 ` [PATCH v2 3/4] ASoC: dt-bindings: stm32: i2s: update example Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` [PATCH v2 4/4] ARM: dts: stm32: merge spi and i2s nodes Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
2021-11-25 14:40 ` Olivier Moysan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yaf3yy3tiTOaNBDY@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=amelie.delaunay@foss.st.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=olivier.moysan@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.