Is BBLAYERS_NON_REMOVABLE obsolette?

Is BBLAYERS_NON_REMOVABLE obsolette?

[Alexander A. Filippov]

It seems to me BBLAYERS_NON_REMOVABLE is obsolete.
At least I haven't found where is it used.

Yocto documentation said that was used by the Hob
  https://www.yoctoproject.org/docs/1.5.2/ref-manual/ref-manual.html#var-BBLAYERS_NON_REMOVABLE
that removed since yocto-2.1.
  https://www.yoctoproject.org/tools-resources/projects/hob

Likely it's time to remove this variable.
As I can see it's copied to all layers and assume it's just copy-past.

What do you think?

Re: Is BBLAYERS_NON_REMOVABLE obsolette?

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]

On Thu, Dec 02, 2021 at 01:29:23PM +0000, Alexander A. Filippov wrote:
> It seems to me BBLAYERS_NON_REMOVABLE is obsolete.
> At least I haven't found where is it used.
> 
> Yocto documentation said that was used by the Hob
>   https://www.yoctoproject.org/docs/1.5.2/ref-manual/ref-manual.html#var-BBLAYERS_NON_REMOVABLE
> that removed since yocto-2.1.
>   https://www.yoctoproject.org/tools-resources/projects/hob
> 
> Likely it's time to remove this variable.
> As I can see it's copied to all layers and assume it's just copy-past.
> 
> What do you think?

Yes, please go ahead and remove across the meta-layers.  As you said I don't see
any occurrence of "NON_REMOVABLE" outside of our layers:

```
meta-amd/meta-ethanolx/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-ampere/meta-jade/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-asrock/meta-e3c246d4i/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-bytedance/meta-g220a/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-evb/meta-evb-aspeed/meta-evb-ast2500/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-evb/meta-evb-aspeed/meta-evb-ast2600/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-evb/meta-evb-nuvoton/meta-evb-npcm750/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-evb/meta-evb-raspberrypi/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-facebook/meta-bletchley/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-facebook/meta-tiogapass/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-facebook/meta-yosemitev2/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-fii/meta-kudo/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-hpe/meta-dl360poc/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-ibm/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-ibm/meta-palmetto/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-ibm/meta-romulus/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-ingrasys/meta-zaius/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-inspur/meta-fp5280g2/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-inventec/meta-transformers/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-phosphor/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-quanta/meta-f0b/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-quanta/meta-gbs/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-quanta/meta-gsj/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-quanta/meta-olympus-nuvoton/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-quanta/meta-q71l/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
meta-yadro/meta-nicole/conf/bblayers.conf.sample:BBLAYERS_NON_REMOVABLE ?= " \
```

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Is BBLAYERS_NON_REMOVABLE obsolette?

[Alexander A. Filippov]

On Thu, Dec 02, 2021 at 09:36:56AM -0600, Patrick Williams wrote:
> 
> Yes, please go ahead and remove across the meta-layers.  As you said I don't see
> any occurrence of "NON_REMOVABLE" outside of our layers:
> 

Done.

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/49261

--
Alexander