All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: send vblank event with the attached sequence rather than current
@ 2021-12-02 15:11 ` Mark Yacoub
  0 siblings, 0 replies; 10+ messages in thread
From: Mark Yacoub @ 2021-12-02 15:11 UTC (permalink / raw)
  To: dri-devel
  Cc: chunkuang.hu, Thomas Zimmermann, David Airlie, jason-jh.lin,
	linux-kernel, tzungbi, seanpaul, Mark Yacoub, matthias.bgg,
	Mark Yacoub

From: Mark Yacoub <markyacoub@google.com>

[Why]
drm_handle_vblank_events loops over vblank_event_list to send any event
that is current or has passed.
More than 1 event could be pending with past sequence time that need to
be send. This can be a side effect of drivers without hardware vblank
counter and they depend on the difference in the timestamps and the
frame/field duration calculated in drm_update_vblank_count. This can
lead to 1 vblirq being ignored due to very small diff, resulting in a
subsequent vblank with 2 pending vblank events to be sent, each with a
unique sequence expected by user space.

[How]
Send each pending vblank event with the sequence it's waiting on instead
of assigning the current sequence to all of them.

Fixes igt@kms_flip "Unexpected frame sequence"
Tested on Jacuzzi (MT8183)

Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
---
 drivers/gpu/drm/drm_vblank.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 3417e1ac79185..47da8056abc14 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -1902,7 +1902,7 @@ static void drm_handle_vblank_events(struct drm_device *dev, unsigned int pipe)
 
 		list_del(&e->base.link);
 		drm_vblank_put(dev, pipe);
-		send_vblank_event(dev, e, seq, now);
+		send_vblank_event(dev, e, e->sequence, now);
 	}
 
 	if (crtc && crtc->funcs->get_vblank_timestamp)
-- 
2.34.0.rc2.393.gf8c9666880-goog


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-12-03 18:05 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-02 15:11 [PATCH] drm: send vblank event with the attached sequence rather than current Mark Yacoub
2021-12-02 15:11 ` Mark Yacoub
2021-12-03  7:25 ` Ville Syrjälä
2021-12-03  7:25   ` Ville Syrjälä
2021-12-03 15:58 ` Matthias Brugger
2021-12-03 15:58   ` Matthias Brugger
2021-12-03 18:03   ` Michel Dänzer
2021-12-03 18:03     ` Michel Dänzer
2021-12-03 18:05     ` Mark Yacoub
2021-12-03 18:05       ` Mark Yacoub

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.