All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronak Jain <ronak.jain@xilinx.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
	rajan.vaja@xilinx.com, corbet@lwn.net,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime features
Date: Fri, 3 Dec 2021 10:25:21 +0100	[thread overview]
Message-ID: <YanigXDtuo7MpVg8@kroah.com> (raw)
In-Reply-To: <20211203091814.15582-3-ronak.jain@xilinx.com>

On Fri, Dec 03, 2021 at 01:18:13AM -0800, Ronak Jain wrote:
> Create sysfs entry for runtime feature configuration. The support
>  is added for an over temperature and external watchdog feature.
> 
> The below listed files are used for runtime features configuration:
> /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
> /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
> 
> In order to configure an over temperature or external watchdog
>  features, first the user need to select the valid config id and then
>  the user can configure the value for selected feature config id.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>

Ah, here's the documentation.

You should say so in the Subject line, and the changelog text is not
correct, this is a documentation update.


> ---
> Changes in v3:
> - None
> 
> Changes in v2:
> - Update commit message
> ---
>  .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> index f5724bb5b462..2fde354715a5 100644
> --- a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> +++ b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> @@ -113,3 +113,87 @@ Description:
>  		    # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/health_status
>  
>  Users:		Xilinx
> +
> +What:		/sys/devices/platform/firmware\:zynqmp-firmware/feature_config_*
> +Date:		Aug 2021
> +KernelVersion:	5.14

5.14?

Are these sysfs files already in the kernel tree?

And can you break this up into one entry per sysfs file?

One for the feature_config_id file and one for feature_config_value?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronak Jain <ronak.jain@xilinx.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
	rajan.vaja@xilinx.com, corbet@lwn.net,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime features
Date: Fri, 3 Dec 2021 10:25:21 +0100	[thread overview]
Message-ID: <YanigXDtuo7MpVg8@kroah.com> (raw)
In-Reply-To: <20211203091814.15582-3-ronak.jain@xilinx.com>

On Fri, Dec 03, 2021 at 01:18:13AM -0800, Ronak Jain wrote:
> Create sysfs entry for runtime feature configuration. The support
>  is added for an over temperature and external watchdog feature.
> 
> The below listed files are used for runtime features configuration:
> /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
> /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
> 
> In order to configure an over temperature or external watchdog
>  features, first the user need to select the valid config id and then
>  the user can configure the value for selected feature config id.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>

Ah, here's the documentation.

You should say so in the Subject line, and the changelog text is not
correct, this is a documentation update.


> ---
> Changes in v3:
> - None
> 
> Changes in v2:
> - Update commit message
> ---
>  .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> index f5724bb5b462..2fde354715a5 100644
> --- a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> +++ b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> @@ -113,3 +113,87 @@ Description:
>  		    # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/health_status
>  
>  Users:		Xilinx
> +
> +What:		/sys/devices/platform/firmware\:zynqmp-firmware/feature_config_*
> +Date:		Aug 2021
> +KernelVersion:	5.14

5.14?

Are these sysfs files already in the kernel tree?

And can you break this up into one entry per sysfs file?

One for the feature_config_id file and one for feature_config_value?

thanks,

greg k-h

  reply	other threads:[~2021-12-03  9:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  9:18 [PATCH v3 0/3] Add support for runtime features Ronak Jain
2021-12-03  9:18 ` Ronak Jain
2021-12-03  9:18 ` [PATCH v3 1/3] firmware: xilinx: " Ronak Jain
2021-12-03  9:18   ` Ronak Jain
2021-12-03  9:18 ` [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry " Ronak Jain
2021-12-03  9:18   ` Ronak Jain
2021-12-03  9:25   ` Greg KH [this message]
2021-12-03  9:25     ` Greg KH
2021-12-03 10:17     ` Ronak Jain
2021-12-03 10:17       ` Ronak Jain
2021-12-03  9:18 ` [PATCH v3 3/3] firmware: xilinx: Add sysfs support for feature config Ronak Jain
2021-12-03  9:18   ` Ronak Jain
2021-12-03  9:22   ` Greg KH
2021-12-03  9:22     ` Greg KH
2021-12-03 10:16     ` Ronak Jain
2021-12-03 10:16       ` Ronak Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YanigXDtuo7MpVg8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=ronak.jain@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.