All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: sean.wang@mediatek.com
Cc: nbd@nbd.name, sven@narfation.org, jf@simonwunderlich.de,
	linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: mt76: MT7921K monitor mode not working
Date: Fri, 3 Dec 2021 18:27:52 +0100	[thread overview]
Message-ID: <YapTmM3EztojTS9F@lore-desk> (raw)
In-Reply-To: <1638551402-3864-1-git-send-email-sean.wang@mediatek.com>


[-- Attachment #1.1: Type: text/plain, Size: 1747 bytes --]

> From: Sean Wang <sean.wang@mediatek.com>
> 
> >> On Thursday, 2 December 2021 23:13:31 CET Lorenzo Bianconi wrote:
> >> > IIRC you need to disable runtime-pm and deep-sleep to proper enable
> >> > monitor
> >> > mode:
> >> >
> >> > echo 0 > /sys/kernel/debug/ieee80211/phy<x>/mt76/runtime-pm
> >> > echo 0 > /sys/kernel/debug/ieee80211/phy<x>/mt76/deep-sleep
> >> >
> >> > Can you please give it whirl?
> >>
> >> Jan gave me the card. I've set it to a rather busy channel (2.4GHz
> >> channel 11), created a monitor interface, attached tcpdump and then
> >> waited what happens. I didn't get anything and then I've tried to set
> >> runtime-pm and deep- sleep to 0. This didn't change the behavior for
> >> me at lot. I saw two packets and then it went silent again.
> >>
> >> I wanted to try the same on a different card (ath11k) in the same
> >> system. But it crashed my complete system - so I had to recreate the
> >> test setup. This time, I've set runtime-pm + deep-sleep to 0 before
> >> creating mon0. After doing this, it seemed to work.
> >
> >interesting, adding Sean to the loop here.
> >It seems the fw is mainting a different state in this case.
> 
> fw cannot receive any frame on monitor mode in deeply doze mode
> 
> so it seemed to me we need a patch to explicitly disable pm runtime in driver when monitor interface is enabled until it is being disabled.

ack, I agree, but I guess the point here is what is the difference (from the fw pov) if you disable
runtime-pm/deep-sleep before/after the vif is added. I guess it is supposed to
be the same, right?

Regards,
Lorenzo

> 
> >
> >@Sean: any pointers?
> >
> >Regards,
> >Lorenzo
> >
> >>
> >> Kind regards,
> >>	Sven
> >
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: sean.wang@mediatek.com
Cc: nbd@nbd.name, sven@narfation.org, jf@simonwunderlich.de,
	linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: mt76: MT7921K monitor mode not working
Date: Fri, 3 Dec 2021 18:27:52 +0100	[thread overview]
Message-ID: <YapTmM3EztojTS9F@lore-desk> (raw)
In-Reply-To: <1638551402-3864-1-git-send-email-sean.wang@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

> From: Sean Wang <sean.wang@mediatek.com>
> 
> >> On Thursday, 2 December 2021 23:13:31 CET Lorenzo Bianconi wrote:
> >> > IIRC you need to disable runtime-pm and deep-sleep to proper enable
> >> > monitor
> >> > mode:
> >> >
> >> > echo 0 > /sys/kernel/debug/ieee80211/phy<x>/mt76/runtime-pm
> >> > echo 0 > /sys/kernel/debug/ieee80211/phy<x>/mt76/deep-sleep
> >> >
> >> > Can you please give it whirl?
> >>
> >> Jan gave me the card. I've set it to a rather busy channel (2.4GHz
> >> channel 11), created a monitor interface, attached tcpdump and then
> >> waited what happens. I didn't get anything and then I've tried to set
> >> runtime-pm and deep- sleep to 0. This didn't change the behavior for
> >> me at lot. I saw two packets and then it went silent again.
> >>
> >> I wanted to try the same on a different card (ath11k) in the same
> >> system. But it crashed my complete system - so I had to recreate the
> >> test setup. This time, I've set runtime-pm + deep-sleep to 0 before
> >> creating mon0. After doing this, it seemed to work.
> >
> >interesting, adding Sean to the loop here.
> >It seems the fw is mainting a different state in this case.
> 
> fw cannot receive any frame on monitor mode in deeply doze mode
> 
> so it seemed to me we need a patch to explicitly disable pm runtime in driver when monitor interface is enabled until it is being disabled.

ack, I agree, but I guess the point here is what is the difference (from the fw pov) if you disable
runtime-pm/deep-sleep before/after the vif is added. I guess it is supposed to
be the same, right?

Regards,
Lorenzo

> 
> >
> >@Sean: any pointers?
> >
> >Regards,
> >Lorenzo
> >
> >>
> >> Kind regards,
> >>	Sven
> >
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2021-12-03 17:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <YapBMGjLcjuBo/vw@lore-desk--annotate>
2021-12-03 17:10 ` mt76: MT7921K monitor mode not working sean.wang
2021-12-03 17:10   ` sean.wang
2021-12-03 17:27   ` Lorenzo Bianconi [this message]
2021-12-03 17:27     ` Lorenzo Bianconi
     [not found] <YapTmM3EztojTS9F@lore-desk--annotate>
2021-12-04  0:55 ` sean.wang
2021-12-04  0:55   ` sean.wang
2021-12-06 13:05   ` Sven Eckelmann
2021-12-06 13:05     ` Sven Eckelmann
2021-12-16 21:13     ` Lorenzo Bianconi
2021-12-16 21:13       ` Lorenzo Bianconi
2021-12-17  7:38       ` Sven Eckelmann
2021-12-17  7:38         ` Sven Eckelmann
2022-01-11 10:53       ` Sven Eckelmann
2022-01-11 10:53         ` Sven Eckelmann
2022-01-11 11:02         ` Lorenzo Bianconi
2022-01-11 11:02           ` Lorenzo Bianconi
2021-12-01  9:41 Jan Fuchs
2021-12-01  9:41 ` Jan Fuchs
2021-12-02 22:13 ` Lorenzo Bianconi
2021-12-02 22:13   ` Lorenzo Bianconi
2021-12-03 15:32   ` Sven Eckelmann
2021-12-03 15:32     ` Sven Eckelmann
2021-12-03 16:09     ` Lorenzo Bianconi
2021-12-03 16:09       ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YapTmM3EztojTS9F@lore-desk \
    --to=lorenzo.bianconi@redhat.com \
    --cc=jf@simonwunderlich.de \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=sean.wang@mediatek.com \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.