All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"Intel GFX" <intel-gfx@lists.freedesktop.org>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"DRI Devel" <dri-devel@lists.freedesktop.org>,
	"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses
Date: Sat, 18 Dec 2021 15:49:23 +0200	[thread overview]
Message-ID: <Yb3m47syo/ODE8O6@intel.intel> (raw)
In-Reply-To: <Yb1pjMefjcCn1Ccm@mdroper-desk1.amr.corp.intel.com>

Hi Matt,

> > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> > index 95174938b160..3c984553d86f 100644
> > --- a/drivers/gpu/drm/i915/i915_driver.c
> > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > @@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)
> >  
> >  	i915_perf_init(dev_priv);
> >  
> > +	intel_gt_init_hw_early(to_gt(dev_priv), &dev_priv->ggtt);
> > +
> 
> Does moving this call earlier in the function need to happen in patch
> #13 rather than here?  That patch converts the internals of
> i915_ggtt_probe_hw() to use to_gt()->ggtt, but I believe until this
> patch that pointer is uninitialized.

yes... you cought me lazy... I will move it to #13.

Thanks,
Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"Andi Shyti" <andi@etezian.org>,
	"Intel GFX" <intel-gfx@lists.freedesktop.org>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"DRI Devel" <dri-devel@lists.freedesktop.org>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Andi Shyti" <andi.shyti@linux.intel.com>
Subject: Re: [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses
Date: Sat, 18 Dec 2021 15:49:23 +0200	[thread overview]
Message-ID: <Yb3m47syo/ODE8O6@intel.intel> (raw)
In-Reply-To: <Yb1pjMefjcCn1Ccm@mdroper-desk1.amr.corp.intel.com>

Hi Matt,

> > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> > index 95174938b160..3c984553d86f 100644
> > --- a/drivers/gpu/drm/i915/i915_driver.c
> > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > @@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)
> >  
> >  	i915_perf_init(dev_priv);
> >  
> > +	intel_gt_init_hw_early(to_gt(dev_priv), &dev_priv->ggtt);
> > +
> 
> Does moving this call earlier in the function need to happen in patch
> #13 rather than here?  That patch converts the internals of
> i915_ggtt_probe_hw() to use to_gt()->ggtt, but I believe until this
> patch that pointer is uninitialized.

yes... you cought me lazy... I will move it to #13.

Thanks,
Andi

  reply	other threads:[~2021-12-18 13:49 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 19:33 [Intel-gfx] [PATCH v8 00/16] More preparation for multi gt patches Andi Shyti
2021-12-14 19:33 ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 01/16] drm/i915: Store backpointer to GT in uncore Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 02/16] drm/i915: Introduce to_gt() helper Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 03/16] drm/i915/display: Use " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 04/16] drm/i915/gt: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 05/16] drm/i915/gem: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 06/16] drm/i915/gvt: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 07/16] drm/i915/selftests: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 08/16] drm/i915/pxp: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 09/16] drm/i915: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 10/16] drm/i915: Rename i915->gt to i915->gt0 Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-17  0:41   ` [Intel-gfx] " Sundaresan, Sujaritha
2021-12-17  0:41     ` Sundaresan, Sujaritha
2021-12-18  4:44   ` [Intel-gfx] " Matt Roper
2021-12-18  4:44     ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 12/16] drm/i915/display: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-16 23:13   ` [Intel-gfx] " Sundaresan, Sujaritha
2021-12-18  4:45   ` Matt Roper
2021-12-18  4:45     ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 13/16] drm/i915/gt: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-16 23:12   ` [Intel-gfx] " Sundaresan, Sujaritha
2021-12-18  4:46   ` Matt Roper
2021-12-18  4:46     ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 14/16] drm/i915/selftests: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-16 23:11   ` [Intel-gfx] " Sundaresan, Sujaritha
2021-12-18  4:49   ` Matt Roper
2021-12-18  4:49     ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 15/16] drm/i915: " Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-18  4:54   ` [Intel-gfx] " Matt Roper
2021-12-18  4:54     ` Matt Roper
2021-12-18 13:49     ` Andi Shyti [this message]
2021-12-18 13:49       ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 16/16] drm/i915: Remove unused i915->ggtt Andi Shyti
2021-12-14 19:33   ` Andi Shyti
2021-12-16 21:26   ` [Intel-gfx] " Sundaresan, Sujaritha
2021-12-18  5:05   ` Matt Roper
2021-12-18  5:05     ` Matt Roper
2021-12-14 19:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More preparation for multi gt patches Patchwork
2021-12-14 19:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-12-14 20:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-15  7:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-18  6:11   ` Matt Roper
2021-12-18 14:02     ` Andi Shyti
2021-12-20  4:03     ` Vudum, Lakshminarayana
2021-12-17 10:12 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for More preparation for multi gt patches (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb3m47syo/ODE8O6@intel.intel \
    --to=andi.shyti@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=michal.winiarski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.