All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Martyn Welch <martyn.welch@collabora.com>
Cc: netdev@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Gabriel Hojda <ghojda@yo2urs.ro>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Steve Glendinning <steve.glendinning@shawell.net>,
	UNGLinuxDriver@microchip.com,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	stable@kernel.org
Subject: Re: Issues with smsc95xx driver since a049a30fc27c
Date: Sat, 18 Dec 2021 17:45:08 +0100	[thread overview]
Message-ID: <Yb4QFDQ0rFfFsT+Y@lunn.ch> (raw)
In-Reply-To: <199eebbd6b97f52b9119c9fa4fd8504f8a34de18.camel@collabora.com>

On Fri, Dec 17, 2021 at 03:45:08PM +0000, Martyn Welch wrote:
> I've had some reports of the smsc95xx driver failing to work for the
> ODROID-X2 and ODROID-U3 since a049a30fc27c was merged (also backported
> to 5.15.y stable branch, which I believe is what those affected by this
> are using).
> 
> Since then we have performed a number of tests, here's what we've found
> so far:
> 
> ODROID-U3 (built-in LAN9730):
> 
>  - No errors reported from smsc95xx driver, however networking broken
>    (can not perform DHCP via NetworkManager, Fedora user space).
> 
>  - Networking starts working if device forced into promiscuous mode
>    (Gabriel noticed this whilst running tcpdump)
> 
> 
> ODROID-X2 (built in LAN9514):
> 
>  - Networking not brought up (Using Debian Buster and Bullseye with
> traditional `/etc/network/interfaces` approach).
> 
>  - As with Odroid-u3, works when running in promiscuous mode.

Hi Martyn

Promisc mode is really odd, given what

commit a049a30fc27c1cb2e12889bbdbd463dbf750103a
Author: Martyn Welch <martyn.welch@collabora.com>
Date:   Mon Nov 22 18:44:45 2021 +0000

    net: usb: Correct PHY handling of smsc95xx

does. Has it been confirmed this is really the patch which causes
the problem?

Does mii-tool -vvv how any difference between the working and broken
case?

Can you also confirm the same PHY driver is used before/after this
patch. There is a chance one is using a specific PHY driver and the
other genphy.

    Andrew

  reply	other threads:[~2021-12-18 16:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 15:45 Issues with smsc95xx driver since a049a30fc27c Martyn Welch
2021-12-18 16:45 ` Andrew Lunn [this message]
2021-12-18 17:23   ` Gabriel Hojda
2021-12-18 18:22     ` Andrew Lunn
2021-12-18 18:32       ` Andrew Lunn
2021-12-18 20:33         ` Gabriel Hojda
2021-12-20 10:37           ` Markus Reichl
     [not found]         ` <c95954ec12dfcf8877c1bf92047c0268@yo2urs.ro>
2021-12-20  8:53           ` Andrew Lunn
2021-12-20 20:04             ` Gabriel Hojda
2021-12-20 21:28             ` Gabriel Hojda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb4QFDQ0rFfFsT+Y@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=ghojda@yo2urs.ro \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=m.reichl@fivetechno.de \
    --cc=m.szyprowski@samsung.com \
    --cc=martyn.welch@collabora.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=steve.glendinning@shawell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.