From: Andrew Lunn <andrew@lunn.ch>
To: Gabriel Hojda <ghojda@yo2urs.ro>
Cc: Martyn Welch <martyn.welch@collabora.com>,
netdev@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Markus Reichl <m.reichl@fivetechno.de>,
Steve Glendinning <steve.glendinning@shawell.net>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
stable@kernel.org
Subject: Re: Issues with smsc95xx driver since a049a30fc27c
Date: Sat, 18 Dec 2021 19:32:46 +0100 [thread overview]
Message-ID: <Yb4pTu3FtkGPPpzb@lunn.ch> (raw)
In-Reply-To: <Yb4m3xms1zMf5C3T@lunn.ch>
> O.K, stab in the dark. Does the hardware need to be programmed with
> the MAC address? When does this happen? If this is going wrong, it
> could explain the promisc mode. If the MAC address has not been
> programmed, it has no idea what packets are for itself. Put it into
> promisc mode, and it will receive everything, including what it is
> supposed to receive. But looking at the offending patch, it is not
> obvious how it has anything to do with MAC addresses. The only
> unbalanced change in that patch is that smsc95xx_reset(dev) has
> disappeared, not moved to somewhere else.
Ah!
smsc95xx_reset() calls smsc95xx_set_mac_address(). So that fits.
smsc95xx_reset() is also called in smsc95xx_bind(), but maybe that is
not enough?
Andrew
next prev parent reply other threads:[~2021-12-18 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:45 Issues with smsc95xx driver since a049a30fc27c Martyn Welch
2021-12-18 16:45 ` Andrew Lunn
2021-12-18 17:23 ` Gabriel Hojda
2021-12-18 18:22 ` Andrew Lunn
2021-12-18 18:32 ` Andrew Lunn [this message]
2021-12-18 20:33 ` Gabriel Hojda
2021-12-20 10:37 ` Markus Reichl
[not found] ` <c95954ec12dfcf8877c1bf92047c0268@yo2urs.ro>
2021-12-20 8:53 ` Andrew Lunn
2021-12-20 20:04 ` Gabriel Hojda
2021-12-20 21:28 ` Gabriel Hojda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yb4pTu3FtkGPPpzb@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=ghojda@yo2urs.ro \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=m.szyprowski@samsung.com \
--cc=martyn.welch@collabora.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.