All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Hellstrom Thomas <thomas.hellstrom@intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory
Date: Wed, 8 Dec 2021 18:11:25 +0200	[thread overview]
Message-ID: <YbDZLbW28G5q0A0h@intel.intel> (raw)
In-Reply-To: <20211208141613.7251-4-ramalingam.c@intel.com>

Hi Ram and Matt,

> On some platforms the hw has dropped support for 4K GTT pages when
> dealing with LMEM, and due to the design of 64K GTT pages in the hw, we
> can only mark the *entire* page-table as operating in 64K GTT mode,
> since the enable bit is still on the pde, and not the pte. And since we
> we still need to allow 4K GTT pages for SMEM objects, we can't have a
> "normal" 4K page-table with scratch pointing to LMEM, since that's
> undefined from the hw pov. The simplest solution is to just move the 64K
> scratch page to SMEM on such platforms and call it a day, since that
> should work for all configurations.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Reviewed-by: Thomas Hellstrom <thomas.hellstrom@linux.intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Andi

  reply	other threads:[~2021-12-08 16:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 14:16 [Intel-gfx] [PATCH 0/4] drm/i915: Basic enabling of 64k page support Ramalingam C
2021-12-08 14:16 ` Ramalingam C
2021-12-08 14:16 ` [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag Ramalingam C
2021-12-08 14:16   ` Ramalingam C
2021-12-08 16:08   ` [Intel-gfx] " Andi Shyti
2021-12-08 14:16 ` [Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K Ramalingam C
2021-12-08 14:16   ` Ramalingam C
2021-12-08 14:34   ` [Intel-gfx] " Matthew Auld
2021-12-08 14:34     ` Matthew Auld
2021-12-08 15:10     ` [Intel-gfx] " Thomas Hellström
2021-12-08 15:10       ` Thomas Hellström
2021-12-08 15:48       ` [Intel-gfx] " Ramalingam C
2021-12-08 15:48         ` Ramalingam C
2021-12-08 16:09   ` [Intel-gfx] " Andi Shyti
2021-12-08 14:16 ` [Intel-gfx] [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory Ramalingam C
2021-12-08 14:16   ` Ramalingam C
2021-12-08 16:11   ` Andi Shyti [this message]
2021-12-08 14:16 ` [Intel-gfx] [PATCH 4/4] drm/i915: enforce min page size for scratch Ramalingam C
2021-12-08 14:16   ` Ramalingam C
2021-12-08 16:12   ` [Intel-gfx] " Andi Shyti
2021-12-08 15:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Basic enabling of 64k page support Patchwork
2021-12-08 16:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-08 20:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Basic enabling of 64k page support (rev2) Patchwork
2021-12-08 21:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-09  3:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-09 16:45 ` [Intel-gfx] [PATCH 0/4] drm/i915: Basic enabling of 64k page support Ramalingam C
2021-12-09 16:45   ` Ramalingam C
  -- strict thread matches above, loose matches on Subject: below --
2021-12-07 16:51 [Intel-gfx] [PATCH 0/4] " Ramalingam C
2021-12-07 16:51 ` [Intel-gfx] [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory Ramalingam C
2021-12-08 13:26   ` Thomas Hellström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbDZLbW28G5q0A0h@intel.intel \
    --to=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=ramalingam.c@intel.com \
    --cc=thomas.hellstrom@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.