* [PATCH] dt-bindings: PCI: brcmstb: compatible is required
@ 2021-12-02 22:36 ` Florian Fainelli
0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2021-12-02 22:36 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Nicolas Saenz Julienne,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Jim Quinlan,
Bjorn Helgaas, Rob Herring, Saenz Julienne,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:BROADCOM STB PCIE DRIVER, open list
The compatible property is required, make sure the binding documents it
as such.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 1fe102743f82..7c24d711b377 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -76,6 +76,7 @@ properties:
maxItems: 3
required:
+ - compatible
- reg
- ranges
- dma-ranges
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] dt-bindings: PCI: brcmstb: compatible is required
@ 2021-12-02 22:36 ` Florian Fainelli
0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2021-12-02 22:36 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Nicolas Saenz Julienne,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Jim Quinlan,
Bjorn Helgaas, Rob Herring, Saenz Julienne,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:BROADCOM STB PCIE DRIVER, open list
The compatible property is required, make sure the binding documents it
as such.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 1fe102743f82..7c24d711b377 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -76,6 +76,7 @@ properties:
maxItems: 3
required:
+ - compatible
- reg
- ranges
- dma-ranges
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
2021-12-02 22:36 ` Florian Fainelli
@ 2021-12-02 22:41 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-12-02 22:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Nicolas Saenz Julienne,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Jim Quinlan,
Bjorn Helgaas, Saenz Julienne,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:BROADCOM STB PCIE DRIVER, open list
On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> The compatible property is required, make sure the binding documents it
> as such.
Yes, though if 'compatible' is not present and matching, the schema is
never applied. I'll apply it later, but I wouldn't be too concerned
fixing any others.
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 1fe102743f82..7c24d711b377 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -76,6 +76,7 @@ properties:
> maxItems: 3
>
> required:
> + - compatible
> - reg
> - ranges
> - dma-ranges
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
@ 2021-12-02 22:41 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-12-02 22:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Nicolas Saenz Julienne,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Jim Quinlan,
Bjorn Helgaas, Saenz Julienne,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:BROADCOM STB PCIE DRIVER, open list
On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> The compatible property is required, make sure the binding documents it
> as such.
Yes, though if 'compatible' is not present and matching, the schema is
never applied. I'll apply it later, but I wouldn't be too concerned
fixing any others.
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 1fe102743f82..7c24d711b377 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -76,6 +76,7 @@ properties:
> maxItems: 3
>
> required:
> + - compatible
> - reg
> - ranges
> - dma-ranges
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
2021-12-02 22:41 ` Rob Herring
@ 2021-12-02 22:53 ` Florian Fainelli
-1 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2021-12-02 22:53 UTC (permalink / raw)
To: Rob Herring, Florian Fainelli
Cc: devicetree, Nicolas Saenz Julienne,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Jim Quinlan,
Bjorn Helgaas, Saenz Julienne,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:BROADCOM STB PCIE DRIVER, open list
On 12/2/21 2:41 PM, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> The compatible property is required, make sure the binding documents it
>> as such.
>
> Yes, though if 'compatible' is not present and matching, the schema is
> never applied. I'll apply it later, but I wouldn't be too concerned
> fixing any others.
OK, just happened to run into that one by accident while converting the
iProc PCIe binding to YAML.
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
@ 2021-12-02 22:53 ` Florian Fainelli
0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2021-12-02 22:53 UTC (permalink / raw)
To: Rob Herring, Florian Fainelli
Cc: devicetree, Nicolas Saenz Julienne,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Jim Quinlan,
Bjorn Helgaas, Saenz Julienne,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:BROADCOM STB PCIE DRIVER, open list
On 12/2/21 2:41 PM, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> The compatible property is required, make sure the binding documents it
>> as such.
>
> Yes, though if 'compatible' is not present and matching, the schema is
> never applied. I'll apply it later, but I wouldn't be too concerned
> fixing any others.
OK, just happened to run into that one by accident while converting the
iProc PCIe binding to YAML.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
2021-12-02 22:36 ` Florian Fainelli
@ 2021-12-08 19:49 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-12-08 19:49 UTC (permalink / raw)
To: Florian Fainelli
Cc: Bjorn Helgaas, Nicolas Saenz Julienne, bcm-kernel-feedback-list,
Rob Herring, Saenz Julienne, linux-kernel, linux-arm-kernel,
devicetree, Jim Quinlan, linux-pci, linux-rpi-kernel
On Thu, 02 Dec 2021 14:36:09 -0800, Florian Fainelli wrote:
> The compatible property is required, make sure the binding documents it
> as such.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
@ 2021-12-08 19:49 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-12-08 19:49 UTC (permalink / raw)
To: Florian Fainelli
Cc: Bjorn Helgaas, Nicolas Saenz Julienne, bcm-kernel-feedback-list,
Rob Herring, Saenz Julienne, linux-kernel, linux-arm-kernel,
devicetree, Jim Quinlan, linux-pci, linux-rpi-kernel
On Thu, 02 Dec 2021 14:36:09 -0800, Florian Fainelli wrote:
> The compatible property is required, make sure the binding documents it
> as such.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-12-08 19:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-02 22:36 [PATCH] dt-bindings: PCI: brcmstb: compatible is required Florian Fainelli
2021-12-02 22:36 ` Florian Fainelli
2021-12-02 22:41 ` Rob Herring
2021-12-02 22:41 ` Rob Herring
2021-12-02 22:53 ` Florian Fainelli
2021-12-02 22:53 ` Florian Fainelli
2021-12-08 19:49 ` Rob Herring
2021-12-08 19:49 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.